Mailing-List: contact jena-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jena-dev@incubator.apache.org
Date: Thu, 6 Oct 2011 13:16:29 +0000 (UTC)
From: "Paolo Castagna (Commented) (JIRA)" <jira@apache.org>
To: jena-dev@incubator.apache.org
Message-ID: 
 <1272506459.3248.1317906989697.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1236263707.11545.1317394185613.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (JENA-127) Add RDF/JSON Parsing Support to RIOT
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JENA-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121914#comment-13121914 ] 

Paolo Castagna commented on JENA-127:
-------------------------------------

Rob, how you generated the https://issues.apache.org/jira/secure/attachment/12497441/RdfJsonRiotPatch-ApacheSVN.patch file?
I usually simply do: svn diff > filename.patch.
You patch file contains lines (marked as additions) which have not actually being changed.
I usually review changes side by side from Eclipse or directly on the patch file, but with your patch this is not possible since it contains files which are not actually changes.
I am now going to manually replicate your changes and build a new patch or directly submit changes to SVN.
                
> Add RDF/JSON Parsing Support to RIOT
> ------------------------------------
>
>                 Key: JENA-127
>                 URL: https://issues.apache.org/jira/browse/JENA-127
>             Project: Jena
>          Issue Type: New Feature
>          Components: Jena, RIOT
>         Environment: All
>            Reporter: Rob Vesse
>            Assignee: Paolo Castagna
>            Priority: Minor
>              Labels: patch, rdf/json, riot
>         Attachments: JenaReaderRdfJson.java, LangRDFJSON.java, RdfJsonRiotPatch-ApacheSVN.patch, RdfJsonRiotPatch.patch, RdfJsonRiotPatch.patch, TestLangRdfJson.java, TestLangRdfJson.java
>
>
> The attached patch provides a RDF/JSON (Talis Specification) parser for RIOT, the patch is against ARQ trunk from the Jena SourceForge SVN repository
> It plugs in as an implementation of LangRIOT (named LangRDFJSON) and uses the existing TokenizerJSON from the atlas package to do the tokenisation.  There is also a JenaReaderRdfJson added as part of this patch which does what the name suggests.
> I have also included in this patch a set of unit tests which verify the parsers behaviour with a variety of valid and invalid inputs.
> There are still some things to be addressed:
> - The patch includes registration of the Jena reader when SysRiot.writeIntoJena() is called but does not unregister itself when resetJenaReaders() is called, should this be done?
> - Add a RDF/JSON writer - a separate patch will be submitted at a later date (likely next week) for this
> Otherwise the patch is fairly comprehensive and I hope can be reviewed and included in future releases
> EDIT - I have now redone the patch against Apache SVN as well and attached that as a separate file since there are some differences in the structure of the two repos and some minor code changes that mean the SourceForge SVN patch cannot be applied directly against Apache SVN

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira