incubator-isis-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dan Haywood <...@haywood-associates.co.uk>
Subject RC2 fixes to RC1
Date Sun, 05 Feb 2012 17:29:21 GMT
For those of you who are looking to vote on RC2 and wanted to know what the
fixes were for Mark's -1 on RC1 (perhaps just Mark, I dunno), I've inlined
answers below.


On 31 January 2012 10:03, Dan Haywood <dan@haywood-associates.co.uk> wrote:

>
>> The Bad:
>>
>> Dependencies:
>>
>> I found the following dependencies which we should check.
>>
>>  - aopalliance (http://aopalliance.sourceforge.net/aopalliance)
>> aopalliance:aopalliance:jar:1.0:compile
>>     License: Public Domain.
>> This one might be fine, but I need to dig those licenses further.
>>
>
Well, I think it's widely used, as it's a dependency of google guice, and
this isn't a new dependency.



>
>> - Glassfish Jasper (http://jetty.mortbay.org/project/modules/jsp-2.1)
>> org.mortbay.jetty:jsp-2.1:jar:6.1.14
>>     License: CDDL 1.0  (
>> https://glassfish.dev.java.net/public/CDDLv1.0.html)
>>
>> - Servlet Specification 2.5 API (
>> http://jetty.mortbay.org/project/modules/servlet-api-2.5)
>> org.mortbay.jetty:servlet-api-2.5:jar:6.1.14
>>     License: CDDL 1.0  (
>> https://glassfish.dev.java.net/public/CDDLv1.0.html)
>>
>> Where does this come from? I thought we use org.apache.geronimo.specs
>> APIs instead now? Are they coming in as transitive dependency?
>>
>
They came from me modifying the runtimes.dflt:webserver to be able to
support JSPs.  I've now added an exclude dependency, and made sure that
geronimo specs are used.



>
>>
>> RAT (Release Audit Tool):
>>
>> $> mvn apache-rat:check
>> $> less target/rat.txt
>>
>> RAT shows 720 unapproved licenses.
>
>
All now fixed.  You'll see the configuration in the parent pom.xml as to
what is excluded; the contributors guide [1] also has this detailed.


Mainly xml files e.g. core/commons/core-commons.java.hsp
>> Those should get an ALv2 header as well. Same with docbook and a few
>> others. Basically all which is not generated.
>>
>
fwiw, the .java.hsp is a Structure101 [2] project file (cf Eclipse .project
and .classpath etc)





>
>> Btw, this file also contains a local file path
>> <classpathentry kind="lib"
>> path="D:\SVN\ai\isis\trunk\core\commons\target\classes" />
>> Is this really needed? This is checked in to our SVN, but Isis still
>> builds fine over here. And since I (almost) only use Linux and Mac, I'm
>> pretty sure such a directory doen't exist over here ;)
>>
>
The file is used for the documentation, eg [3,4].  It's an excellent tool,
and Paul Hickey of the company was happy to give us an open source license
(I suspect he might for other Apache projects too, if asked nicely).

As for the hard-coded pathnames, they can't be avoided, it just seems to be
the way that tool works.  However, I've moved those files out of
trunk/framework and into a non-releasable dir, trunk/structure101.

Dan


[1]
http://incubator.apache.org/isis-0.2.0-incubating/docbkx/html/guide/ch12.html#sec.RatTool
[2] http://www.headwaysoftware.com/products/
[3]
http://incubator.apache.org/isis-0.2.0-incubating/core/docbkx/html/guide/ch03.html#d0e619
[4]
http://incubator.apache.org/isis-0.2.0-incubating/core/docbkx/html/guide/ch04.html#d0e1064





>
>>
>> Thus a
>>
>> -1
>>
>>
>> and sorry for being so picky ;)
>> (and also for taking so long)
>>
>> LieGrue,
>> strub
>>
>>
>>
>> ----- Original Message -----
>> > From: Dan Haywood <dan@haywood-associates.co.uk>
>> > To: isis-dev@incubator.apache.org
>> > Cc:
>> > Sent: Thursday, January 26, 2012 5:49 PM
>> > Subject: [VOTE] Apache Isis 0.2.0-incubating (RC1)
>> >
>> > All,
>> >
>> > I've staged a release for Apache Isis, namely 0.2.0-incubating.The
>> > artifacts have been staged to staging repository
>> onrepository.apache.org:
>> > *
>> >
>> https://repository.apache.org/content/repositories/orgapacheisis-139/org/apache/isis/isis/0.2.0-incubating/isis-0.2.0-incubating-source-release.zip
>> > (zip
>> > file)
>> > *
>> >
>> https://repository.apache.org/content/repositories/orgapacheisis-139/org/apache/isis/isis/0.2.0-incubating/isis-0.2.0-incubating-source-release.zip.asc
>> > (signature)
>> >
>> > In Subversion the code has been tagged as tags/isis-0.2.0-incubating.
>> >
>> > I've also uploaded a new version of the site at
>> > http://incubator.apache.org/isis-0.2.0-incubating.
>> >
>> > The contributors guide on the site contains some suggestions of how to
>> > verify the release, see
>> >
>> http://incubator.apache.org/isis-0.2.0-incubating/docbkx/html/guide/ch12.html
>> >
>> > Please verify the release and cast your vote.  The vote will be open
>> for at
>> > least 72 hours.
>> >
>> > [ ] +1
>> > [ ]  0
>> > [ ] -1
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message