incubator-isis-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Meyer (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (ISIS-10) Properly use prepared statements instead of injecting values into "insert" and "update" SQL statements
Date Sat, 10 Sep 2011 20:21:08 GMT

     [ https://issues.apache.org/jira/browse/ISIS-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kevin Meyer resolved ISIS-10.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 0.1.2-incubating

All statements (insert, update, etc) use prepared statements. Values are not converted to
String unless the base ValueMapper is a String value.

> Properly use prepared statements instead of injecting values into "insert" and "update"
SQL statements
> ------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-10
>                 URL: https://issues.apache.org/jira/browse/ISIS-10
>             Project: Isis
>          Issue Type: Improvement
>          Components: Runtimes: Dflt: Objectstores: SQL
>    Affects Versions: 0.1.2-incubating
>            Reporter: Kevin Meyer
>            Assignee: Kevin Meyer
>            Priority: Minor
>             Fix For: 0.1.2-incubating
>
>   Original Estimate: 168h
>          Time Spent: 12h
>  Remaining Estimate: 40h
>
> At the moment, all "insert" and "update" commands use a fully formed SQL string with
embedded values:
> "insert into SQLDATACLASS (PK_ID, color,date_time) values (2252, '0','2010-03-05 22:23:000000')".
> This should be updated to "insert into SQLDATACLASS (PK_ID, color,date_time) values (?,?,?)".
> This should also solve issues with quoting values such as (especially affecting DB2)
quoting integer, float, etc, non-string values. DB2 is throwing an exception when integers
and floats are quoted ('1') instead of (1).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message