Mailing-List: contact isis-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: isis-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of dkhaywood@gmail.com designates
 74.125.82.175 as permitted sender)
Message-ID: <4E2814AF.7050400@gmail.com>
Date: Thu, 21 Jul 2011 12:59:43 +0100
From: Dan Haywood <dkhaywood@gmail.com>
Reply-To: dan@haywood-associates.co.uk
Organization: Haywood Associates Ltd.
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:5.0) Gecko/20110624 Thunderbird/5.0
MIME-Version: 1.0
To: isis-dev@incubator.apache.org
Subject: Re: Commit 1148917: Changes for Maven3
References: <c66f72aaf081d97a57a233ae58ea9c07.squirrel@webmail.kmz.co.za>
In-Reply-To: <c66f72aaf081d97a57a233ae58ea9c07.squirrel@webmail.kmz.co.za>
Content-Type: multipart/mixed;
 boundary="------------060501010102020902070806"

--------------060501010102020902070806
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi Kevin/all

Yes, sorry... a half-done commit.  Ain't Fisheye wonderful though!

Anyway.... following your recent work on Maven3, I did try out building 
the site using Maven3, making local edits to the pom.xml to (a) remove 
the enforcer-plugin restriction on Maven version and (b) bumping 
mvn-site-plugin version from 2.2 to 3.0-beta-3.  Doing that I *did* find 
that it built successfully for me.

What r1148917 commit was commit was just (a); I was forgetting that the 
mvn-site-plugin version needs updating too, and I was also forgetting 
the point you've made, namely that making the change prevents building 
the site in both Maven3 and Maven2 (for the reason you describe).

That said, I don't think it's a big deal if the site can't be built 
within Maven3.  So long as we continue to allow developers to build Isis 
itself within Maven2 or Maven3, that should be good enough.

Therefore, I propose to:
i) update the mvn-site-plugin version to 3.0-beta-3
ii) update the contributors guide to make the point that building the 
site is only supported in Maven 3
iii) close off ISIS-11 [1] since it will have been addressed.

Any objections to this, please reply here.

Thx
Dan

[1] https://issues.apache.org/jira/browse/ISIS-11


On 21/07/2011 08:55, Kevin Meyer wrote:
> Dan,
>
> Thanks to Nour's getting Isis into the fisheye system[1], I've noticed
> that you updated the framework/pom.xml to allow Maven3 in the rules
> section.
>
> I seem to recall that there is a problem with the site plugin, though.
>
> Maven3 requires a maven-site-plugin of 3.0-beta-3 which in turn, requires
> Maven3. Thus, unless there is a way to build in conditional version
> dependencies into the dependencies sections, the same framework/pom.xml
> can't support both Maven 2 and Maven 3, at least as far as the site
> plugin is concerned...
>
> Any suggestions?
>
> Regards,
> Kevin
>
> PS: Thanks Rob (for the nudge) and Nour for switching on the Fisheye view!
>
> [1] https://fisheye6.atlassian.com/changelog/isis?cs=1148917
>
>

--------------060501010102020902070806--