incubator-isis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danhayw...@apache.org
Subject svn commit: r1103287 [2/2] - in /incubator/isis/trunk: ./ core/commons/src/main/java/org/apache/isis/core/commons/encoding/ core/commons/src/main/java/org/apache/isis/core/commons/xml/ core/progmodel/src/main/java/org/apache/isis/core/progmodel/facets/...
Date Sun, 15 May 2011 07:42:10 GMT
Modified: incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/object/validate/ObjectValidMethodFacetFactoryTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/object/validate/ObjectValidMethodFacetFactoryTest.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/object/validate/ObjectValidMethodFacetFactoryTest.java
(original)
+++ incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/object/validate/ObjectValidMethodFacetFactoryTest.java
Sun May 15 07:42:08 2011
@@ -48,7 +48,6 @@ public class ObjectValidMethodFacetFacto
 
 
     public void testValidateMethodPickedUpAndMethodRemoved() {
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String validate() {

Modified: incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/ordering/memberorder/MemberOrderAnnotationFacetFactoryTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/ordering/memberorder/MemberOrderAnnotationFacetFactoryTest.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/ordering/memberorder/MemberOrderAnnotationFacetFactoryTest.java
(original)
+++ incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/ordering/memberorder/MemberOrderAnnotationFacetFactoryTest.java
Sun May 15 07:42:08 2011
@@ -51,7 +51,6 @@ public class MemberOrderAnnotationFacetF
 
 
     public void testMemberOrderAnnotationPickedUpOnProperty() {
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @MemberOrder(sequence = "1")
@@ -74,7 +73,6 @@ public class MemberOrderAnnotationFacetF
 
     public void testMemberOrderAnnotationPickedUpOnCollection() {
         class Order {}
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @MemberOrder(sequence = "2")
@@ -98,7 +96,6 @@ public class MemberOrderAnnotationFacetF
     }
 
     public void testMemberOrderAnnotationPickedUpOnAction() {
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @MemberOrder(sequence = "3")

Modified: incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propcoll/notpersisted/NotPersistedAnnotationFacetFactoryTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propcoll/notpersisted/NotPersistedAnnotationFacetFactoryTest.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propcoll/notpersisted/NotPersistedAnnotationFacetFactoryTest.java
(original)
+++ incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propcoll/notpersisted/NotPersistedAnnotationFacetFactoryTest.java
Sun May 15 07:42:08 2011
@@ -40,7 +40,6 @@ public class NotPersistedAnnotationFacet
     public void testNotPersistedAnnotationPickedUpOnProperty() {
         NotPersistedAnnotationForPropertyFacetFactory facetFactory = new NotPersistedAnnotationForPropertyFacetFactory();
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @NotPersisted()
@@ -63,7 +62,6 @@ public class NotPersistedAnnotationFacet
         NotPersistedAnnotationForCollectionFacetFactory facetFactory = new NotPersistedAnnotationForCollectionFacetFactory();
 
         class Order{}
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @NotPersisted()

Modified: incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/properties/PropertyMethodsFacetFactoryTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/properties/PropertyMethodsFacetFactoryTest.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/properties/PropertyMethodsFacetFactoryTest.java
(original)
+++ incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/properties/PropertyMethodsFacetFactoryTest.java
Sun May 15 07:42:08 2011
@@ -83,7 +83,6 @@ public class PropertyMethodsFacetFactory
         PropertyAccessorFacetFactory facetFactory = new PropertyAccessorFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -107,7 +106,6 @@ public class PropertyMethodsFacetFactory
         PropertySetAndClearFacetFactory facetFactory = new PropertySetAndClearFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -135,7 +133,6 @@ public class PropertyMethodsFacetFactory
         PropertySetAndClearFacetFactory facetFactory = new PropertySetAndClearFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -163,7 +160,6 @@ public class PropertyMethodsFacetFactory
         PropertySetAndClearFacetFactory facetFactory = new PropertySetAndClearFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -188,7 +184,6 @@ public class PropertyMethodsFacetFactory
         PropertySetAndClearFacetFactory facetFactoryForSetter = new PropertySetAndClearFacetFactory();
         facetFactoryForSetter.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -220,7 +215,6 @@ public class PropertyMethodsFacetFactory
         PropertyModifyFacetFactory facetFactoryForModify = new PropertyModifyFacetFactory();
         facetFactoryForModify.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -251,7 +245,6 @@ public class PropertyMethodsFacetFactory
         PropertyModifyFacetFactory facetFactoryForModify = new PropertyModifyFacetFactory();
         facetFactoryForModify.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -286,7 +279,6 @@ public class PropertyMethodsFacetFactory
         PropertySetAndClearFacetFactory facetFactory = new PropertySetAndClearFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -314,7 +306,6 @@ public class PropertyMethodsFacetFactory
         PropertySetAndClearFacetFactory facetFactory = new PropertySetAndClearFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -340,7 +331,6 @@ public class PropertyMethodsFacetFactory
         PropertyChoicesFacetFactory facetFactory = new PropertyChoicesFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -370,7 +360,6 @@ public class PropertyMethodsFacetFactory
         PropertyDefaultFacetFactory facetFactory = new PropertyDefaultFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -400,7 +389,6 @@ public class PropertyMethodsFacetFactory
         PropertyValidateFacetFactory facetFactory = new PropertyValidateFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -430,7 +418,6 @@ public class PropertyMethodsFacetFactory
         DisabledFacetViaDisableMethodFacetFactory facetFactory = new DisabledFacetViaDisableMethodFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -460,7 +447,6 @@ public class PropertyMethodsFacetFactory
         DisabledFacetViaDisableMethodFacetFactory facetFactory = new DisabledFacetViaDisableMethodFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -490,7 +476,6 @@ public class PropertyMethodsFacetFactory
         HiddenFacetViaHideMethodFacetFactory facetFactory = new HiddenFacetViaHideMethodFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -520,7 +505,6 @@ public class PropertyMethodsFacetFactory
         HiddenFacetViaHideMethodFacetFactory facetFactory = new HiddenFacetViaHideMethodFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -550,7 +534,6 @@ public class PropertyMethodsFacetFactory
         PropertyAccessorFacetFactory facetFactory = new PropertyAccessorFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -580,7 +563,6 @@ public class PropertyMethodsFacetFactory
         DisabledFacetViaDisableMethodFacetFactory facetFactoryForDisable = new DisabledFacetViaDisableMethodFacetFactory();
         facetFactoryForDisable.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public String getFirstName() {
@@ -590,14 +572,12 @@ public class PropertyMethodsFacetFactory
 
         class CustomerEx extends Customer {
             @SuppressWarnings("unused")
-            @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
             public boolean hideFirstName() {
                 return true;
             }
 
 
             @SuppressWarnings("unused")
-            @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
             public String disableFirstName() {
                 return "disabled";
             }

Modified: incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/multiline/MultiLineAnnotationFacetFactoryTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/multiline/MultiLineAnnotationFacetFactoryTest.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/multiline/MultiLineAnnotationFacetFactoryTest.java
(original)
+++ incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/multiline/MultiLineAnnotationFacetFactoryTest.java
Sun May 15 07:42:08 2011
@@ -58,7 +58,6 @@ public class MultiLineAnnotationFacetFac
     public void testMultiLineAnnotationPickedUpOnProperty() {
         MultiLineAnnotationOnPropertyFacetFactory facetFactory = new MultiLineAnnotationOnPropertyFacetFactory();
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @MultiLine(numberOfLines = 12, preventWrapping = true)
@@ -81,7 +80,6 @@ public class MultiLineAnnotationFacetFac
     public void testMultiLineAnnotationPickedUpOnActionParameter() {
         MultiLineAnnotationOnParameterFacetFactory facetFactory = new MultiLineAnnotationOnParameterFacetFactory();
         
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public void someAction(@MultiLine(numberOfLines = 8, preventWrapping = false)
final String foo) {}
@@ -101,7 +99,6 @@ public class MultiLineAnnotationFacetFac
     public void testMultiLineAnnotationDefaults() {
         MultiLineAnnotationOnTypeFacetFactory facetFactory = new MultiLineAnnotationOnTypeFacetFactory();
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         @MultiLine
         class Customer {}
 
@@ -116,7 +113,6 @@ public class MultiLineAnnotationFacetFac
     public void testMultiLineAnnotationIgnoredForNonStringProperties() {
         MultiLineAnnotationOnPropertyFacetFactory facetFactory = new MultiLineAnnotationOnPropertyFacetFactory();
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @MultiLine(numberOfLines = 8, preventWrapping = false)
@@ -135,7 +131,6 @@ public class MultiLineAnnotationFacetFac
     public void testMultiLineAnnotationIgnoredForNonStringActionParameters() {
         MultiLineAnnotationOnParameterFacetFactory facetFactory = new MultiLineAnnotationOnParameterFacetFactory();
         
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public void someAction(@MultiLine(numberOfLines = 8, preventWrapping = false)
final int foo) {}

Modified: incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/typicallength/TypicalLengthAnnotationFacetFactoryTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/typicallength/TypicalLengthAnnotationFacetFactoryTest.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/typicallength/TypicalLengthAnnotationFacetFactoryTest.java
(original)
+++ incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/typicallength/TypicalLengthAnnotationFacetFactoryTest.java
Sun May 15 07:42:08 2011
@@ -39,7 +39,6 @@ public class TypicalLengthAnnotationFace
     public void testTypicalLengthAnnotationPickedUpOnProperty() {
         TypicalLengthAnnotationOnPropertyFacetFactory facetFactory = new TypicalLengthAnnotationOnPropertyFacetFactory();
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @TypicalLength(30)
@@ -62,7 +61,6 @@ public class TypicalLengthAnnotationFace
         TypicalLengthAnnotationOnParameterFacetFactory facetFactory = new TypicalLengthAnnotationOnParameterFacetFactory();
 
         
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public void someAction(@TypicalLength(20) final int foo) {}

Modified: incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/validate/mandatory/OptionalAnnotationFacetFactoryTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/validate/mandatory/OptionalAnnotationFacetFactoryTest.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/validate/mandatory/OptionalAnnotationFacetFactoryTest.java
(original)
+++ incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/validate/mandatory/OptionalAnnotationFacetFactoryTest.java
Sun May 15 07:42:08 2011
@@ -40,7 +40,6 @@ public class OptionalAnnotationFacetFact
     public void testOptionalAnnotationPickedUpOnProperty() {
         OptionalAnnotationForPropertyFacetFactory facetFactory = new OptionalAnnotationForPropertyFacetFactory();
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @Optional
@@ -60,7 +59,6 @@ public class OptionalAnnotationFacetFact
     public void testOptionalAnnotationPickedUpOnActionParameter() {
         OptionalAnnotationForParameterFacetFactory facetFactory = new OptionalAnnotationForParameterFacetFactory();
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public void someAction(@Optional final String foo) {}
@@ -77,7 +75,6 @@ public class OptionalAnnotationFacetFact
     public void testOptionalAnnotationIgnoredForPrimitiveOnProperty() {
         OptionalAnnotationForPropertyFacetFactory facetFactory = new OptionalAnnotationForPropertyFacetFactory();
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @Optional
@@ -95,7 +92,6 @@ public class OptionalAnnotationFacetFact
     public void testOptionalAnnotationIgnoredForPrimitiveOnActionParameter() {
         OptionalAnnotationForParameterFacetFactory facetFactory = new OptionalAnnotationForParameterFacetFactory();
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public void someAction(@Optional final int foo) {}

Modified: incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/validate/mask/MaskAnnotationFacetFactoryTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/validate/mask/MaskAnnotationFacetFactoryTest.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/validate/mask/MaskAnnotationFacetFactoryTest.java
(original)
+++ incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/validate/mask/MaskAnnotationFacetFactoryTest.java
Sun May 15 07:42:08 2011
@@ -70,7 +70,6 @@ public class MaskAnnotationFacetFactoryT
         MaskAnnotationForPropertyFacetFactory facetFactory = new MaskAnnotationForPropertyFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @Mask("###")
@@ -93,7 +92,6 @@ public class MaskAnnotationFacetFactoryT
         MaskAnnotationForParameterFacetFactory facetFactory = new MaskAnnotationForParameterFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public void someAction(@Mask("###") final String foo) {}
@@ -113,7 +111,6 @@ public class MaskAnnotationFacetFactoryT
         MaskAnnotationForPropertyFacetFactory facetFactory = new MaskAnnotationForPropertyFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @Mask("###")
@@ -132,7 +129,6 @@ public class MaskAnnotationFacetFactoryT
         MaskAnnotationForParameterFacetFactory facetFactory = new MaskAnnotationForParameterFacetFactory();
         facetFactory.setSpecificationLookup(reflector);
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public void someAction(@Mask("###") final int foo) {}

Modified: incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/validate/regex/RegExAnnotationFacetFactoryTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/validate/regex/RegExAnnotationFacetFactoryTest.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/validate/regex/RegExAnnotationFacetFactoryTest.java
(original)
+++ incubator/isis/trunk/core/progmodel/src/test/java/org/apache/isis/core/progmodel/facets/propparam/validate/regex/RegExAnnotationFacetFactoryTest.java
Sun May 15 07:42:08 2011
@@ -57,7 +57,6 @@ public class RegExAnnotationFacetFactory
     public void testRegExAnnotationPickedUpOnProperty() {
         RegExFacetAnnotationForPropertyFacetFactory facetFactory = new RegExFacetAnnotationForPropertyFacetFactory();
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @RegEx(validation = "^A.*", caseSensitive = false)
@@ -80,7 +79,6 @@ public class RegExAnnotationFacetFactory
     public void testRegExAnnotationPickedUpOnActionParameter() {
         RegExFacetAnnotationForParameterFacetFactory facetFactory = new RegExFacetAnnotationForParameterFacetFactory();
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public void someAction(@RegEx(validation = "^A.*", caseSensitive = false) final
String foo) {}
@@ -100,7 +98,6 @@ public class RegExAnnotationFacetFactory
     public void testRegExAnnotationIgnoredForNonStringsProperty() {
         RegExFacetAnnotationForParameterFacetFactory facetFactory = new RegExFacetAnnotationForParameterFacetFactory();
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             @RegEx(validation = "^A.*", caseSensitive = false)
@@ -118,7 +115,6 @@ public class RegExAnnotationFacetFactory
     public void testRegExAnnotationIgnoredForPrimitiveOnActionParameter() {
         RegExFacetAnnotationForParameterFacetFactory facetFactory = new RegExFacetAnnotationForParameterFacetFactory();
 
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
         class Customer {
             @SuppressWarnings("unused")
             public void someAction(@RegEx(validation = "^A.*", caseSensitive = false) final
int foo) {}

Modified: incubator/isis/trunk/pom.xml
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/pom.xml?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/pom.xml (original)
+++ incubator/isis/trunk/pom.xml Sun May 15 07:42:08 2011
@@ -384,18 +384,6 @@
                         section -->
                 </plugin>
 
-                <!-- Quality checks: findbugs -->
-                <plugin>
-                    <groupId>org.codehaus.mojo</groupId>
-                    <artifactId>findbugs-maven-plugin</artifactId>
-                    <version>2.3.1</version>
-                    <inherited>true</inherited>
-                    <!-- goal:check binds to phase:verify (not currently 
-                        configured, can be used to break build if any violations) -->
-                    <!-- goal:findbugs is a report so is configured in the 
-                        reporting section -->
-                </plugin>
-
                 <!-- Quality checks: NCSS (cyclomatic complexity) -->
                 <plugin>
                     <groupId>org.codehaus.mojo</groupId>
@@ -940,13 +928,6 @@
                 <version>2.0</version>
             </dependency>
 
-            <!-- FindBugs annotations (code static analysis support) -->
-            <dependency>
-                <groupId>com.google.code.findbugs</groupId>
-                <artifactId>annotations</artifactId>
-                <version>1.3.9</version>
-            </dependency>
-
             <!-- Bytecode libraries -->
             <dependency>
                 <groupId>asm</groupId>
@@ -1081,10 +1062,6 @@
             <groupId>org.hamcrest</groupId>
             <artifactId>hamcrest-library</artifactId>
         </dependency>
-        <dependency>
-            <groupId>com.google.code.findbugs</groupId>
-            <artifactId>annotations</artifactId>
-        </dependency>
 
         <!-- test dependencies -->
         <dependency>
@@ -1226,12 +1203,6 @@
 
                     <plugin>
                         <groupId>org.codehaus.mojo</groupId>
-                        <artifactId>findbugs-maven-plugin</artifactId>
-                        <version>2.3.1</version>
-                    </plugin>
-
-                    <plugin>
-                        <groupId>org.codehaus.mojo</groupId>
                         <artifactId>javancss-maven-plugin</artifactId>
                         <version>2.0</version>
                     </plugin>

Modified: incubator/isis/trunk/runtimes/dflt/monitoring/src/main/java/org/apache/isis/runtimes/dflt/monitoring/servermonitor/SocketServerMonitor.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/monitoring/src/main/java/org/apache/isis/runtimes/dflt/monitoring/servermonitor/SocketServerMonitor.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/monitoring/src/main/java/org/apache/isis/runtimes/dflt/monitoring/servermonitor/SocketServerMonitor.java
(original)
+++ incubator/isis/trunk/runtimes/dflt/monitoring/src/main/java/org/apache/isis/runtimes/dflt/monitoring/servermonitor/SocketServerMonitor.java
Sun May 15 07:42:08 2011
@@ -27,7 +27,6 @@ import org.apache.isis.core.commons.conf
 import org.apache.isis.runtimes.dflt.runtime.system.IsisSystem;
 import org.apache.isis.runtimes.dflt.runtime.system.context.IsisContext;
 
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
 
 public class SocketServerMonitor extends AbstractServerMonitor {
     private static final int DEFAULT_PORT = 8009;

Modified: incubator/isis/trunk/runtimes/dflt/monitoring/src/main/java/org/apache/isis/runtimes/dflt/monitoring/systemconsole/AWTConsole.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/monitoring/src/main/java/org/apache/isis/runtimes/dflt/monitoring/systemconsole/AWTConsole.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/monitoring/src/main/java/org/apache/isis/runtimes/dflt/monitoring/systemconsole/AWTConsole.java
(original)
+++ incubator/isis/trunk/runtimes/dflt/monitoring/src/main/java/org/apache/isis/runtimes/dflt/monitoring/systemconsole/AWTConsole.java
Sun May 15 07:42:08 2011
@@ -34,8 +34,6 @@ import java.awt.event.ActionListener;
 import org.apache.isis.runtimes.dflt.runtime.system.context.IsisContext;
 import org.apache.log4j.Logger;
 
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
-
 public class AWTConsole extends Frame implements ServerConsole {
     private static final long serialVersionUID = 1L;
     private final static Logger LOG = Logger.getLogger(AWTConsole.class);
@@ -196,7 +194,6 @@ public class AWTConsole extends Frame im
         exitSystem();
     }
 
-    @SuppressWarnings(value = "DM_EXIT")
     private void exitSystem() {
         System.exit(0);
     }

Modified: incubator/isis/trunk/runtimes/dflt/monitoring/src/main/java/org/apache/isis/runtimes/dflt/monitoring/systemconsole/TerminalConsole.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/monitoring/src/main/java/org/apache/isis/runtimes/dflt/monitoring/systemconsole/TerminalConsole.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/monitoring/src/main/java/org/apache/isis/runtimes/dflt/monitoring/systemconsole/TerminalConsole.java
(original)
+++ incubator/isis/trunk/runtimes/dflt/monitoring/src/main/java/org/apache/isis/runtimes/dflt/monitoring/systemconsole/TerminalConsole.java
Sun May 15 07:42:08 2011
@@ -25,8 +25,6 @@ import java.io.InputStreamReader;
 
 import org.apache.log4j.Logger;
 
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
-
 /**
  * Marked as final because starts a thread in the {@link #TerminalConsole() constructor}.
  */
@@ -117,7 +115,6 @@ public final class TerminalConsole imple
         exitSystem();
     }
 
-    @SuppressWarnings(value = "DM_EXIT")
     private void exitSystem() {
         System.exit(0);
     }

Modified: incubator/isis/trunk/runtimes/dflt/objectstores/dflt/src/test/java/org/apache/isis/runtimes/dflt/objectstores/dflt/fixture/ObjectFixtureServiceTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/objectstores/dflt/src/test/java/org/apache/isis/runtimes/dflt/objectstores/dflt/fixture/ObjectFixtureServiceTest.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/objectstores/dflt/src/test/java/org/apache/isis/runtimes/dflt/objectstores/dflt/fixture/ObjectFixtureServiceTest.java
(original)
+++ incubator/isis/trunk/runtimes/dflt/objectstores/dflt/src/test/java/org/apache/isis/runtimes/dflt/objectstores/dflt/fixture/ObjectFixtureServiceTest.java
Sun May 15 07:42:08 2011
@@ -40,8 +40,6 @@ import org.apache.log4j.Logger;
 import org.junit.Before;
 import org.junit.Test;
 
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
-
 /**
  * TODO: remove dependency on {@link TestProxySystemII} and move back to runtime.
  */

Modified: incubator/isis/trunk/runtimes/dflt/remoting/marshalling-serialize/src/main/java/org/apache/isis/runtimes/dflt/remoting/marshalling/serialize/SerializingMarshaller.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/remoting/marshalling-serialize/src/main/java/org/apache/isis/runtimes/dflt/remoting/marshalling/serialize/SerializingMarshaller.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/remoting/marshalling-serialize/src/main/java/org/apache/isis/runtimes/dflt/remoting/marshalling/serialize/SerializingMarshaller.java
(original)
+++ incubator/isis/trunk/runtimes/dflt/remoting/marshalling-serialize/src/main/java/org/apache/isis/runtimes/dflt/remoting/marshalling/serialize/SerializingMarshaller.java
Sun May 15 07:42:08 2011
@@ -34,7 +34,6 @@ import org.apache.isis.runtimes.dflt.rem
 import org.apache.isis.runtimes.dflt.remoting.transport.Transport;
 import org.apache.log4j.Logger;
 
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
 
 public class SerializingMarshaller extends MarshallerAbstract {
 
@@ -92,7 +91,6 @@ public class SerializingMarshaller exten
         }
     }
 
-    @SuppressWarnings("BC_UNCONFIRMED_CAST")
     private Serializable asSerializable(final Request request) {
         return (Serializable) request;
     }

Modified: incubator/isis/trunk/runtimes/dflt/runtime/src/main/java/org/apache/isis/runtimes/dflt/runtime/RuntimeBootstrapper.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/runtime/src/main/java/org/apache/isis/runtimes/dflt/runtime/RuntimeBootstrapper.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/runtime/src/main/java/org/apache/isis/runtimes/dflt/runtime/RuntimeBootstrapper.java
(original)
+++ incubator/isis/trunk/runtimes/dflt/runtime/src/main/java/org/apache/isis/runtimes/dflt/runtime/RuntimeBootstrapper.java
Sun May 15 07:42:08 2011
@@ -50,7 +50,6 @@ final class RuntimeBootstrapper implemen
 
         // sufficient just to look it up
         @SuppressWarnings("unused")
-        @edu.umd.cs.findbugs.annotations.SuppressWarnings("DLS_DEAD_LOCAL_STORE")
         final IsisSystem system = injector.getInstance(IsisSystem.class);
     }
 

Modified: incubator/isis/trunk/runtimes/dflt/runtime/src/main/java/org/apache/isis/runtimes/dflt/runtime/fixturedomainservice/ObjectFixtureService.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/runtime/src/main/java/org/apache/isis/runtimes/dflt/runtime/fixturedomainservice/ObjectFixtureService.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/runtime/src/main/java/org/apache/isis/runtimes/dflt/runtime/fixturedomainservice/ObjectFixtureService.java
(original)
+++ incubator/isis/trunk/runtimes/dflt/runtime/src/main/java/org/apache/isis/runtimes/dflt/runtime/fixturedomainservice/ObjectFixtureService.java
Sun May 15 07:42:08 2011
@@ -212,14 +212,12 @@ public class ObjectFixtureService {
         return file;
     }
 
-    @edu.umd.cs.findbugs.annotations.SuppressWarnings("RV_RETURN_VALUE_IGNORED_BAD_PRACTICE")
     private void mkdirIfRequired(final File directory) {
         if (directory != null && !directory.exists()) {
             directory.mkdirs();
         }
     }
 
-    @edu.umd.cs.findbugs.annotations.SuppressWarnings(value = "RV_RETURN_VALUE_IGNORED_BAD_PRACTICE")
     private void createFile(final File file) throws IOException {
         file.createNewFile();
     }

Modified: incubator/isis/trunk/runtimes/dflt/runtime/src/main/java/org/apache/isis/runtimes/dflt/runtime/viewer/IsisViewerAbstract.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/runtime/src/main/java/org/apache/isis/runtimes/dflt/runtime/viewer/IsisViewerAbstract.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/runtime/src/main/java/org/apache/isis/runtimes/dflt/runtime/viewer/IsisViewerAbstract.java
(original)
+++ incubator/isis/trunk/runtimes/dflt/runtime/src/main/java/org/apache/isis/runtimes/dflt/runtime/viewer/IsisViewerAbstract.java
Sun May 15 07:42:08 2011
@@ -109,7 +109,7 @@ public abstract class IsisViewerAbstract
     // ////////////////////////////////////////////////////////////////
 
     public LogonFixture getLogonFixture() {
-        // REVIEW: findBugs says this will always return null, since 'system' never written
to...
+        // REVIEW: always return null? (since 'system' never written to...)
         return system != null ? system.getLogonFixture() : null;
     }
 

Modified: incubator/isis/trunk/runtimes/dflt/runtime/src/test/java/org/apache/isis/runtimes/dflt/runtime/memento/TestPojoSimple.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/runtime/src/test/java/org/apache/isis/runtimes/dflt/runtime/memento/TestPojoSimple.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/runtime/src/test/java/org/apache/isis/runtimes/dflt/runtime/memento/TestPojoSimple.java
(original)
+++ incubator/isis/trunk/runtimes/dflt/runtime/src/test/java/org/apache/isis/runtimes/dflt/runtime/memento/TestPojoSimple.java
Sun May 15 07:42:08 2011
@@ -21,8 +21,6 @@ package org.apache.isis.runtimes.dflt.ru
 
 import org.apache.isis.runtimes.dflt.runtime.testsystem.TestPojo;
 
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
-
 public class TestPojoSimple extends TestPojo {
     private String name;
     private TestPojoSimple object;
@@ -38,7 +36,6 @@ public class TestPojoSimple extends Test
         return name;
     }
 
-    @SuppressWarnings("UWF_UNWRITTEN_FIELD")
     public TestPojoSimple getObject() {
         return object;
     }

Modified: incubator/isis/trunk/runtimes/dflt/runtime/src/test/java/org/apache/isis/runtimes/dflt/runtime/system/TypeExtractorMethodReturnTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/runtime/src/test/java/org/apache/isis/runtimes/dflt/runtime/system/TypeExtractorMethodReturnTest.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/runtime/src/test/java/org/apache/isis/runtimes/dflt/runtime/system/TypeExtractorMethodReturnTest.java
(original)
+++ incubator/isis/trunk/runtimes/dflt/runtime/src/test/java/org/apache/isis/runtimes/dflt/runtime/system/TypeExtractorMethodReturnTest.java
Sun May 15 07:42:08 2011
@@ -39,7 +39,6 @@ public class TypeExtractorMethodReturnTe
         }
         class CustomerRepository {
             @SuppressWarnings("unused")
-            @edu.umd.cs.findbugs.annotations.SuppressWarnings(value = "UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
             public List<Customer> findCustomers() {
                 return null;
             }
@@ -60,7 +59,6 @@ public class TypeExtractorMethodReturnTe
 
         class CustomerRepository {
             @SuppressWarnings("unused")
-            @edu.umd.cs.findbugs.annotations.SuppressWarnings(value = "UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
             public void findCustomers() {
             }
         }

Modified: incubator/isis/trunk/runtimes/dflt/runtime/src/test/java/org/apache/isis/runtimes/dflt/runtime/system/TypeExtractorMethodsParametersTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/runtime/src/test/java/org/apache/isis/runtimes/dflt/runtime/system/TypeExtractorMethodsParametersTest.java?rev=1103287&r1=1103286&r2=1103287&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/runtime/src/test/java/org/apache/isis/runtimes/dflt/runtime/system/TypeExtractorMethodsParametersTest.java
(original)
+++ incubator/isis/trunk/runtimes/dflt/runtime/src/test/java/org/apache/isis/runtimes/dflt/runtime/system/TypeExtractorMethodsParametersTest.java
Sun May 15 07:42:08 2011
@@ -39,7 +39,6 @@ public class TypeExtractorMethodsParamet
         }
         class CustomerRepository {
             @SuppressWarnings("unused")
-            @edu.umd.cs.findbugs.annotations.SuppressWarnings(value = "UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS")
             public void filterCustomers(final List<Customer> customerList) {
                 ;
             }



Mime
View raw message