incubator-isis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danhayw...@apache.org
Subject svn commit: r1098939 [1/11] - in /incubator/isis/trunk/runtimes/dflt: profilestores/dflt/src/main/java/org/apache/isis/runtimes/dflt/profilestores/dflt/ profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/ profilestores/xml/...
Date Tue, 03 May 2011 06:33:49 GMT
Author: danhaywood
Date: Tue May  3 06:33:43 2011
New Revision: 1098939

URL: http://svn.apache.org/viewvc?rev=1098939&view=rev
Log:
ISIS-30 + ISIS-20 (implicitly): code clean-up of runtimes.dflt:profilestores, remoting

Modified:
    incubator/isis/trunk/runtimes/dflt/profilestores/dflt/src/main/java/org/apache/isis/runtimes/dflt/profilestores/dflt/InMemoryUserProfileStore.java
    incubator/isis/trunk/runtimes/dflt/profilestores/dflt/src/main/java/org/apache/isis/runtimes/dflt/profilestores/dflt/InMemoryUserProfileStoreInstaller.java
    incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/XmlUserProfileStore.java
    incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/XmlUserProfileStoreInstaller.java
    incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileContentWriter.java
    incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileDataHandler.java
    incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/TestServiceObject1.java
    incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileContentWriterTest.java
    incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileDataHandlerTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/IsisRemoteException.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ClientConnection.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ClientConnectionDefault.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ProxyInstallerAbstract.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authentication/AuthenticationManagerProxy.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authentication/ProxyAuthenticator.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authorization/AuthorizationManagerProxy.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/facetdecorator/ProxyFacetDecorator.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/facets/ActionInvocationFacetWrapProxy.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/facets/CollectionAddToFacetWrapProxy.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/facets/CollectionRemoveFromFacetWrapProxy.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/facets/PropertyClearFacetWrapProxy.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/facets/PropertySetterFacetWrapProxy.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/facets/ProxyUtil.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/persistence/ClientSideTransactionManager.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/persistence/PersistenceSessionProxy.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/persistence/ProxyPersistenceSessionFactory.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/transaction/ClientSideTransaction.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/transaction/ClientTransactionEvent.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/Data.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/DataFactory.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/DataFactoryDefault.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/common/CollectionData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/common/CollectionDataImpl.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/common/EncodableObjectData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/common/EncodableObjectDataImpl.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/common/IdentityData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/common/IdentityDataImpl.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/common/NullData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/common/NullDataImpl.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/common/ObjectData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/common/ObjectDataImpl.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/common/ReferenceData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/query/PersistenceQueryData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/query/PersistenceQueryDataAbstract.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/query/PersistenceQueryFindAllInstancesData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/query/PersistenceQueryFindByPatternData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/query/PersistenceQueryFindByTitleData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/query/PersistenceQueryFindUsingApplibQueryDefaultData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/data/query/PersistenceQueryFindUsingApplibQuerySerializableData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/AuthorizationRequestAbstract.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/AuthorizationRequestUsability.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/AuthorizationRequestVisibility.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/AuthorizationResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ClearAssociationRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ClearAssociationResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ClearValueRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ClearValueResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/CloseSessionRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/CloseSessionResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ExecuteClientActionRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ExecuteClientActionResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ExecuteServerActionRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ExecuteServerActionResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/FindInstancesRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/FindInstancesResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/GetObjectRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/GetObjectResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/GetPropertiesRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/GetPropertiesResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/HasInstancesRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/HasInstancesResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/KnownObjectsRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/OidForServiceRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/OidForServiceResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/OpenSessionRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/OpenSessionResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/Request.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/RequestAbstract.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ResolveFieldRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ResolveFieldResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ResolveObjectRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ResolveObjectResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ResponseEnvelope.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/SetAssociationRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/SetAssociationResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/SetValueRequest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/SetValueResponse.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/facade/ServerFacade.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/facade/ServerFacadeLogger.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/facade/impl/ServerFacadeImpl.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/facade/proxy/ServerFacadeProxy.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/marshalling/ClientMarshaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/marshalling/Marshaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/marshalling/MarshallerAbstract.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/marshalling/MarshallingConstants.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/marshalling/ServerMarshaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/protocol/IllegalRequestException.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/protocol/ObjectEncoderDecoder.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/protocol/PersistenceQueryEncoder.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/protocol/ProtocolConstants.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/protocol/ProtocolInstaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/protocol/internal/FieldOrderCache.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/protocol/internal/ObjectDeserializer.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/protocol/internal/ObjectEncoderDecoderDefault.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/protocol/internal/ObjectSerializer.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/protocol/internal/PersistenceQueryEncoderAbstract.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/protocol/internal/PersistenceQueryFindAllInstancesEncoder.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/protocol/internal/PersistenceQueryFindByPatternEncoder.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/protocol/internal/PersistenceQueryFindByTitleEncoder.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/protocol/internal/PersistenceQueryFindUsingApplibQueryDefaultEncoder.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/protocol/internal/PersistenceQueryFindUsingApplibQuerySerializableEncoder.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/server/ServerConnection.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/server/ServerConnectionDefault.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/ConnectionException.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/ProfilingInputStream.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/ServerConnectionHandler.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/TailingInputStream.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/Transport.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/TransportAbstract.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/TransportConstants.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/TransportInstaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/pipe/PipedClient.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/pipe/PipedConnection.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/pipe/PipedServer.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/simple/SimpleTransport.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/client/CommandClientTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/client/ProxyPersistorTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/client/facets/ProxyAction_ExecuteLocallyTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/client/facets/ProxyAction_ExecuteRemotelyTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/data/DummyCollectionData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/data/DummyEncodeableObjectData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/data/DummyIdentityData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/data/DummyNullValue.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/data/DummyObjectData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/data/DummyReferenceData.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/AuthenticationRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/AuthorizationRequestUsabilityEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/AuthorizationRequestVisibilityEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ClearAssociationRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ClearValueRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/CloseSessionRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ExecuteClientActionRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ExecuteServerActionEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/FindInstancesRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/GetObjectRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/GetPropertiesRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/HasInstancesRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/OidForServiceRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ResolveFieldRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/ResolveObjectRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/SetAssociationRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/exchange/SetValueRequestEncodabilityTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/facade/DummyServerFacade.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/protocol/encoding/ObjectDecoderCollectionTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/protocol/encoding/ObjectEncoderImplTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/server/ServerFacadeImpl_AssociationTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/server/ServerFacadeImpl_ClientActionTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/server/ServerFacadeImpl_ParseableAssociationsTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/common/src/test/java/org/apache/isis/runtimes/dflt/remoting/common/server/ServerFacadeImpl_RemoteActionTest.java
    incubator/isis/trunk/runtimes/dflt/remoting/marshalling-encode/src/main/java/org/apache/isis/runtimes/dflt/remoting/marshalling/encode/EncodingMarshaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/marshalling-serialize/src/main/java/org/apache/isis/runtimes/dflt/remoting/marshalling/serialize/SerializingMarshaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/marshalling-xstream/src/main/java/org/apache/isis/runtimes/dflt/remoting/marshalling/xstream/client/XStreamOverSocketsProxyDecoratorInstaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/marshalling-xstream/src/main/java/org/apache/isis/runtimes/dflt/remoting/marshalling/xstream/server/XStreamOverSocketsViewer.java
    incubator/isis/trunk/runtimes/dflt/remoting/marshalling-xstream/src/main/java/org/apache/isis/runtimes/dflt/remoting/marshalling/xstream/server/XStreamOverSocketsViewerInstaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/marshalling-xstream/src/main/java/org/apache/isis/runtimes/dflt/remoting/marshalling/xstream/shared/XStreamMarshaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-http/client/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/http/client/EncodingOverHttpProxyInstaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-http/client/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/http/client/HttpClientTransport.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-http/client/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/http/client/HttpRemotingConstants.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-http/server/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/http/server/EncodingOverHttpRemotingServlet.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-http/server/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/http/server/EncodingOverHttpRemotingViewerInstaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-sockets/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/sockets/client/EncodingOverSocketsProxyInstaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-sockets/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/sockets/client/SerializingOverSocketsProxyInstaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-sockets/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/sockets/server/EncodingOverSocketsViewer.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-sockets/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/sockets/server/EncodingOverSocketsViewerInstaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-sockets/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/sockets/server/SerializingOverSocketsViewer.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-sockets/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/sockets/server/SerializingOverSocketsViewerInstaller.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-sockets/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/sockets/server/SocketsViewerAbstract.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-sockets/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/sockets/server/SocketsViewerConstants.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-sockets/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/sockets/server/SocketsViewerInstallerAbstract.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-sockets/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/sockets/shared/SocketTransport.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-sockets/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/sockets/shared/SocketTransportConstants.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-sockets/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/sockets/shared/Worker.java
    incubator/isis/trunk/runtimes/dflt/remoting/transport-sockets/src/main/java/org/apache/isis/runtimes/dflt/remoting/transport/sockets/shared/WorkerPool.java

Modified: incubator/isis/trunk/runtimes/dflt/profilestores/dflt/src/main/java/org/apache/isis/runtimes/dflt/profilestores/dflt/InMemoryUserProfileStore.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/profilestores/dflt/src/main/java/org/apache/isis/runtimes/dflt/profilestores/dflt/InMemoryUserProfileStore.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/profilestores/dflt/src/main/java/org/apache/isis/runtimes/dflt/profilestores/dflt/InMemoryUserProfileStore.java (original)
+++ incubator/isis/trunk/runtimes/dflt/profilestores/dflt/src/main/java/org/apache/isis/runtimes/dflt/profilestores/dflt/InMemoryUserProfileStore.java Tue May  3 06:33:43 2011
@@ -17,7 +17,6 @@
  *  under the License.
  */
 
-
 package org.apache.isis.runtimes.dflt.profilestores.dflt;
 
 import java.util.HashMap;
@@ -25,36 +24,38 @@ import java.util.Map;
 
 import org.apache.isis.core.commons.debug.DebugBuilder;
 import org.apache.isis.core.commons.debug.DebuggableWithTitle;
-import org.apache.isis.core.commons.debug.DebugString;
 import org.apache.isis.core.runtime.userprofile.UserProfile;
 import org.apache.isis.core.runtime.userprofile.UserProfileStore;
 
 public class InMemoryUserProfileStore implements UserProfileStore, DebuggableWithTitle {
-	
+
     private static final Map<String, UserProfile> profiles = new HashMap<String, UserProfile>();
-    
+
+    @Override
     public boolean isFixturesInstalled() {
-    	return false;
+        return false;
     }
-    
-    public UserProfile getUserProfile(String name) {
+
+    @Override
+    public UserProfile getUserProfile(final String name) {
         return profiles.get(name);
     }
 
-    public void save(String name, UserProfile userProfile) {
+    @Override
+    public void save(final String name, final UserProfile userProfile) {
         profiles.put(name, userProfile);
     }
 
-    public void debugData(DebugBuilder debug) {
-        for (String name : profiles.keySet()) {
+    @Override
+    public void debugData(final DebugBuilder debug) {
+        for (final String name : profiles.keySet()) {
             debug.appendln(name, profiles.get(name));
         }
     }
 
+    @Override
     public String debugTitle() {
         return "InMemoryUserProfileStore";
     }
 
 }
-
-

Modified: incubator/isis/trunk/runtimes/dflt/profilestores/dflt/src/main/java/org/apache/isis/runtimes/dflt/profilestores/dflt/InMemoryUserProfileStoreInstaller.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/profilestores/dflt/src/main/java/org/apache/isis/runtimes/dflt/profilestores/dflt/InMemoryUserProfileStoreInstaller.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/profilestores/dflt/src/main/java/org/apache/isis/runtimes/dflt/profilestores/dflt/InMemoryUserProfileStoreInstaller.java (original)
+++ incubator/isis/trunk/runtimes/dflt/profilestores/dflt/src/main/java/org/apache/isis/runtimes/dflt/profilestores/dflt/InMemoryUserProfileStoreInstaller.java Tue May  3 06:33:43 2011
@@ -17,31 +17,28 @@
  *  under the License.
  */
 
+package org.apache.isis.runtimes.dflt.profilestores.dflt;
+
+import java.util.List;
 
-package org.apache.isis.runtimes.dflt.profilestores.dflt;
-
-import java.util.List;
-
 import org.apache.isis.core.commons.config.InstallerAbstract;
 import org.apache.isis.core.commons.config.IsisConfiguration;
 import org.apache.isis.core.runtime.userprofile.UserProfileStore;
 import org.apache.isis.runtimes.dflt.runtime.userprofile.UserProfileStoreInstaller;
-
-public class InMemoryUserProfileStoreInstaller extends InstallerAbstract implements
-		UserProfileStoreInstaller {
-
-	public InMemoryUserProfileStoreInstaller() {
-		super(UserProfileStoreInstaller.TYPE, "in-memory");
-	}
-	
-	public UserProfileStore createUserProfileStore(
-			IsisConfiguration objectConfiguration) {
-		return new InMemoryUserProfileStore();
-	}
-
-
-	@Override
-	public List<Class<?>> getTypes() {
-		return listOf(UserProfileStore.class);
-	}
-}
+
+public class InMemoryUserProfileStoreInstaller extends InstallerAbstract implements UserProfileStoreInstaller {
+
+    public InMemoryUserProfileStoreInstaller() {
+        super(UserProfileStoreInstaller.TYPE, "in-memory");
+    }
+
+    @Override
+    public UserProfileStore createUserProfileStore(final IsisConfiguration objectConfiguration) {
+        return new InMemoryUserProfileStore();
+    }
+
+    @Override
+    public List<Class<?>> getTypes() {
+        return listOf(UserProfileStore.class);
+    }
+}

Modified: incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/XmlUserProfileStore.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/XmlUserProfileStore.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/XmlUserProfileStore.java (original)
+++ incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/XmlUserProfileStore.java Tue May  3 06:33:43 2011
@@ -36,13 +36,13 @@ public class XmlUserProfileStore impleme
     private final XmlFile xmlFile;
 
     @Inject
-    public XmlUserProfileStore(IsisConfiguration configuration) {
-        String directory = configuration.getString(XML_DIR, "xml/profiles");
+    public XmlUserProfileStore(final IsisConfiguration configuration) {
+        final String directory = configuration.getString(XML_DIR, "xml/profiles");
         xmlFile = new XmlFile(XmlFileUtil.lookupCharset(configuration), directory);
     }
 
     @Override
-    public UserProfile getUserProfile(String userName) {
+    public UserProfile getUserProfile(final String userName) {
         final UserProfileDataHandler handler = new UserProfileDataHandler();
         if (xmlFile.parse(handler, userName)) {
             return handler.getUserProfile();

Modified: incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/XmlUserProfileStoreInstaller.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/XmlUserProfileStoreInstaller.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/XmlUserProfileStoreInstaller.java (original)
+++ incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/XmlUserProfileStoreInstaller.java Tue May  3 06:33:43 2011
@@ -17,7 +17,6 @@
  *  under the License.
  */
 
-
 package org.apache.isis.runtimes.dflt.profilestores.xml;
 
 import java.util.List;
@@ -27,24 +26,20 @@ import org.apache.isis.core.commons.conf
 import org.apache.isis.core.runtime.userprofile.UserProfileStore;
 import org.apache.isis.runtimes.dflt.runtime.userprofile.UserProfileStoreInstaller;
 
-import com.google.inject.AbstractModule;
-import com.google.inject.Module;
-
 public class XmlUserProfileStoreInstaller extends InstallerAbstract implements UserProfileStoreInstaller {
 
     public XmlUserProfileStoreInstaller() {
-		super(UserProfileStoreInstaller.TYPE, "xml");
-	}
-
-	public UserProfileStore createUserProfileStore(IsisConfiguration configuration) {
-		return new XmlUserProfileStore(configuration);
-	}
+        super(UserProfileStoreInstaller.TYPE, "xml");
+    }
 
+    @Override
+    public UserProfileStore createUserProfileStore(final IsisConfiguration configuration) {
+        return new XmlUserProfileStore(configuration);
+    }
 
+    @Override
     public List<Class<?>> getTypes() {
-    	return listOf(UserProfileStore.class);
+        return listOf(UserProfileStore.class);
     }
 
 }
-
-

Modified: incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileContentWriter.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileContentWriter.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileContentWriter.java (original)
+++ incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileContentWriter.java Tue May  3 06:33:43 2011
@@ -26,7 +26,6 @@ import java.io.Writer;
 import java.util.Iterator;
 
 import org.apache.commons.lang.StringUtils;
-
 import org.apache.isis.core.commons.encoding.DataOutputStreamExtended;
 import org.apache.isis.core.commons.xml.ContentWriter;
 import org.apache.isis.core.metamodel.adapter.ObjectAdapter;
@@ -40,32 +39,33 @@ import org.apache.isis.runtimes.dflt.run
 public class UserProfileContentWriter implements ContentWriter {
     private final UserProfile userProfile;
 
-    public UserProfileContentWriter(UserProfile userProfile) {
+    public UserProfileContentWriter(final UserProfile userProfile) {
         this.userProfile = userProfile;
     }
 
-    public void write(Writer writer) throws IOException {
+    @Override
+    public void write(final Writer writer) throws IOException {
         final StringBuffer xml = new StringBuffer();
         xml.append("<profile>\n");
 
-        Options options = userProfile.getOptions();
+        final Options options = userProfile.getOptions();
         writeOptions(xml, options, null, 0);
 
         xml.append("  <perspectives>\n");
-        for (String perspectiveName : userProfile.list()) {
-            PerspectiveEntry perspective = userProfile.getPerspective(perspectiveName);
+        for (final String perspectiveName : userProfile.list()) {
+            final PerspectiveEntry perspective = userProfile.getPerspective(perspectiveName);
 
             xml.append("    <perspective" + attribute("name", perspectiveName) + ">\n");
             xml.append("      <services>\n");
-            for (Object service : perspective.getServices()) {
+            for (final Object service : perspective.getServices()) {
                 xml.append("        <service " + attribute("id", ServiceUtil.id(service)) + "/>\n");
             }
             xml.append("      </services>\n");
             xml.append("      <objects>\n");
-            for (Object object : perspective.getObjects()) {
-                ObjectAdapter adapter = getPersistenceSession().getAdapterManager().adapterFor(object);
-                OutputStream out = new ByteArrayOutputStream();
-                DataOutputStreamExtended outputImpl = new DataOutputStreamExtended(out);
+            for (final Object object : perspective.getObjects()) {
+                final ObjectAdapter adapter = getPersistenceSession().getAdapterManager().adapterFor(object);
+                final OutputStream out = new ByteArrayOutputStream();
+                final DataOutputStreamExtended outputImpl = new DataOutputStreamExtended(out);
                 adapter.getOid().encode(outputImpl);
                 // FIX need to sort out encoding
                 // xml.append("      <object>" + out.toString() + "</object>\n");
@@ -81,10 +81,10 @@ public class UserProfileContentWriter im
         writer.write(xml.toString());
     }
 
-    private void writeOptions(final StringBuffer xml, Options options, String name1, int level) {
-        String spaces = StringUtils.repeat("  ", level);
+    private void writeOptions(final StringBuffer xml, final Options options, final String name1, final int level) {
+        final String spaces = StringUtils.repeat("  ", level);
 
-        Iterator<String> names = options.names();
+        final Iterator<String> names = options.names();
         if (level == 0 || names.hasNext()) {
             xml.append(spaces + "  <options");
             if (name1 != null) {
@@ -92,7 +92,7 @@ public class UserProfileContentWriter im
             }
             xml.append(">\n");
             while (names.hasNext()) {
-                String name = names.next();
+                final String name = names.next();
                 if (options.isOptions(name)) {
                     writeOptions(xml, options.getOptions(name), name, level + 1);
                 } else {

Modified: incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileDataHandler.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileDataHandler.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileDataHandler.java (original)
+++ incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/main/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileDataHandler.java Tue May  3 06:33:43 2011
@@ -17,7 +17,6 @@
  *  under the License.
  */
 
-
 package org.apache.isis.runtimes.dflt.profilestores.xml.internal;
 
 import java.util.List;
@@ -32,11 +31,10 @@ import org.xml.sax.Attributes;
 import org.xml.sax.SAXException;
 import org.xml.sax.helpers.DefaultHandler;
 
-
 public class UserProfileDataHandler extends DefaultHandler {
     private final StringBuffer data = new StringBuffer();
     private final UserProfile userProfile = new UserProfile();
-    private Stack<Options> options = new Stack<Options>();
+    private final Stack<Options> options = new Stack<Options>();
     private String optionName;
     private boolean isProfile;
     private boolean isOptions;
@@ -48,7 +46,7 @@ public class UserProfileDataHandler exte
     public UserProfile getUserProfile() {
         return userProfile;
     }
-    
+
     @Override
     public void characters(final char[] ch, final int start, final int end) throws SAXException {
         data.append(new String(ch, start, end));
@@ -63,7 +61,7 @@ public class UserProfileDataHandler exte
             isPerspectives = false;
         } else if (tagName.equals("perspective")) {
             // TODO add perspective to profile
-            
+
             perspective = null;
         } else if (tagName.equals("services")) {
             isServices = false;
@@ -80,7 +78,7 @@ public class UserProfileDataHandler exte
 
     @Override
     public void startElement(final String ns, final String name, final String tagName, final Attributes attributes)
-            throws SAXException {
+        throws SAXException {
 
         if (isProfile) {
             if (isOptions) {
@@ -88,8 +86,8 @@ public class UserProfileDataHandler exte
                     optionName = attributes.getValue("id");
                     data.setLength(0);
                 } else if (tagName.equals("options")) {
-                    String optionsName = attributes.getValue("id");
-                    Options newOptions = new Options();
+                    final String optionsName = attributes.getValue("id");
+                    final Options newOptions = new Options();
                     options.peek().addOptions(optionsName, newOptions);
                     options.push(newOptions);
                 } else {
@@ -98,10 +96,10 @@ public class UserProfileDataHandler exte
             } else if (isPerspectives) {
                 if (perspective != null) {
                     if (isServices) {
-                        if (tagName.equals("service")){
-                            String serviceId = attributes.getValue("id");
-                            List<Object> serviceObjects = IsisContext.getServices();
-                            for (Object service : serviceObjects) {
+                        if (tagName.equals("service")) {
+                            final String serviceId = attributes.getValue("id");
+                            final List<Object> serviceObjects = IsisContext.getServices();
+                            for (final Object service : serviceObjects) {
                                 if (ServiceUtil.id(service).equals(serviceId)) {
                                     perspective.addToServices(service);
                                     break;
@@ -111,7 +109,7 @@ public class UserProfileDataHandler exte
                             throw new SAXException("Invalid element in services: " + tagName);
                         }
                     } else if (isObjects) {
-                         // TODO reload objects
+                        // TODO reload objects
                     } else if (tagName.equals("services")) {
                         isServices = true;
                     } else if (tagName.equals("objects")) {
@@ -145,4 +143,3 @@ public class UserProfileDataHandler exte
     }
 
 }
-

Modified: incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/TestServiceObject1.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/TestServiceObject1.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/TestServiceObject1.java (original)
+++ incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/TestServiceObject1.java Tue May  3 06:33:43 2011
@@ -17,7 +17,6 @@
  *  under the License.
  */
 
-
 package org.apache.isis.runtimes.dflt.profilestores.xml.internal;
 
 public class TestServiceObject1 {
@@ -27,5 +26,3 @@ public class TestServiceObject1 {
         return ID;
     }
 }
-
-

Modified: incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileContentWriterTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileContentWriterTest.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileContentWriterTest.java (original)
+++ incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileContentWriterTest.java Tue May  3 06:33:43 2011
@@ -17,7 +17,6 @@
  *  under the License.
  */
 
-
 package org.apache.isis.runtimes.dflt.profilestores.xml.internal;
 
 import static org.junit.Assert.assertEquals;
@@ -28,73 +27,72 @@ import java.io.StringWriter;
 import org.apache.isis.core.runtime.userprofile.Options;
 import org.apache.isis.core.runtime.userprofile.PerspectiveEntry;
 import org.apache.isis.core.runtime.userprofile.UserProfile;
-import org.apache.isis.runtimes.dflt.profilestores.xml.internal.UserProfileContentWriter;
 import org.junit.Before;
 import org.junit.Test;
 
-
 public class UserProfileContentWriterTest {
 
     private UserProfileContentWriter writer1;
     private UserProfile profile;
     private StringWriter writer;
-    
+
     @Before
     public void setup() throws Exception {
         profile = new UserProfile();
         writer1 = new UserProfileContentWriter(profile);
         writer = new StringWriter();
-        
+
     }
 
     @Test
     public void emptyStructure() throws Exception {
         writeContent();
-        assertEquals("<profile>\n  <options>\n  </options>\n  <perspectives>\n  </perspectives>\n</profile>\n", writer.toString());        
+        assertEquals("<profile>\n  <options>\n  </options>\n  <perspectives>\n  </perspectives>\n</profile>\n",
+            writer.toString());
     }
 
     @Test
     public void singleOption() throws Exception {
         profile.addToOptions("option1", "value1");
         profile.addToOptions("option2", "value2");
-        assertLine("    <option id=\"option2\">value2</option>", 2);        
-        assertLine("    <option id=\"option1\">value1</option>", 3);        
+        assertLine("    <option id=\"option2\">value2</option>", 2);
+        assertLine("    <option id=\"option1\">value1</option>", 3);
     }
 
     @Test
     public void recursiveOptions() throws Exception {
-        Options options = new Options();
+        final Options options = new Options();
         options.addOption("option2", "value2");
         profile.getOptions().addOptions("option1", options);
-        assertLine("    <options id=\"option1\">", 2);        
-        assertLine("      <option id=\"option2\">value2</option>", 3);        
-        assertLine("    </options>", 4);        
+        assertLine("    <options id=\"option1\">", 2);
+        assertLine("      <option id=\"option2\">value2</option>", 3);
+        assertLine("    </options>", 4);
     }
 
     @Test
     public void emptyOptionsAreIgnored() throws Exception {
-        Options options = new Options();
+        final Options options = new Options();
         profile.getOptions().addOptions("option1", options);
         debug();
-        assertLine("  </options>", 2);        
+        assertLine("  </options>", 2);
     }
 
     @Test
     public void perspective() throws Exception {
-        PerspectiveEntry perspective = new PerspectiveEntry();
+        final PerspectiveEntry perspective = new PerspectiveEntry();
         perspective.setName("test");
         profile.addToPerspectives(perspective);
-//        debug();
+        // debug();
         writeContent();
-        assertEquals("<profile>\n  <options>\n  </options>\n  <perspectives>\n" +
-                "    <perspective name=\"test\">\n      <services>\n      </services>\n      <objects>\n      </objects>\n    </perspective>\n" + 
-        		"  </perspectives>\n</profile>\n", writer.toString());        
+        assertEquals(
+            "<profile>\n  <options>\n  </options>\n  <perspectives>\n"
+                + "    <perspective name=\"test\">\n      <services>\n      </services>\n      <objects>\n      </objects>\n    </perspective>\n"
+                + "  </perspectives>\n</profile>\n", writer.toString());
     }
 
-    
-    //// Helpers
-    
-    private void assertLine(String expected, int line) throws IOException {
+    // // Helpers
+
+    private void assertLine(final String expected, final int line) throws IOException {
         writeContent();
         assertEquals(expected, writer.toString().split("\n")[line]);
     }
@@ -103,9 +101,8 @@ public class UserProfileContentWriterTes
         writeContent();
         System.out.println(writer.toString());
     }
-    
+
     private void writeContent() throws IOException {
         writer1.write(writer);
     }
 }
-

Modified: incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileDataHandlerTest.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileDataHandlerTest.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileDataHandlerTest.java (original)
+++ incubator/isis/trunk/runtimes/dflt/profilestores/xml/src/test/java/org/apache/isis/runtimes/dflt/profilestores/xml/internal/UserProfileDataHandlerTest.java Tue May  3 06:33:43 2011
@@ -17,7 +17,6 @@
  *  under the License.
  */
 
-
 package org.apache.isis.runtimes.dflt.profilestores.xml.internal;
 
 import static org.junit.Assert.assertEquals;
@@ -36,7 +35,6 @@ import org.apache.isis.core.runtime.imag
 import org.apache.isis.core.runtime.userprofile.Options;
 import org.apache.isis.core.runtime.userprofile.UserProfile;
 import org.apache.isis.core.runtime.userprofile.UserProfileLoader;
-import org.apache.isis.runtimes.dflt.profilestores.xml.internal.UserProfileDataHandler;
 import org.apache.isis.runtimes.dflt.runtime.system.DeploymentType;
 import org.apache.isis.runtimes.dflt.runtime.system.context.IsisContextStatic;
 import org.apache.isis.runtimes.dflt.runtime.system.persistence.PersistenceSessionFactory;
@@ -52,7 +50,6 @@ import org.xml.sax.InputSource;
 import org.xml.sax.XMLReader;
 import org.xml.sax.helpers.XMLReaderFactory;
 
-
 public class UserProfileDataHandlerTest {
 
     private TestServiceObject1 service;
@@ -61,43 +58,36 @@ public class UserProfileDataHandlerTest 
     @Before
     public void setup() throws Exception {
         Logger.getRootLogger().setLevel(Level.OFF);
-        Mockery mockery = new JUnit4Mockery();
-        ArrayList<Object> servicesList = new ArrayList<Object>();
+        final Mockery mockery = new JUnit4Mockery();
+        final ArrayList<Object> servicesList = new ArrayList<Object>();
         service = new TestServiceObject1();
         servicesList.add(service);
-        IsisSessionFactory executionContextFactory = 
-            new IsisSessionFactoryDefault(
-                    DeploymentType.EXPLORATION, 
-                    new IsisConfigurationDefault(), 
-                    mockery.mock(TemplateImageLoader.class), 
-                    mockery.mock(SpecificationLoader.class), 
-                    mockery.mock(AuthenticationManager.class), 
-                    mockery.mock(AuthorizationManager.class),
-                    mockery.mock(UserProfileLoader.class), 
-                    mockery.mock(PersistenceSessionFactory.class), servicesList);
-          
+        final IsisSessionFactory executionContextFactory =
+            new IsisSessionFactoryDefault(DeploymentType.EXPLORATION, new IsisConfigurationDefault(),
+                mockery.mock(TemplateImageLoader.class), mockery.mock(SpecificationLoader.class),
+                mockery.mock(AuthenticationManager.class), mockery.mock(AuthorizationManager.class),
+                mockery.mock(UserProfileLoader.class), mockery.mock(PersistenceSessionFactory.class), servicesList);
+
         IsisContextStatic.createRelaxedInstance(executionContextFactory);
- 
-        
-        
-        XMLReader parser = XMLReaderFactory.createXMLReader();
-        UserProfileDataHandler handler = new UserProfileDataHandler();
+
+        final XMLReader parser = XMLReaderFactory.createXMLReader();
+        final UserProfileDataHandler handler = new UserProfileDataHandler();
         parser.setContentHandler(handler);
         parser.parse(new InputSource(new InputStreamReader(new FileInputStream("test.xml"))));
 
         profile = handler.getUserProfile();
     }
-    
+
     @Test
     public void stringOption() throws Exception {
         assertEquals("on", profile.getOptions().getString("power"));
     }
-    
+
     @Test
     public void unknownOptionReturnsNull() throws Exception {
         assertEquals(null, profile.getOptions().getString("device"));
     }
-    
+
     @Test
     public void integerOption() throws Exception {
         assertEquals(50, profile.getOptions().getInteger("height", 10));
@@ -110,14 +100,14 @@ public class UserProfileDataHandlerTest 
 
     @Test
     public void unknownOptionsCreated() throws Exception {
-        Options options = profile.getOptions().getOptions("");
+        final Options options = profile.getOptions().getOptions("");
         assertNotNull(options);
         assertEquals(false, options.names().hasNext());
     }
 
     @Test
     public void containedOptions() throws Exception {
-        Options options = profile.getOptions().getOptions("opts");
+        final Options options = profile.getOptions().getOptions("opts");
         assertNotNull(options);
         assertEquals("value1", options.getString("option1"));
         assertEquals("value2", options.getString("option2"));
@@ -130,15 +120,15 @@ public class UserProfileDataHandlerTest 
         assertEquals("value4", options.getString("option4"));
         assertEquals("value5", options.getString("option5"));
     }
-    
+
     @Test
     public void profileNames() throws Exception {
-        List<String> list = profile.list();
+        final List<String> list = profile.list();
         assertEquals(2, list.size());
         assertEquals("Library", list.get(0));
         assertEquals("Admin", list.get(1));
     }
-    
+
     @Test
     public void perspective() throws Exception {
         assertEquals("Admin", profile.getPerspective().getName());
@@ -146,5 +136,3 @@ public class UserProfileDataHandlerTest 
         assertEquals(service, profile.getPerspective().getServices().get(0));
     }
 }
-
-

Modified: incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/IsisRemoteException.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/IsisRemoteException.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/IsisRemoteException.java (original)
+++ incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/IsisRemoteException.java Tue May  3 06:33:43 2011
@@ -17,12 +17,10 @@
  *  under the License.
  */
 
-
 package org.apache.isis.runtimes.dflt.remoting.common;
 
 import org.apache.isis.core.commons.exceptions.IsisException;
 
-
 /**
  * Denotes an exception that occurred on the server.
  */

Modified: incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ClientConnection.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ClientConnection.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ClientConnection.java (original)
+++ incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ClientConnection.java Tue May  3 06:33:43 2011
@@ -17,19 +17,17 @@
  *  under the License.
  */
 
-
 package org.apache.isis.runtimes.dflt.remoting.common.client;
 
+import org.apache.isis.core.commons.components.ApplicationScopedComponent;
 import org.apache.isis.runtimes.dflt.remoting.common.exchange.Request;
 import org.apache.isis.runtimes.dflt.remoting.common.exchange.ResponseEnvelope;
 import org.apache.isis.runtimes.dflt.remoting.common.marshalling.ClientMarshaller;
 import org.apache.isis.runtimes.dflt.remoting.server.ServerConnection;
-import org.apache.isis.core.commons.components.ApplicationScopedComponent;
 
 /**
- * Mediates between a running system (which has {@link Request}s that need servicing) and 
- * the {@link ClientMarshaller} that pushes the requests onto the network and pulls them
- * back. 
+ * Mediates between a running system (which has {@link Request}s that need servicing) and the {@link ClientMarshaller}
+ * that pushes the requests onto the network and pulls them back.
  * 
  * @see ServerConnection
  */
@@ -38,4 +36,3 @@ public interface ClientConnection extend
     ResponseEnvelope executeRemotely(Request request);
 
 }
-

Modified: incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ClientConnectionDefault.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ClientConnectionDefault.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ClientConnectionDefault.java (original)
+++ incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ClientConnectionDefault.java Tue May  3 06:33:43 2011
@@ -17,7 +17,6 @@
  *  under the License.
  */
 
-
 package org.apache.isis.runtimes.dflt.remoting.common.client;
 
 import java.io.IOException;
@@ -30,26 +29,22 @@ import org.apache.isis.runtimes.dflt.rem
 import org.apache.isis.runtimes.dflt.runtime.persistence.ConcurrencyException;
 import org.apache.log4j.Logger;
 
-
-
 /**
- * Default implementation of {@link ClientConnection} that delegates to
- * {@link ClientMarshaller} supplied in {@link ClientConnectionDefault constructor}.
+ * Default implementation of {@link ClientConnection} that delegates to {@link ClientMarshaller} supplied in
+ * {@link ClientConnectionDefault constructor}.
  */
-public class ClientConnectionDefault  implements ClientConnection {
+public class ClientConnectionDefault implements ClientConnection {
 
     @SuppressWarnings("unused")
-	private static final Logger LOG = Logger.getLogger(ClientConnectionDefault.class);
+    private static final Logger LOG = Logger.getLogger(ClientConnectionDefault.class);
 
     private final ClientMarshaller marshaller;
 
-
-    //////////////////////////////////////////////////////////
+    // ////////////////////////////////////////////////////////
     // Constructor
-    //////////////////////////////////////////////////////////
+    // ////////////////////////////////////////////////////////
 
-    public ClientConnectionDefault(
-    		final ClientMarshaller marshaller) {
+    public ClientConnectionDefault(final ClientMarshaller marshaller) {
         this.marshaller = marshaller;
     }
 
@@ -57,66 +52,63 @@ public class ClientConnectionDefault  im
         return marshaller;
     }
 
-    
-    //////////////////////////////////////////////////////////
+    // ////////////////////////////////////////////////////////
     // init, shutdown
-    //////////////////////////////////////////////////////////
+    // ////////////////////////////////////////////////////////
 
+    @Override
     public void init() {
-    	marshaller.init();
+        marshaller.init();
     }
 
+    @Override
     public void shutdown() {
-    	marshaller.shutdown();
+        marshaller.shutdown();
     }
 
-
-    //////////////////////////////////////////////////////////
+    // ////////////////////////////////////////////////////////
     // reconnect, connect, disconnect
-    //////////////////////////////////////////////////////////
+    // ////////////////////////////////////////////////////////
 
     private void connect() {
         try {
-			marshaller.connect();
+            marshaller.connect();
         } catch (final IOException e) {
             throw new ConnectionException("Connection failure", e);
-		}
+        }
     }
 
     private void disconnect() {
-    	marshaller.disconnect();
+        marshaller.disconnect();
     }
 
-
-    //////////////////////////////////////////////////////////
+    // ////////////////////////////////////////////////////////
     // executeRemotely
-    //////////////////////////////////////////////////////////
+    // ////////////////////////////////////////////////////////
 
+    @Override
     public ResponseEnvelope executeRemotely(final Request request) {
-    	connect();
+        connect();
         try {
             return executeRemotelyElseException(request);
         } catch (final IOException e) {
             throw new ConnectionException("Failed request", e);
         } finally {
-        	disconnect();
+            disconnect();
         }
     }
 
-	private ResponseEnvelope executeRemotelyElseException(final Request request)
-			throws IOException {
+    private ResponseEnvelope executeRemotelyElseException(final Request request) throws IOException {
 
-		Object response = marshaller.request(request);
-		
-		if (response instanceof ConcurrencyException) {
-			throw (ConcurrencyException) response;
-		} else if (response instanceof Exception) {
-			throw new IsisRemoteException(
-					"Exception occurred on server", (Throwable) response);
-		} else {
-			return (ResponseEnvelope) response;
-		}
-	}
+        final Object response = marshaller.request(request);
 
+        if (response instanceof ConcurrencyException) {
+            throw (ConcurrencyException) response;
+        } else if (response instanceof Exception) {
+            throw new IsisRemoteException("Exception occurred on server", (Throwable) response);
+        } else {
+            return (ResponseEnvelope) response;
+        }
+    }
 
 }

Modified: incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ProxyInstallerAbstract.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ProxyInstallerAbstract.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ProxyInstallerAbstract.java (original)
+++ incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/ProxyInstallerAbstract.java Tue May  3 06:33:43 2011
@@ -27,6 +27,12 @@ import static org.hamcrest.CoreMatchers.
 import java.util.Arrays;
 import java.util.List;
 
+import org.apache.isis.core.commons.config.IsisConfiguration;
+import org.apache.isis.core.metamodel.adapter.ObjectAdapterFactory;
+import org.apache.isis.core.metamodel.facetdecorator.FacetDecorator;
+import org.apache.isis.core.metamodel.services.ServicesInjector;
+import org.apache.isis.core.runtime.authentication.AuthenticationManager;
+import org.apache.isis.core.runtime.authorization.AuthorizationManager;
 import org.apache.isis.runtimes.dflt.remoting.common.client.authentication.AuthenticationManagerProxy;
 import org.apache.isis.runtimes.dflt.remoting.common.client.authorization.AuthorizationManagerProxy;
 import org.apache.isis.runtimes.dflt.remoting.common.client.facetdecorator.ProxyFacetDecorator;
@@ -39,12 +45,6 @@ import org.apache.isis.runtimes.dflt.rem
 import org.apache.isis.runtimes.dflt.remoting.common.protocol.ObjectEncoderDecoder;
 import org.apache.isis.runtimes.dflt.remoting.protocol.internal.ObjectEncoderDecoderDefault;
 import org.apache.isis.runtimes.dflt.remoting.transport.Transport;
-import org.apache.isis.core.commons.config.IsisConfiguration;
-import org.apache.isis.core.metamodel.adapter.ObjectAdapterFactory;
-import org.apache.isis.core.metamodel.facetdecorator.FacetDecorator;
-import org.apache.isis.core.metamodel.services.ServicesInjector;
-import org.apache.isis.core.runtime.authentication.AuthenticationManager;
-import org.apache.isis.core.runtime.authorization.AuthorizationManager;
 import org.apache.isis.runtimes.dflt.runtime.installerregistry.installerapi.ClientConnectionInstaller;
 import org.apache.isis.runtimes.dflt.runtime.installerregistry.installerapi.PersistenceMechanismInstallerAbstract;
 import org.apache.isis.runtimes.dflt.runtime.persistence.adaptermanager.AdapterManagerExtended;
@@ -67,7 +67,7 @@ public abstract class ProxyInstallerAbst
     private ObjectEncoderDecoder encoderDecoder;
     private ServerFacade serverFacade;
 
-    public ProxyInstallerAbstract(String name) {
+    public ProxyInstallerAbstract(final String name) {
         super(ClientConnectionInstaller.TYPE, name);
     }
 
@@ -113,9 +113,9 @@ public abstract class ProxyInstallerAbst
      * {@link #createMarshaller(Transport)} hooks.
      */
     protected ServerFacade createServerFacade() {
-        Transport transport = createTransport();
-        ClientMarshaller marshaller = createMarshaller(transport);
-        ClientConnection connection = new ClientConnectionDefault(marshaller);
+        final Transport transport = createTransport();
+        final ClientMarshaller marshaller = createMarshaller(transport);
+        final ClientConnection connection = new ClientConnectionDefault(marshaller);
         return new ServerFacadeProxy(connection);
     }
 
@@ -165,7 +165,7 @@ public abstract class ProxyInstallerAbst
             new PersistenceSessionProxy(persistenceSessionFactory, adapterFactory, objectFactory, servicesInjector,
                 oidGenerator, adapterManager, getServerFacade(), getEncoderDecoder());
 
-        IsisTransactionManager transactionManager =
+        final IsisTransactionManager transactionManager =
             createTransactionManager(getConfiguration(), persistenceSession.getAdapterManager(), persistenceSession);
 
         ensureThatArg(persistenceSession, is(not(nullValue())));

Modified: incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authentication/AuthenticationManagerProxy.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authentication/AuthenticationManagerProxy.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authentication/AuthenticationManagerProxy.java (original)
+++ incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authentication/AuthenticationManagerProxy.java Tue May  3 06:33:43 2011
@@ -17,40 +17,33 @@
  *  under the License.
  */
 
-
 package org.apache.isis.runtimes.dflt.remoting.common.client.authentication;
 
+import org.apache.isis.core.commons.authentication.AuthenticationSession;
+import org.apache.isis.core.commons.config.IsisConfiguration;
 import org.apache.isis.runtimes.dflt.remoting.common.exchange.CloseSessionRequest;
 import org.apache.isis.runtimes.dflt.remoting.common.facade.ServerFacade;
 import org.apache.isis.runtimes.dflt.remoting.common.protocol.ObjectEncoderDecoder;
 import org.apache.isis.runtimes.dflt.runtime.authentication.AuthenticationManagerStandardForDfltRuntime;
-import org.apache.isis.core.commons.authentication.AuthenticationSession;
-import org.apache.isis.core.commons.config.IsisConfiguration;
-import org.apache.isis.core.runtime.authentication.standard.AuthenticationManagerStandard;
-
 
 public class AuthenticationManagerProxy extends AuthenticationManagerStandardForDfltRuntime {
 
-    private ServerFacade serverFacade;
+    private final ServerFacade serverFacade;
 
-    public AuthenticationManagerProxy(
-    		final IsisConfiguration configuration,
-    		final ServerFacade serverFacade,
-    		final ObjectEncoderDecoder encoderDecoder) {
-    	super(configuration);
-    	this.serverFacade = serverFacade;
-
-        ProxyAuthenticator authenticator =
-        	new ProxyAuthenticator(getConfiguration(), serverFacade, encoderDecoder);
-		addAuthenticator(authenticator);
+    public AuthenticationManagerProxy(final IsisConfiguration configuration, final ServerFacade serverFacade,
+        final ObjectEncoderDecoder encoderDecoder) {
+        super(configuration);
+        this.serverFacade = serverFacade;
+
+        final ProxyAuthenticator authenticator =
+            new ProxyAuthenticator(getConfiguration(), serverFacade, encoderDecoder);
+        addAuthenticator(authenticator);
     }
 
-
     @Override
     public void closeSession(final AuthenticationSession authSession) {
-		serverFacade.closeSession(new CloseSessionRequest(authSession));
+        serverFacade.closeSession(new CloseSessionRequest(authSession));
         super.closeSession(authSession);
     }
 
 }
-

Modified: incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authentication/ProxyAuthenticator.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authentication/ProxyAuthenticator.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authentication/ProxyAuthenticator.java (original)
+++ incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authentication/ProxyAuthenticator.java Tue May  3 06:33:43 2011
@@ -17,17 +17,12 @@
  *  under the License.
  */
 
+package org.apache.isis.runtimes.dflt.remoting.common.client.authentication;
 
-package org.apache.isis.runtimes.dflt.remoting.common.client.authentication;
-
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.CoreMatchers.not;
 import static org.hamcrest.CoreMatchers.nullValue;
 
-import org.apache.isis.runtimes.dflt.remoting.common.exchange.OpenSessionRequest;
-import org.apache.isis.runtimes.dflt.remoting.common.exchange.OpenSessionResponse;
-import org.apache.isis.runtimes.dflt.remoting.common.facade.ServerFacade;
-import org.apache.isis.runtimes.dflt.remoting.common.protocol.ObjectEncoderDecoder;
 import org.apache.isis.core.commons.authentication.AuthenticationSession;
 import org.apache.isis.core.commons.config.IsisConfiguration;
 import org.apache.isis.core.commons.ensure.Ensure;
@@ -37,51 +32,53 @@ import org.apache.isis.core.runtime.auth
 import org.apache.isis.core.runtime.authentication.standard.AuthenticatorAbstract;
 import org.apache.isis.core.runtime.authentication.standard.PasswordRequestAuthenticatorAbstract;
 import org.apache.isis.core.runtime.authentication.standard.SimpleSession;
-
-public final class ProxyAuthenticator extends PasswordRequestAuthenticatorAbstract {
-	
-	private final ServerFacade serverFacade;
-	private final ObjectEncoderDecoder encoderDecoder;
-	
-	public ProxyAuthenticator(
-			IsisConfiguration configuration, 
-			ServerFacade serverFacade, ObjectEncoderDecoder encoderDecoder) {
-		super(configuration);
-		Ensure.ensureThatArg(serverFacade, is(not(nullValue())));
-		Ensure.ensureThatArg(encoderDecoder, is(not(nullValue())));
-		this.serverFacade = serverFacade;
-		this.encoderDecoder = encoderDecoder;
-	}
-
-	/**
-	 * Whereas the default implementation of {@link AuthenticatorAbstract#authenticate(AuthenticationRequest, String)}
-	 * delegates to this method, this implementation has it the other way around.
-	 */
-	public boolean isValid(AuthenticationRequest request) {
-		// our implementation does not use the code, so can pass in null.
-		return authenticate(request, null) != null;
-	}
-	
-	/**
-	 * Delegates to the provided {@link ServerFacade} to {@link ServerFacade#authenticate(String)}.
-	 *
-	 * <p>
-	 * Compare to the {@link AuthenticatorAbstract#authenticate(AuthenticationRequest, String) default implementation}
-	 * which calls {@link #isValid(AuthenticationRequest)} and then returns
-	 * a {@link SimpleSession}.  
-	 */
-	@Override
-	public AuthenticationSession authenticate(AuthenticationRequest authRequest,
-			String code) {
-        final AuthenticationRequestPassword passwordRequest = (AuthenticationRequestPassword) authRequest;
-        final String username = passwordRequest.getName();
-        if (StringUtils.isNullOrEmpty(username)) {
-            return null;
-        }
-        final String password = passwordRequest.getPassword();
-        
-		OpenSessionRequest request = new OpenSessionRequest(username, password);
-		OpenSessionResponse response = serverFacade.openSession(request);
-		return response.getSession();
-	}
+import org.apache.isis.runtimes.dflt.remoting.common.exchange.OpenSessionRequest;
+import org.apache.isis.runtimes.dflt.remoting.common.exchange.OpenSessionResponse;
+import org.apache.isis.runtimes.dflt.remoting.common.facade.ServerFacade;
+import org.apache.isis.runtimes.dflt.remoting.common.protocol.ObjectEncoderDecoder;
+
+public final class ProxyAuthenticator extends PasswordRequestAuthenticatorAbstract {
+
+    private final ServerFacade serverFacade;
+    private final ObjectEncoderDecoder encoderDecoder;
+
+    public ProxyAuthenticator(final IsisConfiguration configuration, final ServerFacade serverFacade,
+        final ObjectEncoderDecoder encoderDecoder) {
+        super(configuration);
+        Ensure.ensureThatArg(serverFacade, is(not(nullValue())));
+        Ensure.ensureThatArg(encoderDecoder, is(not(nullValue())));
+        this.serverFacade = serverFacade;
+        this.encoderDecoder = encoderDecoder;
+    }
+
+    /**
+     * Whereas the default implementation of {@link AuthenticatorAbstract#authenticate(AuthenticationRequest, String)}
+     * delegates to this method, this implementation has it the other way around.
+     */
+    @Override
+    public boolean isValid(final AuthenticationRequest request) {
+        // our implementation does not use the code, so can pass in null.
+        return authenticate(request, null) != null;
+    }
+
+    /**
+     * Delegates to the provided {@link ServerFacade} to {@link ServerFacade#authenticate(String)}.
+     * 
+     * <p>
+     * Compare to the {@link AuthenticatorAbstract#authenticate(AuthenticationRequest, String) default implementation}
+     * which calls {@link #isValid(AuthenticationRequest)} and then returns a {@link SimpleSession}.
+     */
+    @Override
+    public AuthenticationSession authenticate(final AuthenticationRequest authRequest, final String code) {
+        final AuthenticationRequestPassword passwordRequest = (AuthenticationRequestPassword) authRequest;
+        final String username = passwordRequest.getName();
+        if (StringUtils.isNullOrEmpty(username)) {
+            return null;
+        }
+        final String password = passwordRequest.getPassword();
+
+        final OpenSessionRequest request = new OpenSessionRequest(username, password);
+        final OpenSessionResponse response = serverFacade.openSession(request);
+        return response.getSession();
+    }
 }
\ No newline at end of file

Modified: incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authorization/AuthorizationManagerProxy.java
URL: http://svn.apache.org/viewvc/incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authorization/AuthorizationManagerProxy.java?rev=1098939&r1=1098938&r2=1098939&view=diff
==============================================================================
--- incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authorization/AuthorizationManagerProxy.java (original)
+++ incubator/isis/trunk/runtimes/dflt/remoting/common/src/main/java/org/apache/isis/runtimes/dflt/remoting/common/client/authorization/AuthorizationManagerProxy.java Tue May  3 06:33:43 2011
@@ -17,84 +17,90 @@
  *  under the License.
  */
 
+package org.apache.isis.runtimes.dflt.remoting.common.client.authorization;
 
-package org.apache.isis.runtimes.dflt.remoting.common.client.authorization;
-
 import java.util.HashMap;
 import java.util.Map;
 
+import org.apache.isis.applib.Identifier;
+import org.apache.isis.core.commons.authentication.AuthenticationSession;
+import org.apache.isis.core.commons.config.IsisConfiguration;
+import org.apache.isis.core.metamodel.adapter.ObjectAdapter;
+import org.apache.isis.core.runtime.authorization.AuthorizationManagerAbstract;
 import org.apache.isis.runtimes.dflt.remoting.common.data.common.IdentityData;
 import org.apache.isis.runtimes.dflt.remoting.common.exchange.AuthorizationRequestUsability;
 import org.apache.isis.runtimes.dflt.remoting.common.exchange.AuthorizationRequestVisibility;
 import org.apache.isis.runtimes.dflt.remoting.common.exchange.AuthorizationResponse;
 import org.apache.isis.runtimes.dflt.remoting.common.facade.ServerFacade;
 import org.apache.isis.runtimes.dflt.remoting.common.protocol.ObjectEncoderDecoder;
-import org.apache.isis.applib.Identifier;
-import org.apache.isis.core.commons.authentication.AuthenticationSession;
-import org.apache.isis.core.commons.config.IsisConfiguration;
-import org.apache.isis.core.metamodel.adapter.ObjectAdapter;
-import org.apache.isis.core.runtime.authorization.AuthorizationManagerAbstract;
-
-
-public class AuthorizationManagerProxy extends AuthorizationManagerAbstract {
-
-    private final Map<String,Boolean> visibilityCache = new HashMap<String,Boolean>();
-    private final Map<String,Boolean> usabilityCache = new HashMap<String,Boolean>();
-    
-    private final ServerFacade serverFacade;
-	private final ObjectEncoderDecoder encoderDecoder;
-
-    
-    //////////////////////////////////////////////////////////////////
-    // Constructor
-    //////////////////////////////////////////////////////////////////
-    
-    public AuthorizationManagerProxy(IsisConfiguration configuration, final ServerFacade serverFacade, final ObjectEncoderDecoder encoderDecoder) {
-    	super(configuration);
-        this.serverFacade = serverFacade;
-        this.encoderDecoder = encoderDecoder;
-    }
-
-    //////////////////////////////////////////////////////////////////
-    // init, shutdown
-    //////////////////////////////////////////////////////////////////
-
-    public void init() {}
-
-    public void shutdown() {}
-
-    //////////////////////////////////////////////////////////////////
-    // API
-    //////////////////////////////////////////////////////////////////
-
-    public boolean isUsable(final AuthenticationSession session, ObjectAdapter target, final Identifier identifier) {
-		final IdentityData targetData = encoderDecoder.encodeIdentityData(target);
-
-        final String idString = identifier.toIdentityString(Identifier.CLASS_MEMBERNAME_PARAMETERS);
-		if (!usabilityCache.containsKey(idString)) {
-			AuthorizationResponse response = serverFacade.authorizeUsability(new AuthorizationRequestUsability(session, targetData, idString));
-			final Boolean authorized = isAuthorized(response);
-		    usabilityCache.put(idString, authorized);
-		}
-		return usabilityCache.get(idString);
-    }
-
-    public boolean isVisible(final AuthenticationSession session, ObjectAdapter target, final Identifier identifier) {
-		final IdentityData targetData = encoderDecoder.encodeIdentityData(target);
-
-		final String idString = identifier.toIdentityString(Identifier.CLASS_MEMBERNAME_PARAMETERS);
-		if (!visibilityCache.containsKey(idString)) {
-		    AuthorizationRequestVisibility request = new AuthorizationRequestVisibility(session, targetData, idString);
-			final AuthorizationResponse response = serverFacade.authorizeVisibility(request);
-			Boolean authorized = isAuthorized(response);
-			visibilityCache.put(idString, authorized);
-		}
-		return visibilityCache.get(idString);
-    }
-
-    private Boolean isAuthorized(final AuthorizationResponse response) {
-    	// defensive coding is all (shouldn't really be null)
-    	return response != null? response.isAuthorized(): false;
-    }
-}
-
+
+public class AuthorizationManagerProxy extends AuthorizationManagerAbstract {
+
+    private final Map<String, Boolean> visibilityCache = new HashMap<String, Boolean>();
+    private final Map<String, Boolean> usabilityCache = new HashMap<String, Boolean>();
+
+    private final ServerFacade serverFacade;
+    private final ObjectEncoderDecoder encoderDecoder;
+
+    // ////////////////////////////////////////////////////////////////
+    // Constructor
+    // ////////////////////////////////////////////////////////////////
+
+    public AuthorizationManagerProxy(final IsisConfiguration configuration, final ServerFacade serverFacade,
+        final ObjectEncoderDecoder encoderDecoder) {
+        super(configuration);
+        this.serverFacade = serverFacade;
+        this.encoderDecoder = encoderDecoder;
+    }
+
+    // ////////////////////////////////////////////////////////////////
+    // init, shutdown
+    // ////////////////////////////////////////////////////////////////
+
+    @Override
+    public void init() {
+    }
+
+    @Override
+    public void shutdown() {
+    }
+
+    // ////////////////////////////////////////////////////////////////
+    // API
+    // ////////////////////////////////////////////////////////////////
+
+    @Override
+    public boolean isUsable(final AuthenticationSession session, final ObjectAdapter target, final Identifier identifier) {
+        final IdentityData targetData = encoderDecoder.encodeIdentityData(target);
+
+        final String idString = identifier.toIdentityString(Identifier.CLASS_MEMBERNAME_PARAMETERS);
+        if (!usabilityCache.containsKey(idString)) {
+            final AuthorizationResponse response =
+                serverFacade.authorizeUsability(new AuthorizationRequestUsability(session, targetData, idString));
+            final Boolean authorized = isAuthorized(response);
+            usabilityCache.put(idString, authorized);
+        }
+        return usabilityCache.get(idString);
+    }
+
+    @Override
+    public boolean isVisible(final AuthenticationSession session, final ObjectAdapter target,
+        final Identifier identifier) {
+        final IdentityData targetData = encoderDecoder.encodeIdentityData(target);
+
+        final String idString = identifier.toIdentityString(Identifier.CLASS_MEMBERNAME_PARAMETERS);
+        if (!visibilityCache.containsKey(idString)) {
+            final AuthorizationRequestVisibility request =
+                new AuthorizationRequestVisibility(session, targetData, idString);
+            final AuthorizationResponse response = serverFacade.authorizeVisibility(request);
+            final Boolean authorized = isAuthorized(response);
+            visibilityCache.put(idString, authorized);
+        }
+        return visibilityCache.get(idString);
+    }
+
+    private Boolean isAuthorized(final AuthorizationResponse response) {
+        // defensive coding is all (shouldn't really be null)
+        return response != null ? response.isAuthorized() : false;
+    }
+}



Mime
View raw message