incubator-imperius-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik Bengtson <e...@jpox.org>
Subject Re: Unnecessary class load in JavaActuator
Date Wed, 17 Mar 2010 20:02:34 GMT
David,

I assume that code used to support static methods invocations, so the
instance variable might be null on this scenario.

I propose that you check for for null on instance value, then fallback
to the Class.forName(className) if its null. Also, your changes missed
some of the methods of that class.

 org.apache.imperius.spl.core.Actuator misses a few javadocs regarding this.


On Wed, Mar 17, 2010 at 7:25 PM, David Wood <dawood@us.ibm.com> wrote:
> I've changed it to instance.getClass(), passed all tests and checked it
> in.
>
>
> David Wood
> Policy Technologies Group
> IBM TJ Watson Research Center
> dawood@us.ibm.com
> 914-784-5123 (office), 914-396-6515 (mobile)
>
>
>
>
> From:
> Neeraj Joshi/Durham/IBM@IBMUS
> To:
> imperius-dev@incubator.apache.org
> Date:
> 03/17/2010 02:15 PM
> Subject:
> Re: Unnecessary class load in JavaActuator
>
>
>
> Hey David,
> I can't seem to recall any specific reason for the code below. Did you see
>
> any issues using instance.getClass() ?
>
> Thanks
> Neeraj
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Neeraj Joshi (knee-rudge)
> WebSphere XD - Compute Grid
> AIM, IBM
> Apache Imperius - http://incubator.apache.org/imperius
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>
>
> From:
> David Wood/Watson/IBM@IBMUS
> To:
> imperius-dev@incubator.apache.org
> Date:
> 03/17/2010 12:41 PM
> Subject:
> Unnecessary class load in JavaActuator
>
>
>
> Hi All,
>
> I've got a situation in which my Java-bound policy imports an interface,
> but the implementation is provided by a class in a package I do not have
> access to.  This leads to problems in the JavaActuator.invokeMethod()
> method which does the following:
>
>
> c = Class.forName(instance.getClass().getName());
>
>
> Class.forName() is throwing ClassNotFoundException, which on the face of
> it seems strange since we already have the class in instance.getClass().
> So, this is my question,  "why doesn't this code just do
> c=instance.getClass()?'  This is probably some subtly of Java that I'm not
>
>
> aware of.  Your teachings  will be much appreciated.  thanks.
>
>
> David Wood
> Policy Technologies Group
> IBM TJ Watson Research Center
> dawood@us.ibm.com
> 914-784-5123 (office), 914-396-6515 (mobile)
>
>
>
>
>

Mime
View raw message