From imperius-dev-return-67-apmail-incubator-imperius-dev-archive=incubator.apache.org@incubator.apache.org Thu Jan 10 00:23:21 2008 Return-Path: Delivered-To: apmail-incubator-imperius-dev-archive@locus.apache.org Received: (qmail 2879 invoked from network); 10 Jan 2008 00:23:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Jan 2008 00:23:20 -0000 Received: (qmail 33413 invoked by uid 500); 10 Jan 2008 00:23:10 -0000 Delivered-To: apmail-incubator-imperius-dev-archive@incubator.apache.org Received: (qmail 33400 invoked by uid 500); 10 Jan 2008 00:23:10 -0000 Mailing-List: contact imperius-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: imperius-dev@incubator.apache.org Delivered-To: mailing list imperius-dev@incubator.apache.org Received: (qmail 33391 invoked by uid 99); 10 Jan 2008 00:23:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jan 2008 16:23:10 -0800 X-ASF-Spam-Status: No, hits=-1.0 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [192.18.43.132] (HELO sca-es-mail-1.sun.com) (192.18.43.132) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Jan 2008 00:22:44 +0000 Received: from fe-sfbay-10.sun.com ([192.18.43.129]) by sca-es-mail-1.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m0A0MnKs018442 for ; Wed, 9 Jan 2008 16:22:49 -0800 (PST) Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JUE00E01JOA2T00@fe-sfbay-10.sun.com> (original mail from Craig.Russell@Sun.COM) for imperius-dev@incubator.apache.org; Wed, 09 Jan 2008 16:22:49 -0800 (PST) Received: from [192.168.0.12] (c-24-6-172-77.hsd1.ca.comcast.net [24.6.172.77]) by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JUE00272JQ1ZP30@fe-sfbay-10.sun.com> for imperius-dev@incubator.apache.org; Wed, 09 Jan 2008 16:22:49 -0800 (PST) Date: Wed, 09 Jan 2008 14:54:50 -0800 From: Craig L Russell Subject: Re: test cases In-reply-to: Sender: Craig.Russell@Sun.COM To: imperius-dev@incubator.apache.org Message-id: MIME-version: 1.0 X-Mailer: Apple Mail (2.753) Content-type: multipart/signed; protocol="application/pkcs7-signature"; boundary=Apple-Mail-49-421274919; micalg=sha1 References: X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail-49-421274919 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Hi Neeraj, On Jan 9, 2008, at 2:44 PM, Neeraj Joshi wrote: > Hi Erik, > So the sample policies were designed as test cases to test the major > features of SPL. > That was one of the reasons why they were part of the JavaSPL module > initially (shipping them as samples was an after thought). > We have a couple of 'ComputerSystem' related polices those are > more like > samples (and there are no junit tests associated with them) > > I agree that pure unit tests that don't require visual inspection > would be > ideal but IMO its a non-trivial task. If you like we can setup > conference > calls to discuss this in more detail? Conference calls tend to be problematic with Apache projects. They are difficult to set up due to time zone issues; no decisions can be made; anything discussed has to be published on the dev alias so everyone can participate. Basically, it's best just to use this dev alias for discussions... Craig > > Thanks > Neeraj > > > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > "Those are my principles. If you don't like them I have others." > > http://incubator.apache.org/imperius > > Neeraj Joshi > Autonomic Computing Policy Development > Tivoli, IBM > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > "Erik Bengtson" > 01/09/2008 03:25 PM > Please respond to > imperius-dev@incubator.apache.org > > > To > > cc > > Subject > test cases > > > > > > > Hi, > > I'm promised to provide some test cases, but in the form the tests are > coded > now, you can only recognize failures by visual means. Secondly, the > tests > are not appropriately structured. See: > > Splcore has main classes and unit tests. OK > Javaspl has main classes. OK > JavaSPL-Samples has sample policies and sample API usage. It also > has unit > tests, but these can only be validated visually. > > I propose moving the tests from JavaSPL-Samples to JavaSPL, since > samples > should only contain samples, and rewrite these tests using junit > assertions. > > I can patch those, but if beforehand you can review/apply the > patches in > JIRA it's great. > > > > > > > > Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:Craig.Russell@sun.com P.S. A good JDO? O, Gasp! --Apple-Mail-49-421274919 Content-Transfer-Encoding: base64 Content-Type: application/pkcs7-signature; name=smime.p7s Content-Disposition: attachment; filename=smime.p7s MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGUDCCAwkw ggJyoAMCAQICECvOQSuIjHMvOZRC95BRg/wwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA3MTIxMDE1MjM1MVoXDTA4MTIwOTE1MjM1 MVowbDEQMA4GA1UEBBMHUnVzc2VsbDEUMBIGA1UEKhMLQ3JhaWcgTGFpcmQxHDAaBgNVBAMTE0Ny YWlnIExhaXJkIFJ1c3NlbGwxJDAiBgkqhkiG9w0BCQEWFUNyYWlnLlJ1c3NlbGxAU3VuLkNPTTCC ASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAKzqGlLUastboCRqc0iBoTz2ODcqpMpEyPUo nYtluchkSIoWzOW63AuoTczRt9sKfhwoK5mope+62B6Li06WJabm2UHqKAaNSuMHLsmyqvOdwbSt enY7/HxOSCMqVoyVBTRJc2M8feCSVgi7ptGq9cM+Maa64R1/p9zqaQNucceU/1uper90bWplsjAT rHgicgr9XJIQb6uYjhjlgxxnY/aispnCvLxMX+CiA2FWeeJTI7AiFlLwibTXYF4v12ToByvXtTiJ knuND8qpwhK3Wp0tL4ae8mZ0nlKjCuNnqh99ZyEyTFHZBfVx8WSWRXkY4qxCG/IDQUo7WUaefOQT 1mECAwEAAaMyMDAwIAYDVR0RBBkwF4EVQ3JhaWcuUnVzc2VsbEBTdW4uQ09NMAwGA1UdEwEB/wQC MAAwDQYJKoZIhvcNAQEFBQADgYEAEqfFNFoch0QPVKWJ4maAZl3MJD10yMeWt5xb+WNSkhYKHD8I 42E8tpdE3kmc5wp2cZrz9JqJF/KCQ/gI4pmDk1qpTs5pvXzFNiD5Lu5eLza4iyxSlTHUXcCnyNC6 4m0qC8p4m/51NEql5hyacj/+vdlEe5dygpyNGUCiyA/SdAswggM/MIICqKADAgECAgENMA0GCSqG SIb3DQEBBQUAMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBDYXBlMRIwEAYDVQQH EwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25zdWx0aW5nMSgwJgYDVQQLEx9DZXJ0aWZp Y2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYDVQQDExtUaGF3dGUgUGVyc29uYWwgRnJlZW1h aWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZyZWVtYWlsQHRoYXd0ZS5jb20wHhcNMDMw NzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5WjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3Rl IENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWls IElzc3VpbmcgQ0EwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMSmPFVzVftOucqZWh5owHUE cJ3f6f+jHuy9zfVb8hp2vX8MOmHyv1HOAdTlUAow1wJjWiyJFXCO3cnwK4Vaqj9xVsuvPAsH5/Ef kTYkKhPPK9Xzgnc9A74r/rsYPge/QIACZNenprufZdHFKlSFD0gEf6e20TxhBEAeZBlyYLf7AgMB AAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB/wIBADBDBgNVHR8EPDA6MDigNqA0hjJodHRwOi8vY3Js LnRoYXd0ZS5jb20vVGhhd3RlUGVyc29uYWxGcmVlbWFpbENBLmNybDALBgNVHQ8EBAMCAQYwKQYD VR0RBCIwIKQeMBwxGjAYBgNVBAMTEVByaXZhdGVMYWJlbDItMTM4MA0GCSqGSIb3DQEBBQUAA4GB AEiM0VCD6gsuzA2jZqxnD3+vrL7CF6FDlpSdf0whuPg2H6otnzYvwPQcUCCTcDz9reFhYsPZOhl+ hLGZGwDFGguCdJ4lUJRix9sncVcljd2pnDmOjCBPZV+V2vf3h9bGCE6u9uo05RAaWzVNd+NWIXiC 3CEZNd4ksdMdRv9dX2VPMYIDEDCCAwwCAQEwdjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt YWlsIElzc3VpbmcgQ0ECECvOQSuIjHMvOZRC95BRg/wwCQYFKw4DAhoFAKCCAW8wGAYJKoZIhvcN AQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDgwMTA5MjI1NDUxWjAjBgkqhkiG9w0B CQQxFgQUGqDuEr5WQmrNhGUR7lvJEvAThWMwgYUGCSsGAQQBgjcQBDF4MHYwYjELMAkGA1UEBhMC WkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0 ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhArzkEriIxzLzmUQveQUYP8MIGHBgsqhkiG 9w0BCRACCzF4oHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQ dHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhAr zkEriIxzLzmUQveQUYP8MA0GCSqGSIb3DQEBAQUABIIBAJA0NYiy+GpNRBX+TK5tFnxEoZa1pF8J DIFIvlry4bIGiAkWo4InXv1YFSR1wwXMW/NJvtzMcpaprkKYP9wrd/sqrozNQAqRE/0QvQW47Izr w1N2h4G/1H9HLoOAFuS1LUKYw7DPZ3yBpgqd71TTA60hDdwBPJPLSxLPqqMM/cL9/JL+IO4VgJHk 1HjSReqi9chtTC5gql8SrsyOY+lm1yaJwdD3DDFqDwkH2vDF27HrLECHaFMRzWcM2CaR+VRaKD2r eez/T6R17MPpytCs7Pu/t3rmCETEqWtwUvKFE+FY85G+aH8wsucsFF+5VqcRESUh4w1BeeK+ESEi uNZLITAAAAAAAAA= --Apple-Mail-49-421274919--