incubator-hcatalog-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sushanth Sowmyan (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HCATALOG-426) HCatalog should log with slf4j everywhere
Date Mon, 18 Jun 2012 17:31:43 GMT

    [ https://issues.apache.org/jira/browse/HCATALOG-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396048#comment-13396048
] 

Sushanth Sowmyan edited comment on HCATALOG-426 at 6/18/12 5:30 PM:
--------------------------------------------------------------------

Travis, could you please submit a reviews.apache.org code review request for the same? It's
easier to review through that.

I've gone through the patch, and find a couple of things I'd like changed:

a) In the change you make to generate_data.pl, you remove the commonsLoggingJar from the return
value array, but not from the function (#main) that calls findHadoopJars - this would result
in misattributed jars (and a null for one of the returns that are then used to construct a
command) and could break the e2e run.

b) There's one commented instance of getLogFactory in src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java
which could also be changed - actually, on second thought, maybe better to just remove that
line altogether.

Thanks!



                
      was (Author: sushanth):
    Travis, could you please submit a reviews.apache.org code review request for the same?
It's easier to review through that.

I've gone through the patch, and find a couple of things I'd like changed:

a) In the change you make to generate_data.pl, you remove the commonsLoggingJar from the return
value array, but not from the function (#main) that calls findHadoopJars - this would result
in misattributed jars (and a null for one of the returns that are then used to construct a
command) and could break the e2e run.

b) There's one commented instance of getLogFactory in src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java
which could also be changed



                  
> HCatalog should log with slf4j everywhere
> -----------------------------------------
>
>                 Key: HCATALOG-426
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-426
>             Project: HCatalog
>          Issue Type: Bug
>            Reporter: Travis Crawford
>            Assignee: Travis Crawford
>            Priority: Minor
>         Attachments: HCATALOG-426_slf4j_everywhere.1.patch
>
>
> Some HCatalog classes use slf4j logging. These should be migrated to commons-logging
so all logging is handled the same way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message