incubator-hcatalog-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ga...@apache.org
Subject svn commit: r1425221 - in /incubator/hcatalog/trunk: CHANGES.txt core/src/main/java/org/apache/hcatalog/mapreduce/InputJobInfo.java core/src/test/java/org/apache/hcatalog/mapreduce/TestInputJobInfo.java
Date Sat, 22 Dec 2012 01:22:02 GMT
Author: gates
Date: Sat Dec 22 01:22:01 2012
New Revision: 1425221

URL: http://svn.apache.org/viewvc?rev=1425221&view=rev
Log:
HCATALOG-576 HCATALOG-527 Broke backward compatibility

Added:
    incubator/hcatalog/trunk/core/src/test/java/org/apache/hcatalog/mapreduce/TestInputJobInfo.java
Modified:
    incubator/hcatalog/trunk/CHANGES.txt
    incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/InputJobInfo.java

Modified: incubator/hcatalog/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/incubator/hcatalog/trunk/CHANGES.txt?rev=1425221&r1=1425220&r2=1425221&view=diff
==============================================================================
--- incubator/hcatalog/trunk/CHANGES.txt (original)
+++ incubator/hcatalog/trunk/CHANGES.txt Sat Dec 22 01:22:01 2012
@@ -156,6 +156,8 @@ Trunk (unreleased changes)
   OPTIMIZATIONS
 
   BUG FIXES
+  HCAT-576 HCATALOG-527 Broke backward compatibility (gates)
+
   HCAT-567 HCatClient must allow retrieval of multiple partitions using a partial partition
spec.(mithun via avandana)
 
   HCAT-556 HCatalog-trunk doesn't build against Hive-0.10.0 (mithun via avandana)

Modified: incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/InputJobInfo.java
URL: http://svn.apache.org/viewvc/incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/InputJobInfo.java?rev=1425221&r1=1425220&r2=1425221&view=diff
==============================================================================
--- incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/InputJobInfo.java
(original)
+++ incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/InputJobInfo.java
Sat Dec 22 01:22:01 2012
@@ -70,6 +70,7 @@ public class InputJobInfo implements Ser
      * @param databaseName the db name
      * @param tableName the table name
      * @param filter the partition filter
+     * @param properties implementation specific job properties
      */
     public static InputJobInfo create(String databaseName,
                                       String tableName,
@@ -78,6 +79,21 @@ public class InputJobInfo implements Ser
         return new InputJobInfo(databaseName, tableName, filter, properties);
     }
 
+    /**
+     * Initializes a new InputJobInfo
+     * for reading data from a table.
+     * @param databaseName the db name
+     * @param tableName the table name
+     * @param filter the partition filter
+     */
+    @Deprecated
+    public static InputJobInfo create(String databaseName,
+                                      String tableName,
+                                      String filter) {
+        return create(databaseName, tableName, filter, null);
+    }
+
+
     private InputJobInfo(String databaseName,
                          String tableName,
                          String filter,

Added: incubator/hcatalog/trunk/core/src/test/java/org/apache/hcatalog/mapreduce/TestInputJobInfo.java
URL: http://svn.apache.org/viewvc/incubator/hcatalog/trunk/core/src/test/java/org/apache/hcatalog/mapreduce/TestInputJobInfo.java?rev=1425221&view=auto
==============================================================================
--- incubator/hcatalog/trunk/core/src/test/java/org/apache/hcatalog/mapreduce/TestInputJobInfo.java
(added)
+++ incubator/hcatalog/trunk/core/src/test/java/org/apache/hcatalog/mapreduce/TestInputJobInfo.java
Sat Dec 22 01:22:01 2012
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.hcatalog.mapreduce;
+
+import java.util.Properties;
+
+import junit.framework.Assert;
+
+import org.junit.Test;
+
+public class TestInputJobInfo extends HCatBaseTest {
+
+    @Test
+    public void test4ArgCreate() throws Exception {
+        Properties p = new Properties();
+        p.setProperty("key", "value");
+        InputJobInfo jobInfo = InputJobInfo.create("Db", "Table", "Filter", p);
+        Assert.assertEquals("Db", jobInfo.getDatabaseName());
+        Assert.assertEquals("Table", jobInfo.getTableName());
+        Assert.assertEquals("Filter", jobInfo.getFilter());
+        Assert.assertEquals("value", jobInfo.getProperties().getProperty("key"));
+    }
+
+    @Test
+    public void test3ArgCreate() throws Exception {
+        InputJobInfo jobInfo = InputJobInfo.create("Db", "Table", "Filter");
+        Assert.assertEquals("Db", jobInfo.getDatabaseName());
+        Assert.assertEquals("Table", jobInfo.getTableName());
+        Assert.assertEquals("Filter", jobInfo.getFilter());
+        Assert.assertEquals(0, jobInfo.getProperties().size());
+    }
+}



Mime
View raw message