incubator-hcatalog-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From avand...@apache.org
Subject svn commit: r1417146 - in /incubator/hcatalog/trunk: ./ core/src/main/java/org/apache/hcatalog/common/ core/src/main/java/org/apache/hcatalog/mapreduce/ server-extensions/src/main/java/org/apache/hcatalog/listener/ webhcat/java-client/src/main/java/org...
Date Tue, 04 Dec 2012 20:10:39 GMT
Author: avandana
Date: Tue Dec  4 20:10:37 2012
New Revision: 1417146

URL: http://svn.apache.org/viewvc?rev=1417146&view=rev
Log:
HCAT-559 Fix trivial build warnings in HCat trunk. 

Modified:
    incubator/hcatalog/trunk/CHANGES.txt
    incubator/hcatalog/trunk/build.xml
    incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/common/HCatConstants.java
    incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
    incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
    incubator/hcatalog/trunk/server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java
    incubator/hcatalog/trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatClient.java

Modified: incubator/hcatalog/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/incubator/hcatalog/trunk/CHANGES.txt?rev=1417146&r1=1417145&r2=1417146&view=diff
==============================================================================
--- incubator/hcatalog/trunk/CHANGES.txt (original)
+++ incubator/hcatalog/trunk/CHANGES.txt Tue Dec  4 20:10:37 2012
@@ -147,6 +147,8 @@ Trunk (unreleased changes)
   OPTIMIZATIONS
 
   BUG FIXES
+  HCAT-559 Fix trivial build warnings in HCat trunk (mithunr via avandana)
+
   HCAT-555 hcat script should look for hcatalog-core jar and add HCAT_PREFIX/conf as a config
location that is checked. (arpitgupta via traviscrawford)
 
   HCAT-534 HCat_Drop_Table_3 dfs mkdir failing on hadoop23 (cdrome via toffer)

Modified: incubator/hcatalog/trunk/build.xml
URL: http://svn.apache.org/viewvc/incubator/hcatalog/trunk/build.xml?rev=1417146&r1=1417145&r2=1417146&view=diff
==============================================================================
--- incubator/hcatalog/trunk/build.xml (original)
+++ incubator/hcatalog/trunk/build.xml Tue Dec  4 20:10:37 2012
@@ -168,6 +168,7 @@
 
     <target name="javadoc" depends="jar" description="Generate Javadoc documentation">
         <mkdir dir="${build.javadoc}"/>
+        <record name="${build.dir}/javadoc.log" action="start"/>
         <javadoc overview="${src.dir}/../docs/overview.html"
                  packagenames="org.apache.hcatalog.*"
                  destdir="${build.javadoc}"
@@ -194,6 +195,13 @@
             </classpath>
             <group title="hcatalog" packages="org.apache.hcatalog.*"/>
         </javadoc>
+        <record name="${build.dir}/javadoc.log" action="stop"/>
+        <condition property="javadoc.warnings">
+            <isfileselected file="${build.dir}/javadoc.log">
+                <contains text="warnings"/>
+            </isfileselected>
+        </condition>
+        <fail if="javadoc.warnings">Javadoc comments contain warnings.</fail>
     </target>
 
     <!--

Modified: incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/common/HCatConstants.java
URL: http://svn.apache.org/viewvc/incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/common/HCatConstants.java?rev=1417146&r1=1417145&r2=1417146&view=diff
==============================================================================
--- incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/common/HCatConstants.java
(original)
+++ incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/common/HCatConstants.java
Tue Dec  4 20:10:37 2012
@@ -45,9 +45,9 @@ public final class HCatConstants {
 
     /**
      * {@value} (default: null)
-     * When the property is set in the UDFContext of the {@link HCatStorer}, {@link HCatStorer}
writes
+     * When the property is set in the UDFContext of the org.apache.hcatalog.pig.HCatStorer,
HCatStorer writes
      * to the location it specifies instead of the default HCatalog location format. An example
can be found
-     * in @{link HCatStorerWrapper}.
+     * in org.apache.hcatalog.pig.HCatStorerWrapper.
      */
     public static final String HCAT_PIG_STORER_EXTERNAL_LOCATION = HCAT_PIG_STORER + ".external.location";
 

Modified: incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
URL: http://svn.apache.org/viewvc/incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java?rev=1417146&r1=1417145&r2=1417146&view=diff
==============================================================================
--- incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
(original)
+++ incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
Tue Dec  4 20:10:37 2012
@@ -123,10 +123,10 @@ class FileOutputFormatContainer extends 
                 new Table(jobInfo.getTableInfo().getTable()));
         } catch (MetaException e) {
             throw new IOException(e);
-        } catch (TException e) {
-            throw new IOException(e);
         } catch (NoSuchObjectException e) {
             throw new IOException(e);
+        } catch (TException e) {
+            throw new IOException(e);
         } finally {
             HCatUtil.closeHiveClientQuietly(client);
         }

Modified: incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
URL: http://svn.apache.org/viewvc/incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java?rev=1417146&r1=1417145&r2=1417146&view=diff
==============================================================================
--- incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
(original)
+++ incubator/hcatalog/trunk/core/src/main/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
Tue Dec  4 20:10:37 2012
@@ -58,7 +58,7 @@ public class HCatOutputFormat extends HC
     private static boolean harRequested;
 
     /**
-     * @see org.apache.hcatalog.mapreduce.HCatOutputFormat#setOutput(org.apache.hadoop.conf.Configuration,
OutputJobInfo)
+     * @see org.apache.hcatalog.mapreduce.HCatOutputFormat#setOutput(org.apache.hadoop.conf.Configuration,
Credentials, OutputJobInfo)
      */
     public static void setOutput(Job job, OutputJobInfo outputJobInfo) throws IOException
{
         setOutput(job.getConfiguration(), job.getCredentials(), outputJobInfo);
@@ -68,7 +68,8 @@ public class HCatOutputFormat extends HC
      * Set the information about the output to write for the job. This queries the metadata
server
      * to find the StorageHandler to use for the table.  It throws an error if the
      * partition is already published.
-     * @param job the job object
+     * @param conf the Configuration object
+     * @param credentials the Credentials object
      * @param outputJobInfo the table output information for the job
      * @throws IOException the exception in communicating with the metadata server
      */

Modified: incubator/hcatalog/trunk/server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java
URL: http://svn.apache.org/viewvc/incubator/hcatalog/trunk/server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java?rev=1417146&r1=1417145&r2=1417146&view=diff
==============================================================================
--- incubator/hcatalog/trunk/server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java
(original)
+++ incubator/hcatalog/trunk/server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java
Tue Dec  4 20:10:37 2012
@@ -315,8 +315,8 @@ public class NotificationListener extend
      * Get the topic object for the topicName, it also tries to reconnect
      * if the connection appears to be broken.
      *
-     * @param topicName
-     * @return
+     * @param topicName The String identifying the message-topic.
+     * @return A {@link Topic} object corresponding to the specified topicName.
      * @throws JMSException
      */
     protected Topic getTopic(final String topicName) throws JMSException {

Modified: incubator/hcatalog/trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatClient.java
URL: http://svn.apache.org/viewvc/incubator/hcatalog/trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatClient.java?rev=1417146&r1=1417145&r2=1417146&view=diff
==============================================================================
--- incubator/hcatalog/trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatClient.java
(original)
+++ incubator/hcatalog/trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatClient.java
Tue Dec  4 20:10:37 2012
@@ -218,7 +218,7 @@ public abstract class HCatClient {
      * Adds a list of partitions.
      *
      * @param partInfoList A list of HCatAddPartitionDesc.
-     * @return
+     * @return The number of partitions added.
      * @throws HCatException,ConnectionFailureException
      */
     public abstract int addPartitions(List<HCatAddPartitionDesc> partInfoList)



Mime
View raw message