From hcatalog-commits-return-130-apmail-incubator-hcatalog-commits-archive=incubator.apache.org@incubator.apache.org Thu May 5 17:48:42 2011 Return-Path: X-Original-To: apmail-incubator-hcatalog-commits-archive@minotaur.apache.org Delivered-To: apmail-incubator-hcatalog-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8C8FA2569 for ; Thu, 5 May 2011 17:48:42 +0000 (UTC) Received: (qmail 39106 invoked by uid 500); 5 May 2011 17:48:42 -0000 Delivered-To: apmail-incubator-hcatalog-commits-archive@incubator.apache.org Received: (qmail 39081 invoked by uid 500); 5 May 2011 17:48:42 -0000 Mailing-List: contact hcatalog-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hcatalog-dev@incubator.apache.org Delivered-To: mailing list hcatalog-commits@incubator.apache.org Received: (qmail 39073 invoked by uid 99); 5 May 2011 17:48:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 May 2011 17:48:42 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 May 2011 17:48:41 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 20E75C26CB for ; Thu, 5 May 2011 17:48:03 +0000 (UTC) Date: Thu, 5 May 2011 17:48:03 +0000 (UTC) From: "Ashutosh Chauhan (JIRA)" To: hcatalog-commits@incubator.apache.org Message-ID: <1875699977.25346.1304617683117.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1027539567.16983.1304381403713.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (HCATALOG-18) Refactor TestRCFileInputStorageDriver MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HCATALOG-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan resolved HCATALOG-18. -------------------------------------- Resolution: Fixed Fix Version/s: 0.2 Patch checked-in. Thanks, Jakob. > Refactor TestRCFileInputStorageDriver > ------------------------------------- > > Key: HCATALOG-18 > URL: https://issues.apache.org/jira/browse/HCATALOG-18 > Project: HCatalog > Issue Type: Improvement > Reporter: Jakob Homan > Assignee: Jakob Homan > Fix For: 0.2 > > Attachments: refactor_TestRCFileInputStorageDriver.patch > > > TestRCFileInputStorageDriver has a lot of duplicated code and doesn't use the most efficient collections code. This patch shaves about 80 lines off and focuses more on the tests themselves. Tests pass, except for some reason TestPermsInheritance is failing for me now with or without this patch. I don't believe it's related. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira