Mailing-List: contact hama-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hama-dev@incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <E5C0437C-A1D3-441C-905C-2794E3BE6AD4@apache.org>
References: 
 <1472222380.5689.1335203675628.JavaMail.tomcat@hel.zones.apache.org>
	<E5C0437C-A1D3-441C-905C-2794E3BE6AD4@apache.org>
Date: Tue, 24 Apr 2012 10:33:34 +0900
Message-ID: 
 <CAGQgZQTPsWYvbqcee2u3ULgVJFFE77YDnH=H9zvh=ei0VNBkfg@mail.gmail.com>
Subject: Re: [jira] [Assigned] (ACCUMULO-532) Add BSP input/output formats to
 client package
From: "Edward J. Yoon" <edwardyoon@apache.org>
To: hama-dev@incubator.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

According to CHANGE log, I've added input/output system to BSP
framework. But, I don't know exactly why we need to check
(conf.get("bsp.input (or output).dir") !=3D null) conditions when
initialize record reader/writer objects?

If there's no objection or opinion, I'd like to change like this:

Index: core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java	(revision 13295=
23)
+++ core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java	(working copy)
@@ -185,8 +185,7 @@

     initInput();

-    // just output something when the user configured it
-    if (conf.get("bsp.output.dir") !=3D null) {
+    if (!bspJob.getInputFormat().getClass().equals(NullOutputFormat.class)=
) {
       Path outdir =3D new Path(conf.get("bsp.output.dir"),
           Task.getOutputName(partition));
       outWriter =3D bspJob.getOutputFormat().getRecordWriter(fs, bspJob,
@@ -204,8 +203,7 @@

   @SuppressWarnings("unchecked")
   public final void initInput() throws IOException {
-    // just read input if the user defined one
-    if (conf.get("bsp.input.dir") !=3D null) {
+    if (!bspJob.getInputFormat().getClass().equals(NullInputFormat.class))=
 {
       InputSplit inputSplit =3D null;
       // reinstantiate the split
       try {


On Tue, Apr 24, 2012 at 6:39 AM, Edward J. Yoon <edwardyoon@apache.org> wro=
te:
> FYI,
>
> "Let me know if you see any issues with this. =C2=A0It could probably use=
 some more testing. =C2=A0I was able to get the unit tests working (even th=
e part commented out in the patch) but I had to set fake input and output p=
aths. =C2=A0It seems that BSP doesn't initialize the RecordReader and Recor=
dWriter unless the configuration options "bsp.input.dir" and "bsp.output.di=
r" are set."
>
> Sent from my iPad
>
> Begin forwarded message:
>
>> From: "Billie Rinaldi (JIRA)" <jira@apache.org>
>> Date: April 24, 2012 2:54:35 AM GMT+09:00
>> To: dev@accumulo.apache.org
>> Subject: [jira] [Assigned] (ACCUMULO-532) Add BSP input/output formats t=
o client package
>> Reply-To: dev@accumulo.apache.org
>>
>> Let me know if you see any issues with this. =C2=A0It could probably use=
 some more testing. =C2=A0I was able to get the unit tests working (even th=
e part commented out in the patch) but I had to set fake input and output p=
aths. =C2=A0It seems that BSP doesn't initialize the RecordReader and Recor=
dWriter unless the configuration options "bsp.input.dir" and "bsp.output.di=
r" are set.


--=20
Best Regards, Edward J. Yoon
@eddieyoon