incubator-hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HAMA-499) Refactor clearZKNodes() in BSPMaster
Date Thu, 15 Mar 2012 23:10:37 GMT

    [ https://issues.apache.org/jira/browse/HAMA-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230692#comment-13230692
] 

Hudson commented on HAMA-499:
-----------------------------

Integrated in Hama-Nightly #487 (See [https://builds.apache.org/job/Hama-Nightly/487/])
    [HAMA-499]: Refactor clearZKNodes() in BSPMaster contributed by Apurv Verma (Revision
1301114)

     Result = SUCCESS
tjungblut : 
Files : 
* /incubator/hama/trunk/CHANGES.txt
* /incubator/hama/trunk/core/src/main/java/org/apache/hama/MiniZooKeeperCluster.java
* /incubator/hama/trunk/core/src/main/java/org/apache/hama/bsp/BSPMaster.java
* /incubator/hama/trunk/core/src/test/java/org/apache/hama/HamaClusterTestCase.java
* /incubator/hama/trunk/core/src/test/java/org/apache/hama/MiniZooKeeperCluster.java
* /incubator/hama/trunk/core/src/test/java/org/apache/hama/bsp/TestBSPMasterGroomServer.java

                
> Refactor clearZKNodes() in BSPMaster
> ------------------------------------
>
>                 Key: HAMA-499
>                 URL: https://issues.apache.org/jira/browse/HAMA-499
>             Project: Hama
>          Issue Type: Improvement
>          Components: bsp
>    Affects Versions: 0.4.0
>            Reporter: Edward J. Yoon
>            Assignee: Apurv Verma
>              Labels: newbie
>             Fix For: 0.5.0
>
>         Attachments: HAMA-499.patch, HAMA-499_2.patch, move.sh
>
>
> As you know, Hama uses ZooKeepr for a barrier synchronization. User can use Hama ZK,
or their own existing ZK cluster. To avoid some potential problems, BSPMaster calls clearZKNodes()
to delete all remained sub-nodes of 'bspRoot' at initialization stage. That code is here and
very ugly:
> {code}
>   public void clearZKNodes() {
>     try {
>       for (String node : zk.getChildren(bspRoot, this)) {
>         for (String subnode : zk.getChildren(bspRoot + "/" + node, this)) {
>           for (String subnode2 : zk.getChildren(bspRoot + "/" + node, this)) {
>             for (String subnode3 : zk.getChildren(bspRoot + "/" + node + "/" + subnode2,
this)) {
>               zk.delete(bspRoot + "/" + node + "/" + subnode + "/" + subnode2 + "/" +
subnode3, 0);
>             }
>             zk.delete(bspRoot + "/" + node + "/" + subnode + "/" + subnode2, 0);
>           }
>           zk.delete(bspRoot + "/" + node + "/" + subnode, 0);
>         }
>         zk.delete(bspRoot + "/" + node, 0);
>       }
>     } catch (KeeperException e) {
>     } catch (InterruptedException e) {
>     }
>   }
> {code}
> In this issue, we'll refactor this method. For example, you can delete recursively.
> P.S., must use '-1' to delete all version of each node like this:
> {code}
> zk.delete(node, -1);
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message