incubator-hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Jungblut (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HAMA-502) Message API Improvement
Date Thu, 09 Feb 2012 15:02:05 GMT

    [ https://issues.apache.org/jira/browse/HAMA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204573#comment-13204573
] 

Thomas Jungblut commented on HAMA-502:
--------------------------------------

I like it. At least, this is now typesafe.

In anycase we should make all the generics in BSP and BSPPeer <? extends Writable>.
                
> Message API Improvement
> -----------------------
>
>                 Key: HAMA-502
>                 URL: https://issues.apache.org/jira/browse/HAMA-502
>             Project: Hama
>          Issue Type: Improvement
>          Components: bsp
>    Affects Versions: 0.4.0
>            Reporter: Thomas Jungblut
>            Assignee: Edward J. Yoon
>              Labels: newbie
>             Fix For: 0.5.0
>
>         Attachments: generic.patch, v02.patch
>
>
> Accordingly what we have discussed on the mailing list, we want to switch the API from
the restricted BSPMessage type to <? extends Writable>.
> So send is going to look like this:
> bq. public final void send(String peerName, <? extends Writable> msg)
> And receive:
> bq. public final <? extends Writable> getCurrentMessage()
> There should be no backward compatibility issues because BSPMessage is currently a "child"
of Writable.
> All the related class are:
> Interface: BSPPeer, MessageManager
> Class: BSPPeerImpl, HadoopMessageManagerImpl
> Maybe other class like BSPMessageBundle must be widened to use <? extends Writable>.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message