Return-Path: X-Original-To: apmail-incubator-hama-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-hama-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8F7BE9E61 for ; Wed, 19 Oct 2011 05:46:38 +0000 (UTC) Received: (qmail 77812 invoked by uid 500); 19 Oct 2011 05:46:38 -0000 Delivered-To: apmail-incubator-hama-dev-archive@incubator.apache.org Received: (qmail 77705 invoked by uid 500); 19 Oct 2011 05:46:37 -0000 Mailing-List: contact hama-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hama-dev@incubator.apache.org Delivered-To: mailing list hama-dev@incubator.apache.org Received: (qmail 77613 invoked by uid 99); 19 Oct 2011 05:46:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Oct 2011 05:46:34 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Oct 2011 05:46:31 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A16963106B2 for ; Wed, 19 Oct 2011 05:46:10 +0000 (UTC) Date: Wed, 19 Oct 2011 05:46:10 +0000 (UTC) From: "Edward J. Yoon (Commented) (JIRA)" To: hama-dev@incubator.apache.org Message-ID: <1503496076.9233.1319003170662.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1800030880.6739.1318953070631.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HAMA-457) Refactoring of BSPPeerImpl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HAMA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130369#comment-13130369 ] Edward J. Yoon commented on HAMA-457: ------------------------------------- However, overall looks good to me. And, patch is not work for me. {code} edward@slave:~/workspace/hama-trunk$ patch -p0 < HAMA-457_v2.patch patching file core/conf/hama-default.xml patching file core/src/test/java/org/apache/hama/HamaTestCase.java patching file core/src/test/java/org/apache/hama/bsp/BSPSerializerWrapper.java patching file core/src/test/java/org/apache/hama/bsp/TestBSPMasterGroomServer.java patching file core/src/test/java/org/apache/hama/checkpoint/TestCheckpoint.java patching file core/src/main/java/org/apache/hama/zookeeper/QuorumPeer.java patching file core/src/main/java/org/apache/hama/bsp/GroomServer.java patching file core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java patching file core/src/main/java/org/apache/hama/bsp/sync/SyncServer.java patching file core/src/main/java/org/apache/hama/bsp/sync/zookeeper/ZooKeeperSyncClientImpl.java patching file core/src/main/java/org/apache/hama/bsp/sync/zookeeper/ZooKeeperSyncServerImpl.java patching file core/src/main/java/org/apache/hama/bsp/sync/rpc/RPCSyncClientImpl.java patching file core/src/main/java/org/apache/hama/bsp/sync/rpc/RPCSyncServer.java patching file core/src/main/java/org/apache/hama/bsp/sync/rpc/RPCSyncServerImpl.java patching file core/src/main/java/org/apache/hama/bsp/sync/SyncServiceFactory.java patching file core/src/main/java/org/apache/hama/bsp/sync/SyncClient.java patching file core/src/main/java/org/apache/hama/bsp/BSPPeer.java patching file core/src/main/java/org/apache/hama/bsp/BSPSerializableMessage.java patching file core/src/main/java/org/apache/hama/bsp/BSPMessageSerializer.java patching file core/src/main/java/org/apache/hama/bsp/LocalBSPRunner.java patching file core/src/main/java/org/apache/hama/checkpoint/CheckpointRunner.java patching file core/src/main/java/org/apache/hama/checkpoint/Checkpointer.java patching file core/src/main/java/org/apache/hama/util/StringArrayWritable.java Hunk #1 FAILED at 15. 1 out of 1 hunk FAILED -- saving rejects to file core/src/main/java/org/apache/hama/util/StringArrayWritable.java.rej patching file core/src/main/java/org/apache/hama/util/BSPNetUtils.java patching file yarn/src/main/java/org/apache/hama/bsp/BSPApplicationMaster.java patching file yarn/src/main/java/org/apache/hama/bsp/sync/StringArrayWritable.java patching file yarn/src/main/java/org/apache/hama/bsp/sync/SyncServer.java patching file yarn/src/main/java/org/apache/hama/bsp/sync/SyncServerImpl.java patching file yarn/src/main/java/org/apache/hama/bsp/YARNBSPPeerImpl.java {code} > Refactoring of BSPPeerImpl > -------------------------- > > Key: HAMA-457 > URL: https://issues.apache.org/jira/browse/HAMA-457 > Project: Hama > Issue Type: Improvement > Affects Versions: 0.3.0 > Reporter: Thomas Jungblut > Assignee: Thomas Jungblut > Fix For: 0.4.0 > > Attachments: HAMA-457.patch, HAMA-457_v2.patch > > > Extract a sync service which allows the user to implement and configure their own services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira