incubator-hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward J. Yoon (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HAMA-447) Apply analysis tools in order to optimize code
Date Fri, 07 Oct 2011 01:56:29 GMT

    [ https://issues.apache.org/jira/browse/HAMA-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122492#comment-13122492
] 

Edward J. Yoon commented on HAMA-447:
-------------------------------------

{code}
-  private long startTime = 0;
-
   // The 'next' usable taskid of this tip
   int nextTaskId = 0;
 
@@ -133,7 +128,7 @@
    * Return the start time
    */
   public long getStartTime() {
-    return startTime;
+    return 0l;
   }
{code}

We have to initial startTime when task is initialized, instead of hard-coded value. I'll update
patch with latest changes I made.



                
> Apply analysis tools in order to optimize code
> ----------------------------------------------
>
>                 Key: HAMA-447
>                 URL: https://issues.apache.org/jira/browse/HAMA-447
>             Project: Hama
>          Issue Type: Improvement
>    Affects Versions: 0.3.0
>            Reporter: Tommaso Teofili
>            Priority: Minor
>             Fix For: 0.4.0
>
>         Attachments: hama-447.patch
>
>
> Running code analysis tools (like Findbugs) there are lots of parts where our code could
be slightly improved, applying such small improvements could help us on better Hama performance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message