incubator-hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Jungblut (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HAMA-431) MapReduce NG integration
Date Tue, 18 Oct 2011 06:06:11 GMT

    [ https://issues.apache.org/jira/browse/HAMA-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129522#comment-13129522
] 

Thomas Jungblut commented on HAMA-431:
--------------------------------------

Like already told in Talk, I can't think of a problem here.
Let's see the diff:

{noformat}
Index: core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java
===================================================================
--- core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java	(Revision 1182784)
+++ core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java	(Arbeitskopie)
@@ -59,9 +59,9 @@
 /**
  * This class represents a BSP peer.
  */
-public class BSPPeer implements Watcher, BSPPeerInterface {
+public class BSPPeerImpl implements Watcher, BSPPeer {
 
-  public static final Log LOG = LogFactory.getLog(BSPPeer.class);
+  public static final Log LOG = LogFactory.getLog(BSPPeerImpl.class);
 
   private final Configuration conf;
   private BSPJob jobConf;
@@ -73,7 +73,7 @@
   private final String bspRoot;
   private final String quorumServers;
 
-  private final Map<InetSocketAddress, BSPPeerInterface> peers = new ConcurrentHashMap<InetSocketAddress,
BSPPeerInterface>();
+  private final Map<InetSocketAddress, BSPPeer> peers = new ConcurrentHashMap<InetSocketAddress,
BSPPeer>();
   private final Map<InetSocketAddress, ConcurrentLinkedQueue<BSPMessage>> outgoingQueues
= new ConcurrentHashMap<InetSocketAddress, ConcurrentLinkedQueue<BSPMessage>>();
   private ConcurrentLinkedQueue<BSPMessage> localQueue = new ConcurrentLinkedQueue<BSPMessage>();
   private ConcurrentLinkedQueue<BSPMessage> localQueueForNextIteration = new ConcurrentLinkedQueue<BSPMessage>();
@@ -192,7 +192,7 @@
   /**
    * Protected default constructor for LocalBSPRunner.
    */
-  protected BSPPeer() {
+  protected BSPPeerImpl() {
     bspRoot = null;
     quorumServers = null;
     messageSerializer = null;
@@ -208,7 +208,7 @@
    * @param umbilical is the bsp protocol used to contact its parent process.
    * @param taskid is the id that current process holds.
    */
-  public BSPPeer(Configuration conf, TaskAttemptID taskid,
+  public BSPPeerImpl(Configuration conf, TaskAttemptID taskid,
       BSPPeerProtocol umbilical) throws IOException {
     this.conf = conf;
     this.taskid = taskid;
@@ -312,7 +312,7 @@
       Entry<InetSocketAddress, ConcurrentLinkedQueue<BSPMessage>> entry = it
           .next();
 
-      BSPPeerInterface peer = peers.get(entry.getKey());
+      BSPPeer peer = peers.get(entry.getKey());
       if (peer == null) {
         try {
           peer = getBSPPeerConnection(entry.getKey());
@@ -587,19 +587,19 @@
 
   @Override
   public long getProtocolVersion(String arg0, long arg1) throws IOException {
-    return BSPPeerInterface.versionID;
+    return BSPPeer.versionID;
   }
 
-  protected BSPPeerInterface getBSPPeerConnection(InetSocketAddress addr)
+  protected BSPPeer getBSPPeerConnection(InetSocketAddress addr)
       throws NullPointerException, IOException {
-    BSPPeerInterface peer;
+    BSPPeer peer;
     synchronized (this.peers) {
       peer = peers.get(addr);
 
       int retries = 0;
       while (peer != null) {
-        peer = (BSPPeerInterface) RPC.getProxy(BSPPeerInterface.class,
-            BSPPeerInterface.versionID, addr, this.conf);
+        peer = (BSPPeer) RPC.getProxy(BSPPeer.class,
+            BSPPeer.versionID, addr, this.conf);
 
         retries++;
         if (retries > 10) {
{noformat}

As you can see, this is just a simple renaming action.
                
> MapReduce NG integration
> ------------------------
>
>                 Key: HAMA-431
>                 URL: https://issues.apache.org/jira/browse/HAMA-431
>             Project: Hama
>          Issue Type: New Feature
>            Reporter: Thomas Jungblut
>            Assignee: Thomas Jungblut
>         Attachments: WelcomeOnYarn.png, YARN_trunk_integration.patch, YARN_trunk_integration_v2.patch,
YARN_trunk_integration_v3.patch, job_state.dot, task_phase.dot, task_state.dot
>
>
> We should take a look at how to integrate Hama's BSP Engine to Hadoop's nextGen application
platform.
> Can be currently found in the 0.23 branch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message