incubator-hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Jungblut (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HAMA-410) Support configurable task slot
Date Tue, 05 Jul 2011 05:29:21 GMT

    [ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059681#comment-13059681
] 

Thomas Jungblut commented on HAMA-410:
--------------------------------------

np.

What do you think about refactoring the BSP class a bit?

I thought about that:

{noformat}
public abstract class BSP {

  public void setup(BSPPeer bspPeer) throws IOException, InterruptedException {

  }

  public abstract void bsp(BSPPeer bspPeer) throws IOException,
      KeeperException, InterruptedException;

  public void cleanup(BSPPeer bspPeer) throws IOException, InterruptedException {

  }

}

{noformat}

I think this is much more readable and better for the user. The first time I had to override
setConfiguration I didn't know when it get's really called.
The naming now says that we first call setup, then BSP and afterwards cleanup.
The configuration can now be obtained by the bspPeer, which is now our "context" object similar
to Hadoop M/R.

> Support configurable task slot
> ------------------------------
>
>                 Key: HAMA-410
>                 URL: https://issues.apache.org/jira/browse/HAMA-410
>             Project: Hama
>          Issue Type: New Feature
>          Components: bsp
>    Affects Versions: 0.3.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.4.0
>
>         Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch
>
>   Original Estimate: 168h
>          Time Spent: 24h
>  Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message