incubator-hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward J. Yoon" <edwardy...@apache.org>
Subject Fwd: report and doReport methods.
Date Fri, 25 Feb 2011 06:57:53 GMT
---------- Forwarded message ----------
From: Chia-Hung Lin <clin4j@googlemail.com>
Date: Fri, Feb 25, 2011 at 1:30 AM
Subject: Re: report and doReport methods.
To: "Edward J. Yoon" <edwardyoon@apache.org>


Hi Edward,

Sorry replying late, I am busy recently.

The doReport() function looks good because it fixes the previous issue
that the function only reports once at the end of job execution. Now
we have progress about the task status and we can check it when
necessary.

One minor comment. I notice that TaskStatus.java has `superstepCount'
as the global variable. Seemingly there are chances that the
modification for that variable would cause lost update case in
multi-threads environment; using AtomicLong seems would prevent such
issue.

Thanks for help improving doReport fucntion.

Sincerely,
ChiaHung

2011/2/21 Edward J. Yoon <edwardyoon@apache.org>:
> Hi lin,
>
> I made some changes on reporting function between master and workers.
> If you can review or have some comments, Pls feel free to feedback to
> me. :)
>
> Thanks.
>
> --
> Best Regards, Edward J. Yoon
> http://blog.udanax.org
> http://twitter.com/eddieyoon
>



--
ChiaHung Lin @ nuk, tw.



-- 
Best Regards, Edward J. Yoon
http://blog.udanax.org
http://twitter.com/eddieyoon

Mime
View raw message