Mailing-List: contact hama-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hama-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of clin4j@googlemail.com
 designates 209.85.216.47 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=nyt+yAwk/6FcgLauHcz3/tbzTPxxAGd+G2/q6MPHGe0Kn7+EdswsYLjLe+foDj8Kfs
         yAwq7p9gfv7P5SnWVKVdMpjBnXjUvYTCLECYCklx0KKlHuLwb1gXD6hP+dq5C40TsqhJ
         YXjwRi8vZiT+qcNMK5zDE1NSuvk6/r9ZSMES4=
MIME-Version: 1.0
In-Reply-To: <AANLkTikViRNL7+JSyaP=NSv8xjxbv-EH1qUh8HMMkGDf@mail.gmail.com>
References: <AANLkTikc+B_2+tSp_a67oUOdycOEF-F=uRjuhOg+Cnmx@mail.gmail.com>
	<AANLkTimkEugqEB2+JTVf8BV_n0vBpCSO9y-dhoTVPC=+@mail.gmail.com>
	<92C1387F-F4BC-4C75-B86A-E307E4774ED6@udanax.org>
	<AANLkTim5G5imkgDm=j6E5eHOO7hfyP_k1ZrwjwufBPDJ@mail.gmail.com>
	<AANLkTingDwTyjaARHuY6=PuS+_qqtz-c0Q_Oh-pcNdEO@mail.gmail.com>
	<AANLkTik-JAWZDfV2RW40jJA85wNYWbGU=KJ39SpeGAK4@mail.gmail.com>
	<AANLkTikViRNL7+JSyaP=NSv8xjxbv-EH1qUh8HMMkGDf@mail.gmail.com>
Date: Wed, 26 Jan 2011 03:56:35 +0800
Message-ID: <AANLkTikEtPSYKX36dWaKqfjZDmqnUDyYg=T_Zyj+v0K9@mail.gmail.com>
Subject: Re: Fail to communicate with BSPMaster for reporting.
From: Chia-Hung Lin <clin4j@googlemail.com>
To: hama-dev@incubator.apache.org
Content-Type: text/plain; charset=EUC-KR
Content-Transfer-Encoding: quoted-printable

I add a few lines regarding to the coding style currently I discover
so far, but other convention may require more discussion if needed.
Please correct me and help me add new one for that section as
appropriate.

Thanks.

2011/1/24 Edward J. Yoon <edwardyoon@apache.org>:
> Yup, pls feel free to open new wiki page on http://wiki.apache.org/hama
>
> Let's clarify our coding standards.
>
> 2011/1/24 Chia-Hung Lin <clin4j@googlemail.com>:
>> Is there any chance that this information can be described in HAMA
>> developer page? I went through the website and checked Apache
>> Contributor Documentation, but seems there is no mention about such
>> convention (maybe I miss it somewhere else). So I make use of coding
>> style referred to at
>> http://www.kernel.org/doc/Documentation/CodingStyle for local
>> variables.
>>
>> I will prevent this next time.
>>
>> Thanks for the advice.
>>
>> 2011/1/21 Edward J. Yoon <edwardyoon@apache.org>:
>>> Great!
>>>
>>> And here's my one comment for you about instance/reference variables
>>> naming. I think, they should say at least something about the object.
>>> For example,
>>>
>>>>> GroomServerStatus gss;
>>>
>>> The "groomServerStatus" is much better and more readable than "gss" in
>>> my opinion. :)
>>>
>>> 2011/1/21 Chia-Hung Lin <clin4j@googlemail.com>:
>>>> I've updated HAMA 346 with a patch that should fix the null value
>>>> returned by whichJob().
>>>>
>>>> 2011/1/21 Edward J. Yoon <edward@udanax.org>:
>>>>> Thanks!
>>>>>
>>>>> =B3=AA=C0=C7 iPhone=BF=A1=BC=AD =BA=B8=B3=BF
>>>>>
>>>>> 2011. 1. 20. =BF=C0=C8=C4 11:06 Chia-Hung Lin <clin4j@googlemail.com>=
 =C0=DB=BC=BA:
>>>>>
>>>>>> I check out  source from svn with the revision r1058109 and this iss=
ue
>>>>>> also happens on my testing machines.
>>>>>>
>>>>>> It looks like the completion of task status is not consistent betwee=
n
>>>>>> GroomServers and BSPMaster. For insatnce, GroomServers report Tasks
>>>>>> but JobInProgress consider tasks already been completed. But the
>>>>>> detail may require more examine I will fix this as soon as possible.
>>>>>>
>>>>>> 2011/1/19 Edward J. Yoon <edwardyoon@apache.org>:
>>>>>>> Today, I noticed that there was a bug in the patch of HAMA-346.
>>>>>>>
>>>>>>> After first job execution completed, the BSPMaster.whichJob() retur=
ns
>>>>>>> null. So the BSP system always throws error message "Fail to
>>>>>>> communicate with BSPMaster for reporting.".
>>>>>>>
>>>>>>> Simply, I'll add this code : "if (jip !=3D null) { }".
>>>>>>>
>>>>>>> What do you think?
>>>>>>>
>>>>>>> --
>>>>>>> Best Regards, Edward J. Yoon
>>>>>>> http://blog.udanax.org
>>>>>>> http://twitter.com/eddieyoon
>>>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Best Regards, Edward J. Yoon
>>> http://blog.udanax.org
>>> http://twitter.com/eddieyoon
>>>
>>
>
>
>
> --
> Best Regards, Edward J. Yoon
> http://blog.udanax.org
> http://twitter.com/eddieyoon
>