incubator-hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward J. Yoon" <edwardy...@apache.org>
Subject Re: [jira] Commented: (HAMA-321) Replace the value of "bsp.peers.num" in enterBarrier() method
Date Tue, 09 Nov 2010 12:21:55 GMT
Could anyone please review this patch?

On Tue, Nov 9, 2010 at 6:39 PM, Hudson (JIRA) <jira@apache.org> wrote:
>
>    [ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930029#action_12930029
]
>
> Hudson commented on HAMA-321:
> -----------------------------
>
> +1 overall.  Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12459148/HAMA-321_v03.patch
> against trunk revision 1032884.
>
>    @author +1.  The patch does not contain any @author tags.
>
>    tests included +1.  The patch appears to include 3 new or modified tests.
>
>    javadoc +1.  The javadoc tool did not generate any warning messages.
>
>    javac +1.  The applied patch does not generate any new javac compiler warnings.
>
>    release audit +1.  The applied patch does not generate any new release audit warnings.
>
>    findbugs +1.  The patch does not introduce any new Findbugs warnings.
>
>    core tests +1.  The patch passed core unit tests.
>
> Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/290/testReport/
> Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/290/findbugsResult/
> Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/290/artifact/trunk/build/test/checkstyle-errors.html
> Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/290/console
>
> This message is automatically generated.
>
>> Replace the value of "bsp.peers.num" in enterBarrier() method
>> -------------------------------------------------------------
>>
>>                 Key: HAMA-321
>>                 URL: https://issues.apache.org/jira/browse/HAMA-321
>>             Project: Hama
>>          Issue Type: Bug
>>          Components: bsp
>>    Affects Versions: 0.2.0
>>            Reporter: Edward J. Yoon
>>            Assignee: Edward J. Yoon
>>            Priority: Critical
>>             Fix For: 0.2.0
>>
>>         Attachments: HAMA-321.patch, HAMA-321_v02.patch, HAMA-321_v03.patch
>>
>>
>> Each groomserver handles one instance of BSPPeer.
>> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>



-- 
Best Regards, Edward J. Yoon
edwardyoon@apache.org
http://blog.udanax.org

Mime
View raw message