incubator-hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filipe Manana (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HAMA-316) Renaming and Refactoring methods in BSPPeerInterface
Date Thu, 21 Oct 2010 23:29:15 GMT

     [ https://issues.apache.org/jira/browse/HAMA-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Filipe Manana updated HAMA-316:
-------------------------------

    Attachment: hama-316.patch

So, here's the patch.
BSPPeerInterface (and BSPPeer) got simplified and cleaned up:

1) InetSocketAddress is no longer necessary. To send a message to other Peer, a Peer uses
the other Peer's name (a String);

2) getHostName() got renamed to getPeerName()

3) getAllPeers() renamed to getAllPeerNames(). Also, it returns now a Set<String> instead
of a Map<String, String> - the Peer doesn't need to, and neither it should, know the
name of the groom servers (even if now the groom server bsp Peer relation is just 1 to 1).

4) added getNumCurrentMessages()

I didn't had a getNumPeers() since the same result can be obtained with getAllPeerNames().size()
- unnecessary to extended the API just for this (imho).

Also, ClusterStatus, now uses a Map<String, String> for the list of groom servers. Keys
are groom server names, values are the Peer names. When we support multiple Peers per Groom
server (that is, multiple task slots) the Map should possibly be changed to Map<String,
List<String>> or something similar. We'll deal with it when the time comes, what
do you think?

Updated the examples PiEstimator and HelloBSP as well as some of the tests.
Also removed GroomServer.getServerName() since it was not used anywhere.

feedback please
cheers

> Renaming and Refactoring methods in BSPPeerInterface
> ----------------------------------------------------
>
>                 Key: HAMA-316
>                 URL: https://issues.apache.org/jira/browse/HAMA-316
>             Project: Hama
>          Issue Type: Improvement
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Filipe Manana
>             Fix For: 0.2.0
>
>         Attachments: hama-316.patch
>
>
> The getAddress() and getHostName() are somewhat odd to me. WDYT?
> And, It would be nice if we could get the number of BSP peers and BSP messages.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message