incubator-hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filipe Manana (JIRA)" <j...@apache.org>
Subject [jira] Created: (HAMA-305) Redundant use of synchronize keyword
Date Mon, 11 Oct 2010 18:07:33 GMT
Redundant use of synchronize keyword
------------------------------------

                 Key: HAMA-305
                 URL: https://issues.apache.org/jira/browse/HAMA-305
             Project: Hama
          Issue Type: Bug
            Reporter: Filipe Manana
         Attachments: hama-305.patch

In GroomServer.startNewTask(), we synchronize on the newly created TaskInProgress. This is
unnecessary since it's a method local variable. I believe the intention was to synchronize
on 'this' or on the collection runningTasks.

Also, when the task is launched, I believe it doesn't need to be inside the synchronized block.
The only field it accesses from the parent class is the configuration (conf).

Patch attached.
cheers



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message