incubator-hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filipe Manana (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HAMA-322) Make sure failed assertions on test threads are reported
Date Wed, 27 Oct 2010 20:57:21 GMT

     [ https://issues.apache.org/jira/browse/HAMA-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Filipe Manana updated HAMA-322:
-------------------------------

    Description: 
When running a JUnit test, like TestBSPPeer, if an assertion fails in some thread, it is not
reported in the console (only failed assertions of the main thread are reported). However
the assertion failed exception is logged in the test report under build/report/tests/.
Example:

$ ant test
jar:file:/home/fdmanana/git/apache/hama/lib/findbugs/ant.jar!/org/apache/tools/ant/Project.class
   [junit] Running org.apache.hama.bsp.TestBSPPeer
   [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 13.941 sec


$ cat build/reports/tests/TEST-org.apache.hama.bsp.TestBSPPeer.txt
....
2010-10-27 12:54:09,361 ERROR [Thread-97]
server.NIOServerCnxn$Factory$1(81): Thread Thread[Thread-97,5,main]
died
junit.framework.AssertionFailedError: expected:<20> but was:<1>
       at junit.framework.Assert.fail(Assert.java:47)
       at junit.framework.Assert.failNotEquals(Assert.java:282)
       at junit.framework.Assert.assertEquals(Assert.java:64)
       at junit.framework.Assert.assertEquals(Assert.java:201)
       at junit.framework.Assert.assertEquals(Assert.java:207)
       at org.apache.hama.bsp.TestBSPPeer$BSPPeerThread.run(TestBSPPeer.java:131)
2010-10-27 12:54:09,362 ERROR [Thread-81]
server.NIOServerCnxn$Factory$1(81): Thread Thread[Thread-81,5,main]
died
junit.framework.AssertionFailedError: expected:<20> but was:<1>
       at junit.framework.Assert.fail(Assert.java:47)
       at junit.framework.Assert.failNotEquals(Assert.java:282)
       at junit.framework.Assert.assertEquals(Assert.java:64)
       at junit.framework.Assert.assertEquals(Assert.java:201)
       at junit.framework.Assert.assertEquals(Assert.java:207)
       at org.apache.hama.bsp.TestBSPPeer$BSPPeerThread.run(TestBSPPeer.java:131)
....

We should probably use something like GroboTestingJUnit:  http://today.java.net/pub/a/today/2003/08/06/multithreadedTests.html

  was:
When running a JUnit test, like TestBSPPeer, if an assertion fails in some thread, it is not
reported in the console. However the assertion failed expeption is logged in the test report
under build/report/tests/.
Example:

$ ant test
jar:file:/home/fdmanana/git/apache/hama/lib/findbugs/ant.jar!/org/apache/tools/ant/Project.class
   [junit] Running org.apache.hama.bsp.TestBSPPeer
   [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 13.941 sec


$ cat build/reports/tests/TEST-org.apache.hama.bsp.TestBSPPeer.txt
....
2010-10-27 12:54:09,361 ERROR [Thread-97]
server.NIOServerCnxn$Factory$1(81): Thread Thread[Thread-97,5,main]
died
junit.framework.AssertionFailedError: expected:<20> but was:<1>
       at junit.framework.Assert.fail(Assert.java:47)
       at junit.framework.Assert.failNotEquals(Assert.java:282)
       at junit.framework.Assert.assertEquals(Assert.java:64)
       at junit.framework.Assert.assertEquals(Assert.java:201)
       at junit.framework.Assert.assertEquals(Assert.java:207)
       at org.apache.hama.bsp.TestBSPPeer$BSPPeerThread.run(TestBSPPeer.java:131)
2010-10-27 12:54:09,362 ERROR [Thread-81]
server.NIOServerCnxn$Factory$1(81): Thread Thread[Thread-81,5,main]
died
junit.framework.AssertionFailedError: expected:<20> but was:<1>
       at junit.framework.Assert.fail(Assert.java:47)
       at junit.framework.Assert.failNotEquals(Assert.java:282)
       at junit.framework.Assert.assertEquals(Assert.java:64)
       at junit.framework.Assert.assertEquals(Assert.java:201)
       at junit.framework.Assert.assertEquals(Assert.java:207)
       at org.apache.hama.bsp.TestBSPPeer$BSPPeerThread.run(TestBSPPeer.java:131)
....

We should probably use something like GroboTestingJUnit:  http://today.java.net/pub/a/today/2003/08/06/multithreadedTests.html


> Make sure failed assertions on test threads are reported
> --------------------------------------------------------
>
>                 Key: HAMA-322
>                 URL: https://issues.apache.org/jira/browse/HAMA-322
>             Project: Hama
>          Issue Type: Bug
>          Components: test 
>    Affects Versions: 0.2.1
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>
> When running a JUnit test, like TestBSPPeer, if an assertion fails in some thread, it
is not reported in the console (only failed assertions of the main thread are reported). However
the assertion failed exception is logged in the test report under build/report/tests/.
> Example:
> $ ant test
> jar:file:/home/fdmanana/git/apache/hama/lib/findbugs/ant.jar!/org/apache/tools/ant/Project.class
>    [junit] Running org.apache.hama.bsp.TestBSPPeer
>    [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 13.941 sec
> $ cat build/reports/tests/TEST-org.apache.hama.bsp.TestBSPPeer.txt
> ....
> 2010-10-27 12:54:09,361 ERROR [Thread-97]
> server.NIOServerCnxn$Factory$1(81): Thread Thread[Thread-97,5,main]
> died
> junit.framework.AssertionFailedError: expected:<20> but was:<1>
>        at junit.framework.Assert.fail(Assert.java:47)
>        at junit.framework.Assert.failNotEquals(Assert.java:282)
>        at junit.framework.Assert.assertEquals(Assert.java:64)
>        at junit.framework.Assert.assertEquals(Assert.java:201)
>        at junit.framework.Assert.assertEquals(Assert.java:207)
>        at org.apache.hama.bsp.TestBSPPeer$BSPPeerThread.run(TestBSPPeer.java:131)
> 2010-10-27 12:54:09,362 ERROR [Thread-81]
> server.NIOServerCnxn$Factory$1(81): Thread Thread[Thread-81,5,main]
> died
> junit.framework.AssertionFailedError: expected:<20> but was:<1>
>        at junit.framework.Assert.fail(Assert.java:47)
>        at junit.framework.Assert.failNotEquals(Assert.java:282)
>        at junit.framework.Assert.assertEquals(Assert.java:64)
>        at junit.framework.Assert.assertEquals(Assert.java:201)
>        at junit.framework.Assert.assertEquals(Assert.java:207)
>        at org.apache.hama.bsp.TestBSPPeer$BSPPeerThread.run(TestBSPPeer.java:131)
> ....
> We should probably use something like GroboTestingJUnit:  http://today.java.net/pub/a/today/2003/08/06/multithreadedTests.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message