Mailing-List: contact hama-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hama-dev@incubator.apache.org
Message-ID: <8822526.1151282809893161.JavaMail.jira@thor>
Date: Thu, 26 Aug 2010 04:04:53 -0400 (EDT)
From: "Edward J. Yoon (JIRA)" <jira@apache.org>
To: hama-dev@incubator.apache.org
Subject: [jira] Updated: (HAMA-284) Removing hard coded argument for
 heartbeat() method
In-Reply-To: <62078.941282808753941.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HAMA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-284:
--------------------------------

    Description: 
The 'acceptNewTasks' argument is hard coded as a true.

{code}
    // TODO - Later, acceptNewTask is to be set by the status of groom server.
    HeartbeatResponse heartbeatResponse = jobClient.heartbeat(status,
        justStarted, justInited, true, heartbeatResponseId); // here
{code}

It should be changed to acceptNewTasks. And if slaves (GroomServer) are unable to accept tasks, the acceptNewTasks should be changed to false.

  was:
The 'acceptNewTasks' argument is hard coded as a true.

{code}
  boolean acceptNewTasks = true;
  ....

    // TODO - Later, acceptNewTask is to be set by the status of groom server.
    HeartbeatResponse heartbeatResponse = jobClient.heartbeat(status,
        justStarted, justInited, true, heartbeatResponseId);
{code}

It should be changed to acceptNewTasks. And if slaves (GroomServer) are unable to accept tasks, the acceptNewTasks should be changed to false.


> Removing hard coded argument for heartbeat() method
> ---------------------------------------------------
>
>                 Key: HAMA-284
>                 URL: https://issues.apache.org/jira/browse/HAMA-284
>             Project: Hama
>          Issue Type: Sub-task
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>             Fix For: 0.2.0
>
>
> The 'acceptNewTasks' argument is hard coded as a true.
> {code}
>     // TODO - Later, acceptNewTask is to be set by the status of groom server.
>     HeartbeatResponse heartbeatResponse = jobClient.heartbeat(status,
>         justStarted, justInited, true, heartbeatResponseId); // here
> {code}
> It should be changed to acceptNewTasks. And if slaves (GroomServer) are unable to accept tasks, the acceptNewTasks should be changed to false.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.