incubator-hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filipe Manana (JIRA)" <j...@apache.org>
Subject [jira] Created: (HAMA-283) Duplicate code regarding default configuration files for Hama
Date Tue, 24 Aug 2010 17:32:18 GMT
Duplicate code regarding default configuration files for Hama
-------------------------------------------------------------

                 Key: HAMA-283
                 URL: https://issues.apache.org/jira/browse/HAMA-283
             Project: Hama
          Issue Type: Question
            Reporter: Filipe Manana
            Priority: Trivial


While doing my first Hama code walks, I noticed the exact same static block initializer in
the classes BSPMaster, GroomServer and BSPJobContext:

static {
    Configuration.addDefaultResource("hama-default.xml");
    Configuration.addDefaultResource("hama-site.xml");
}

However, in the org.apache.hama.HamaConfiguration  class the constructor calls the following
method:

private void addHamaResources() {
    Configuration.addDefaultResource("hama-default.xml");
    Configuration.addDefaultResource("hama-site.xml");
  }

Correct me if I'm wrong, but this does exactly the same, right?

With the following patch, which removes the static initializers, all the tests are passing.

cheers



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message