Return-Path: Delivered-To: apmail-incubator-hama-dev-archive@minotaur.apache.org Received: (qmail 56001 invoked from network); 12 May 2009 05:14:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 May 2009 05:14:08 -0000 Received: (qmail 26742 invoked by uid 500); 12 May 2009 05:14:08 -0000 Delivered-To: apmail-incubator-hama-dev-archive@incubator.apache.org Received: (qmail 26701 invoked by uid 500); 12 May 2009 05:14:07 -0000 Mailing-List: contact hama-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hama-dev@incubator.apache.org Delivered-To: mailing list hama-dev@incubator.apache.org Received: (qmail 26690 invoked by uid 99); 12 May 2009 05:14:07 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 May 2009 05:14:07 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 May 2009 05:14:05 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 9BF2E234C041 for ; Mon, 11 May 2009 22:13:45 -0700 (PDT) Message-ID: <2054775310.1242105225637.JavaMail.jira@brutus> Date: Mon, 11 May 2009 22:13:45 -0700 (PDT) From: "Hudson (JIRA)" To: hama-dev@incubator.apache.org Subject: [jira] Commented: (HAMA-183) When we construct the matrix, dimensions should be defined. In-Reply-To: <1349991093.1242051585950.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HAMA-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708322#action_12708322 ] Hudson commented on HAMA-183: ----------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12407842/HAMA-183.patch against trunk revision 773593. @author +1. The patch does not contain any @author tags. tests included +1. The patch appears to include 12 new or modified tests. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/174/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/174/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/174/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/174/console This message is automatically generated. > When we construct the matrix, dimensions should be defined. > ----------------------------------------------------------- > > Key: HAMA-183 > URL: https://issues.apache.org/jira/browse/HAMA-183 > Project: Hama > Issue Type: Bug > Components: implementation > Affects Versions: 0.1.0 > Reporter: Edward J. Yoon > Fix For: 0.1.0 > > Attachments: HAMA-183.patch > > > "DenseMatrix a = new DenseMatrix(conf);" is odd to me. IMO, dimensions should be defined by constructor as "DenseMatrix a = new DenseMatrix(conf, 10, 10);" and, the values can't be set to out of range. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.