Mailing-List: contact hama-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hama-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of bluesvm@gmail.com designates
 209.85.200.174 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:references;
        b=nM/dK2nchR/CX5cT6D7CPBq4j9FLnXZKsuk7tx1PqHENA8VftILrMghZCEpWSUE+zJ
         A7LxVZoHFMVfFGCXAQ2wBHtNt8A6NP73H1+QjMe/irdeliZkLMixCnQYG07VeKshkSn/
         ysmVrGGLxZFgD5pD7u0Gkk47ZO99X3Dv5y6ic=
Message-ID: <7ada1c10808212015h2f3a300ag739e708d44cf8bf3@mail.gmail.com>
Date: Fri, 22 Aug 2008 12:15:20 +0900
From: "Antonio Suh" <bluesvm@gmail.com>
To: hama-dev@incubator.apache.org
Subject: Re: Expected behaviour when things go wrong
In-Reply-To: <eb4706e0808211902v47029178x69131f5c01566381@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_36442_24286346.1219374920438"
References: <25ff69410808201628w73927f52l7fd37fbcf8929bab@mail.gmail.com>
	 <eb4706e0808210056k2fa82e9cid96e96e6fbaeb371@mail.gmail.com>
	 <25ff69410808210117w64b53208m9138acee3033d32a@mail.gmail.com>
	 <21dc670c0808210749q29998d4do453225eb2d0dceee@mail.gmail.com>
	 <7ada1c10808210815ifa0289ft3bff89418dd9392e@mail.gmail.com>
	 <eb4706e0808210817s5d230206gc1894c0756c25d8@mail.gmail.com>
	 <7ada1c10808210825u4c430bf4s2ee6152a70f45192@mail.gmail.com>
	 <25ff69410808210837n47754fdck3ef13c7b5de469ec@mail.gmail.com>
	 <21dc670c0808211850n44263717qe02b55e39fea5600@mail.gmail.com>
	 <eb4706e0808211902v47029178x69131f5c01566381@mail.gmail.com>

------=_Part_36442_24286346.1219374920438
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

+1.


2008/8/22 Edward J. Yoon <edwardyoon@apache.org>

> Oh.. This is good idea. +1
>
> On Fri, Aug 22, 2008 at 10:50 AM, joosun yoon <ologist0@gmail.com> wrote:
> > I'm fine both of ComputationException and OperationException!
> > But, I have reviewed methods in class AbstractMatrix.
> >
> > The present, it has been coded "IOException". Exception's mean is that
> > hbase's I/O has failed.
> > So, I think to rename "IOException" to "HbaseIOException" for high
> > expression.
> > Of cource, HbaseIOException class is  "RuntimeException must be
> extended".
> >
> > org.apache.hama.HbaseIOException, How do you think?
> >
> >
> > 2008/8/22, Chanwit Kaewkasi <chanwit@gmail.com>:
> >>
> >> Fine to me.
> >>
> >> Chanwit
> >>
> >> 2008/8/21 Antonio Suh <bluesvm@gmail.com>:
> >> > ComputationException and OperationException, both are good.
> >> >
> >> > Chanwit, How do you think?
> >> >
> >> >
> >> >
> >> > 2008/8/22 Edward J. Yoon <edwardyoon@apache.org>
> >> >
> >> >> How about OperationException instead of ComputationException?
> >> >>
> >> >> -Ed
> >> >>
> >> >> On Fri, Aug 22, 2008 at 12:15 AM, Antonio Suh <bluesvm@gmail.com>
> >> wrote:
> >> >> > +1 to "org.apache.hama.ComputationException" at the moment.
> >> >> >
> >> >> >
> >> >> >
> >> >> >
> >> >> > 2008/8/21 joosun yoon <ologist0@gmail.com>
> >> >> >
> >> >> >> The exception will be catch to call only logging, so
> RuntimeException
> >> is
> >> >> >> better.
> >> >> >>
> >> >> >> I'm +1 "org.apache.hama.ComputationException"
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >> 2008/8/21, Chanwit Kaewkasi <chanwit@gmail.com>:
> >> >> >> >
> >> >> >> > So let's decide a name of the exception.
> >> >> >> >
> >> >> >> > How do you think to name it org.apache.hama.ComputationException
> at
> >> >> the
> >> >> >> > moment?
> >> >> >> >
> >> >> >> > Chanwit
> >> >> >> >
> >> >> >> > 2008/8/21 Edward J. Yoon <edwardyoon@apache.org>:
> >> >> >> > > But, I'm +1 for the no. 1 plan.
> >> >> >> > >
> >> >> >> > > -Ed
> >> >> >> > >
> >> >> >> > > On Thu, Aug 21, 2008 at 4:48 PM, Edward J. Yoon <
> >> >> edwardyoon@apache.org
> >> >> >> >
> >> >> >> > wrote:
> >> >> >> > >> Oh, Good point,
> >> >> >> > >>
> >> >> >> > >>>> the exception will be catch to call only LOG.error.
> >> >> >> > >>
> >> >> >> > >> Yes, it should be throwing an runtime exception and stop
> >> >> processing.
> >> >> >> > >>
> >> >> >> > >> -Ed
> >> >> >> > >>
> >> >> >> > >> On Thu, Aug 21, 2008 at 8:28 AM, Chanwit Kaewkasi <
> >> >> chanwit@gmail.com>
> >> >> >> > wrote:
> >> >> >> > >>> Hello,
> >> >> >> > >>>
> >> >> >> > >>> In class AbstractMatrix, the exception will be catch to call
> >> only
> >> >> >> > LOG.error.
> >> >> >> > >>> I would like to discuss a bit more on this issue that how
> the
> >> >> system
> >> >> >> > >>> should do when an exception is thrown.
> >> >> >> > >>> But I don't think only logging an error is not enough.
> >> >> >> > >>>
> >> >> >> > >>> 1. re-throw the exception. This needs changes of the
> interface,
> >> >> >> > >>> probably we could have the new ComputationException class,
> or
> >> >> >> > >>> something.
> >> >> >> > >>> 2. throw a runtime expection, and of course JVM will die
> here.
> >> >> >> > >>>
> >> >> >> > >>> Regards,
> >> >> >> > >>>
> >> >> >> > >>> Chanwit
> >> >> >> > >>>
> >> >> >> > >>
> >> >> >> > >>
> >> >> >> > >>
> >> >> >> > >> --
> >> >> >> > >> Best regards, Edward J. Yoon
> >> >> >> > >> edwardyoon@apache.org
> >> >> >> > >> http://blog.udanax.org
> >> >> >> > >>
> >> >> >> > >
> >> >> >> > >
> >> >> >> > >
> >> >> >> > > --
> >> >> >> > > Best regards, Edward J. Yoon
> >> >> >> > > edwardyoon@apache.org
> >> >> >> > > http://blog.udanax.org
> >> >> >> > >
> >> >> >> >
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >> --
> >> >> >> Yoon Joo Sun
> >> >> >> Java Developer Engineer
> >> >> >> Blog - http://www.ologist.co.kr
> >> >> >>
> >> >> >
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Best regards, Edward J. Yoon
> >> >> edwardyoon@apache.org
> >> >> http://blog.udanax.org
> >> >>
> >> >
> >>
> >
> >
> >
> > --
> > Yoon Joo Sun
> > Java Developer Engineer
> > Blog - http://www.ologist.co.kr
> >
>
>
>
> --
>  Best regards, Edward J. Yoon
> edwardyoon@apache.org
> http://blog.udanax.org
>

------=_Part_36442_24286346.1219374920438--