Return-Path: Delivered-To: apmail-incubator-hama-dev-archive@locus.apache.org Received: (qmail 45119 invoked from network); 21 Aug 2008 15:38:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 Aug 2008 15:38:25 -0000 Received: (qmail 76879 invoked by uid 500); 21 Aug 2008 15:38:23 -0000 Delivered-To: apmail-incubator-hama-dev-archive@incubator.apache.org Received: (qmail 76837 invoked by uid 500); 21 Aug 2008 15:38:23 -0000 Mailing-List: contact hama-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hama-dev@incubator.apache.org Delivered-To: mailing list hama-dev@incubator.apache.org Received: (qmail 76826 invoked by uid 99); 21 Aug 2008 15:38:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Aug 2008 08:38:23 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of chanwit@gmail.com designates 209.85.217.14 as permitted sender) Received: from [209.85.217.14] (HELO mail-gx0-f14.google.com) (209.85.217.14) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Aug 2008 15:37:23 +0000 Received: by gxk7 with SMTP id 7so186219gxk.12 for ; Thu, 21 Aug 2008 08:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=g7gvosm/a7XfyTk/6sVvmqE2PJw83URoF++GfYqVv+Y=; b=fucIhBn0bsWLb3MJeRIadViWZXDoYlNbEkK8Xtl1nHixtuxEY6YJJDGwsYOroRwYoO Vg/sLV1IAj9i8gWhPgn8XJW4pczrYZ7y9uz7ALenlP8YoEFe+wbQKVqqbk+ttKM1lhg/ vwlAfyD8cM+HuXQOCjFZHkx5m94taNBAbjaEc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=HMOP49nw5sBHE9Gvwpi78xPcDZ12wHYq1eSAOOopWrdiCkbzB4nIrTzP291vv/539N koCwH0BEDW3gocwT+V9agvI/hCUbXbsV13iaLg6NqGsAsFOfXldJdSCoXTx/wtuRMHOH J4JEC+SzUSEjYDBzeQBMZR2u62mQvOdiTWERA= Received: by 10.151.42.20 with SMTP id u20mr2378989ybj.70.1219333071223; Thu, 21 Aug 2008 08:37:51 -0700 (PDT) Received: by 10.151.146.12 with HTTP; Thu, 21 Aug 2008 08:37:51 -0700 (PDT) Message-ID: <25ff69410808210837n47754fdck3ef13c7b5de469ec@mail.gmail.com> Date: Thu, 21 Aug 2008 22:37:51 +0700 From: "Chanwit Kaewkasi" To: hama-dev@incubator.apache.org Subject: Re: Expected behaviour when things go wrong In-Reply-To: <7ada1c10808210825u4c430bf4s2ee6152a70f45192@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <25ff69410808201628w73927f52l7fd37fbcf8929bab@mail.gmail.com> <25ff69410808210117w64b53208m9138acee3033d32a@mail.gmail.com> <21dc670c0808210749q29998d4do453225eb2d0dceee@mail.gmail.com> <7ada1c10808210815ifa0289ft3bff89418dd9392e@mail.gmail.com> <7ada1c10808210825u4c430bf4s2ee6152a70f45192@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org Fine to me. Chanwit 2008/8/21 Antonio Suh : > ComputationException and OperationException, both are good. > > Chanwit, How do you think? > > > > 2008/8/22 Edward J. Yoon > >> How about OperationException instead of ComputationException? >> >> -Ed >> >> On Fri, Aug 22, 2008 at 12:15 AM, Antonio Suh wrote: >> > +1 to "org.apache.hama.ComputationException" at the moment. >> > >> > >> > >> > >> > 2008/8/21 joosun yoon >> > >> >> The exception will be catch to call only logging, so RuntimeException is >> >> better. >> >> >> >> I'm +1 "org.apache.hama.ComputationException" >> >> >> >> >> >> >> >> >> >> 2008/8/21, Chanwit Kaewkasi : >> >> > >> >> > So let's decide a name of the exception. >> >> > >> >> > How do you think to name it org.apache.hama.ComputationException at >> the >> >> > moment? >> >> > >> >> > Chanwit >> >> > >> >> > 2008/8/21 Edward J. Yoon : >> >> > > But, I'm +1 for the no. 1 plan. >> >> > > >> >> > > -Ed >> >> > > >> >> > > On Thu, Aug 21, 2008 at 4:48 PM, Edward J. Yoon < >> edwardyoon@apache.org >> >> > >> >> > wrote: >> >> > >> Oh, Good point, >> >> > >> >> >> > >>>> the exception will be catch to call only LOG.error. >> >> > >> >> >> > >> Yes, it should be throwing an runtime exception and stop >> processing. >> >> > >> >> >> > >> -Ed >> >> > >> >> >> > >> On Thu, Aug 21, 2008 at 8:28 AM, Chanwit Kaewkasi < >> chanwit@gmail.com> >> >> > wrote: >> >> > >>> Hello, >> >> > >>> >> >> > >>> In class AbstractMatrix, the exception will be catch to call only >> >> > LOG.error. >> >> > >>> I would like to discuss a bit more on this issue that how the >> system >> >> > >>> should do when an exception is thrown. >> >> > >>> But I don't think only logging an error is not enough. >> >> > >>> >> >> > >>> 1. re-throw the exception. This needs changes of the interface, >> >> > >>> probably we could have the new ComputationException class, or >> >> > >>> something. >> >> > >>> 2. throw a runtime expection, and of course JVM will die here. >> >> > >>> >> >> > >>> Regards, >> >> > >>> >> >> > >>> Chanwit >> >> > >>> >> >> > >> >> >> > >> >> >> > >> >> >> > >> -- >> >> > >> Best regards, Edward J. Yoon >> >> > >> edwardyoon@apache.org >> >> > >> http://blog.udanax.org >> >> > >> >> >> > > >> >> > > >> >> > > >> >> > > -- >> >> > > Best regards, Edward J. Yoon >> >> > > edwardyoon@apache.org >> >> > > http://blog.udanax.org >> >> > > >> >> > >> >> >> >> >> >> >> >> -- >> >> Yoon Joo Sun >> >> Java Developer Engineer >> >> Blog - http://www.ologist.co.kr >> >> >> > >> >> >> >> -- >> Best regards, Edward J. Yoon >> edwardyoon@apache.org >> http://blog.udanax.org >> >