incubator-hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonio Suh" <blue...@gmail.com>
Subject Re: Expected behaviour when things go wrong
Date Fri, 22 Aug 2008 03:15:20 GMT
+1.



2008/8/22 Edward J. Yoon <edwardyoon@apache.org>

> Oh.. This is good idea. +1
>
> On Fri, Aug 22, 2008 at 10:50 AM, joosun yoon <ologist0@gmail.com> wrote:
> > I'm fine both of ComputationException and OperationException!
> > But, I have reviewed methods in class AbstractMatrix.
> >
> > The present, it has been coded "IOException". Exception's mean is that
> > hbase's I/O has failed.
> > So, I think to rename "IOException" to "HbaseIOException" for high
> > expression.
> > Of cource, HbaseIOException class is  "RuntimeException must be
> extended".
> >
> > org.apache.hama.HbaseIOException, How do you think?
> >
> >
> > 2008/8/22, Chanwit Kaewkasi <chanwit@gmail.com>:
> >>
> >> Fine to me.
> >>
> >> Chanwit
> >>
> >> 2008/8/21 Antonio Suh <bluesvm@gmail.com>:
> >> > ComputationException and OperationException, both are good.
> >> >
> >> > Chanwit, How do you think?
> >> >
> >> >
> >> >
> >> > 2008/8/22 Edward J. Yoon <edwardyoon@apache.org>
> >> >
> >> >> How about OperationException instead of ComputationException?
> >> >>
> >> >> -Ed
> >> >>
> >> >> On Fri, Aug 22, 2008 at 12:15 AM, Antonio Suh <bluesvm@gmail.com>
> >> wrote:
> >> >> > +1 to "org.apache.hama.ComputationException" at the moment.
> >> >> >
> >> >> >
> >> >> >
> >> >> >
> >> >> > 2008/8/21 joosun yoon <ologist0@gmail.com>
> >> >> >
> >> >> >> The exception will be catch to call only logging, so
> RuntimeException
> >> is
> >> >> >> better.
> >> >> >>
> >> >> >> I'm +1 "org.apache.hama.ComputationException"
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >> 2008/8/21, Chanwit Kaewkasi <chanwit@gmail.com>:
> >> >> >> >
> >> >> >> > So let's decide a name of the exception.
> >> >> >> >
> >> >> >> > How do you think to name it org.apache.hama.ComputationException
> at
> >> >> the
> >> >> >> > moment?
> >> >> >> >
> >> >> >> > Chanwit
> >> >> >> >
> >> >> >> > 2008/8/21 Edward J. Yoon <edwardyoon@apache.org>:
> >> >> >> > > But, I'm +1 for the no. 1 plan.
> >> >> >> > >
> >> >> >> > > -Ed
> >> >> >> > >
> >> >> >> > > On Thu, Aug 21, 2008 at 4:48 PM, Edward J. Yoon
<
> >> >> edwardyoon@apache.org
> >> >> >> >
> >> >> >> > wrote:
> >> >> >> > >> Oh, Good point,
> >> >> >> > >>
> >> >> >> > >>>> the exception will be catch to call
only LOG.error.
> >> >> >> > >>
> >> >> >> > >> Yes, it should be throwing an runtime exception
and stop
> >> >> processing.
> >> >> >> > >>
> >> >> >> > >> -Ed
> >> >> >> > >>
> >> >> >> > >> On Thu, Aug 21, 2008 at 8:28 AM, Chanwit Kaewkasi
<
> >> >> chanwit@gmail.com>
> >> >> >> > wrote:
> >> >> >> > >>> Hello,
> >> >> >> > >>>
> >> >> >> > >>> In class AbstractMatrix, the exception will
be catch to call
> >> only
> >> >> >> > LOG.error.
> >> >> >> > >>> I would like to discuss a bit more on this
issue that how
> the
> >> >> system
> >> >> >> > >>> should do when an exception is thrown.
> >> >> >> > >>> But I don't think only logging an error
is not enough.
> >> >> >> > >>>
> >> >> >> > >>> 1. re-throw the exception. This needs changes
of the
> interface,
> >> >> >> > >>> probably we could have the new ComputationException
class,
> or
> >> >> >> > >>> something.
> >> >> >> > >>> 2. throw a runtime expection, and of course
JVM will die
> here.
> >> >> >> > >>>
> >> >> >> > >>> Regards,
> >> >> >> > >>>
> >> >> >> > >>> Chanwit
> >> >> >> > >>>
> >> >> >> > >>
> >> >> >> > >>
> >> >> >> > >>
> >> >> >> > >> --
> >> >> >> > >> Best regards, Edward J. Yoon
> >> >> >> > >> edwardyoon@apache.org
> >> >> >> > >> http://blog.udanax.org
> >> >> >> > >>
> >> >> >> > >
> >> >> >> > >
> >> >> >> > >
> >> >> >> > > --
> >> >> >> > > Best regards, Edward J. Yoon
> >> >> >> > > edwardyoon@apache.org
> >> >> >> > > http://blog.udanax.org
> >> >> >> > >
> >> >> >> >
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >> --
> >> >> >> Yoon Joo Sun
> >> >> >> Java Developer Engineer
> >> >> >> Blog - http://www.ologist.co.kr
> >> >> >>
> >> >> >
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Best regards, Edward J. Yoon
> >> >> edwardyoon@apache.org
> >> >> http://blog.udanax.org
> >> >>
> >> >
> >>
> >
> >
> >
> > --
> > Yoon Joo Sun
> > Java Developer Engineer
> > Blog - http://www.ologist.co.kr
> >
>
>
>
> --
>  Best regards, Edward J. Yoon
> edwardyoon@apache.org
> http://blog.udanax.org
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message