incubator-hama-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "joosun yoon" <ologi...@gmail.com>
Subject Re: Interface re-thinking
Date Thu, 21 Aug 2008 14:42:10 GMT
Chanwit's idea is good, I will review JDT, too.

2008/8/21, Antonio Suh <bluesvm@gmail.com>:
>
> +1 to joosun's comments,
>
> In general, it is less important whether the class is implemented as a
> interface (XXImpl...etc).
> Class name should be qualified, in other words, class name need to
> communicate how the class is different with others.
>
> And +1 to Chanwit's idea.
> We need to review another good project's interface design(like JDT) and
> apply to ours.
>
>
>
> 2008/8/21 joosun yoon <ologist0@gmail.com>
>
> > Edward said, "The MatrixInterface should be Matrix,Implement classes
> should
> > be ***Matrix."
> >
> > I agree with Ed. , +1
> >
> > Personally, prefix and suffix are disliked except "Utils". ex) XXXImpl,
> > XXXInterface, IXXX
> > It must be renamed to more cohesive name.
> >
> >
> >
> > 2008/8/21, Chanwit Kaewkasi <chanwit@gmail.com>:
> > >
> > > Hello Edward,
> > >
> > > It's a Java perspective in Eclipse we're using every day ;-)
> > > It's very good structured IMO.
> > >
> > > In JDT compiler packages,  there are the public package, and it's
> > > internal package counter-part.
> > > If we're going to use the similar package structure we could have:
> > >
> > > org.apache.hama, where all public APIs go here
> > >
> > > then
> > >
> > > org.apache.hama.internals, where all concrete implementation go here.
> > > I'm not a design pattern expert any way, but I think we could use a
> > > factory pattern somehow here.
> > >
> > > Regards,
> > >
> > > Chanwit
> > >
> > > 2008/8/21 Edward J. Yoon <edwardyoon@apache.org>:
> > > > I quite agree with you. The MatrixInterface should be Matrix,
> > > > Implement classes should be ***Matrix.
> > > >
> > > > BTW, What is the JDT project? Could you give me more explanation
> about
> > > > JTD usage? :)
> > > >
> > > > -Edward
> > > >
> > > > On 8/21/08, Chanwit Kaewkasi <chanwit@gmail.com> wrote:
> > > >> Hello,
> > > >>
> > > >> I'm looking at Hama today and to be honest, I want to rename some
> > > >> interface and classes.
> > > >> For example,
> > > >>
> > > >> - interface MatrixInterface
> > > >> I think it should be Matrix
> > > >>
> > > >> - class Matrix
> > > >> it should be MatrixImpl
> > > >>
> > > >> etc.
> > > >>
> > > >> As far as I know, one of the most elegant interface design is
> Eclipse
> > > >> JDT project. Should we look at its package and class structure to
> > > >> apply to ours?
> > > >>
> > > >> Regards,
> > > >>
> > > >> Chanwit
> > > >>
> > > >
> > > >
> > > > --
> > > > Best regards, Edward J. Yoon
> > > > edwardyoon@apache.org
> > > > http://blog.udanax.org
> > > >
> > >
> >
> >
> >
> > --
> > Yoon Joo Sun
> > Java Developer Engineer
> > Blog - http://www.ologist.co.kr
> >
>



-- 
Yoon Joo Sun
Java Developer Engineer
Blog - http://www.ologist.co.kr

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message