incubator-hama-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tomm...@apache.org
Subject svn commit: r1339614 - /incubator/hama/trunk/core/src/main/java/org/apache/hama/bsp/LocalBSPRunner.java
Date Thu, 17 May 2012 14:30:32 GMT
Author: tommaso
Date: Thu May 17 14:30:32 2012
New Revision: 1339614

URL: http://svn.apache.org/viewvc?rev=1339614&view=rev
Log:
[HAMA-572] - fixing access level and adding final modifiers where applicable in LocalBSPRunner

Modified:
    incubator/hama/trunk/core/src/main/java/org/apache/hama/bsp/LocalBSPRunner.java

Modified: incubator/hama/trunk/core/src/main/java/org/apache/hama/bsp/LocalBSPRunner.java
URL: http://svn.apache.org/viewvc/incubator/hama/trunk/core/src/main/java/org/apache/hama/bsp/LocalBSPRunner.java?rev=1339614&r1=1339613&r2=1339614&view=diff
==============================================================================
--- incubator/hama/trunk/core/src/main/java/org/apache/hama/bsp/LocalBSPRunner.java (original)
+++ incubator/hama/trunk/core/src/main/java/org/apache/hama/bsp/LocalBSPRunner.java Thu May
17 14:30:32 2012
@@ -61,29 +61,29 @@ import org.apache.hama.util.BSPNetUtils;
  * running BSP's.
  */
 public class LocalBSPRunner implements JobSubmissionProtocol {
-  public static final Log LOG = LogFactory.getLog(LocalBSPRunner.class);
+  private static final Log LOG = LogFactory.getLog(LocalBSPRunner.class);
 
   private static final String IDENTIFIER = "localrunner";
   private static String WORKING_DIR = "/tmp/hama-bsp/";
   private volatile ThreadPoolExecutor threadPool;
 
   @SuppressWarnings("rawtypes")
-  protected static final LinkedList<Future<BSPPeerImpl>> futureList = new LinkedList<Future<BSPPeerImpl>>();
+  private static final LinkedList<Future<BSPPeerImpl>> futureList = new LinkedList<Future<BSPPeerImpl>>();
 
-  protected String jobFile;
-  protected String jobName;
+  private String jobFile;
+  private String jobName;
 
-  protected JobStatus currentJobStatus;
+  private JobStatus currentJobStatus;
 
-  protected Configuration conf;
-  protected FileSystem fs;
+  private final Configuration conf;
+  private FileSystem fs;
 
   private static volatile long superStepCount = 0L;
   private static String[] peerNames;
   private final Counters globalCounters = new Counters();
 
   // this is used for not-input driven job
-  private int maxTasks;
+  private final int maxTasks;
 
   public LocalBSPRunner(Configuration conf) throws IOException {
     super();
@@ -201,7 +201,6 @@ public class LocalBSPRunner implements J
 
   @Override
   public void killJob(BSPJobID jobid) throws IOException {
-    return;
   }
 
   @Override
@@ -214,11 +213,11 @@ public class LocalBSPRunner implements J
   @SuppressWarnings({ "rawtypes" })
   static class BSPRunner implements Callable<BSPPeerImpl> {
 
-    private Configuration conf;
-    private BSPJob job;
-    private int id;
-    private BSP bsp;
-    private RawSplit[] splits;
+    private final Configuration conf;
+    private final BSPJob job;
+    private final int id;
+    private final BSP bsp;
+    private final RawSplit[] splits;
     private BSPPeerImpl peer;
 
     public BSPRunner(Configuration conf, BSPJob job, int id, RawSplit[] splits) {
@@ -293,7 +292,7 @@ public class LocalBSPRunner implements J
   // this thread observes the status of the runners.
   class ThreadObserver implements Runnable {
 
-    JobStatus status;
+    final JobStatus status;
 
     public ThreadObserver(JobStatus currentJobStatus) {
       this.status = currentJobStatus;



Mime
View raw message