incubator-hama-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From edwardy...@apache.org
Subject svn commit: r1002450 - in /incubator/hama/trunk: CHANGES.txt src/java/org/apache/hama/bsp/BSPMaster.java
Date Wed, 29 Sep 2010 02:45:23 GMT
Author: edwardyoon
Date: Wed Sep 29 02:45:23 2010
New Revision: 1002450

URL: http://svn.apache.org/viewvc?rev=1002450&view=rev
Log:
Typo might lead to null tasks getting assigned to groom servers

Modified:
    incubator/hama/trunk/CHANGES.txt
    incubator/hama/trunk/src/java/org/apache/hama/bsp/BSPMaster.java

Modified: incubator/hama/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/incubator/hama/trunk/CHANGES.txt?rev=1002450&r1=1002449&r2=1002450&view=diff
==============================================================================
--- incubator/hama/trunk/CHANGES.txt (original)
+++ incubator/hama/trunk/CHANGES.txt Wed Sep 29 02:45:23 2010
@@ -153,6 +153,8 @@ Trunk (unreleased changes)
 
   BUG FIXES
   
+    HAMA-288: Typo might lead to null tasks getting assigned 
+                       to groom servers (Filipe Manana via edwardyoon)
     HAMA-280: Fix warnings (Filipe Manana via edwardyoon)
     HAMA-270: wrong sequence of readFields() of ClusterStatus (hyunsik)
     HAMA-260: Current version command of script is linked unknown class (edwardyoon)

Modified: incubator/hama/trunk/src/java/org/apache/hama/bsp/BSPMaster.java
URL: http://svn.apache.org/viewvc/incubator/hama/trunk/src/java/org/apache/hama/bsp/BSPMaster.java?rev=1002450&r1=1002449&r2=1002450&view=diff
==============================================================================
--- incubator/hama/trunk/src/java/org/apache/hama/bsp/BSPMaster.java (original)
+++ incubator/hama/trunk/src/java/org/apache/hama/bsp/BSPMaster.java Wed Sep 29 02:45:23 2010
@@ -370,10 +370,10 @@ public class BSPMaster implements JobSub
       if (groomStatus == null) {
         LOG.warn("Unknown task tracker polling; ignoring: " + groomName);
       } else {
-        List<Task> tasks = taskScheduler.assignTasks(groomStatus);
-        LOG.debug("BSPMaster.heartbeat.taskSize: " + tasks.size());
-        for (Task task : tasks) {
-          if (tasks != null) {
+        List<Task> taskList = taskScheduler.assignTasks(groomStatus);
+        LOG.debug("BSPMaster.heartbeat.taskSize: " + taskList.size());
+        for (Task task : taskList) {
+          if (task != null) {
             actions.add(new LaunchTaskAction(task));
           }
         }



Mime
View raw message