incubator-hama-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From edwardy...@apache.org
Subject svn commit: r693072 - in /incubator/hama/trunk/src/java/org/apache/hama: io/VectorMapWritable.java mapred/MatrixInputFormatBase.java mapred/MatrixOutputFormat.java
Date Mon, 08 Sep 2008 12:27:39 GMT
Author: edwardyoon
Date: Mon Sep  8 05:27:39 2008
New Revision: 693072

URL: http://svn.apache.org/viewvc?rev=693072&view=rev
Log:
Removing trivial warnings.

Modified:
    incubator/hama/trunk/src/java/org/apache/hama/io/VectorMapWritable.java
    incubator/hama/trunk/src/java/org/apache/hama/mapred/MatrixInputFormatBase.java
    incubator/hama/trunk/src/java/org/apache/hama/mapred/MatrixOutputFormat.java

Modified: incubator/hama/trunk/src/java/org/apache/hama/io/VectorMapWritable.java
URL: http://svn.apache.org/viewvc/incubator/hama/trunk/src/java/org/apache/hama/io/VectorMapWritable.java?rev=693072&r1=693071&r2=693072&view=diff
==============================================================================
--- incubator/hama/trunk/src/java/org/apache/hama/io/VectorMapWritable.java (original)
+++ incubator/hama/trunk/src/java/org/apache/hama/io/VectorMapWritable.java Mon Sep  8 05:27:39
2008
@@ -123,13 +123,11 @@
   // Writable
 
   /** @return the Class class for the specified id */
-  @SuppressWarnings( { "unchecked", "boxing" })
   protected Class<?> getClass(byte id) {
     return CODE_TO_CLASS.get(id);
   }
 
   /** @return the id for the specified Class */
-  @SuppressWarnings( { "unchecked", "boxing" })
   protected byte getId(Class<?> clazz) {
     Byte b = CLASS_TO_CODE.get(clazz);
     if (b == null) {
@@ -157,7 +155,8 @@
   }
 
   /** {@inheritDoc} */
-  public void readFields(DataInput in) throws IOException {
+  @SuppressWarnings("unchecked")
+public void readFields(DataInput in) throws IOException {
     // First clear the map. Otherwise we will just accumulate
     // entries every time this method is called.
     this.instance.clear();

Modified: incubator/hama/trunk/src/java/org/apache/hama/mapred/MatrixInputFormatBase.java
URL: http://svn.apache.org/viewvc/incubator/hama/trunk/src/java/org/apache/hama/mapred/MatrixInputFormatBase.java?rev=693072&r1=693071&r2=693072&view=diff
==============================================================================
--- incubator/hama/trunk/src/java/org/apache/hama/mapred/MatrixInputFormatBase.java (original)
+++ incubator/hama/trunk/src/java/org/apache/hama/mapred/MatrixInputFormatBase.java Mon Sep
 8 05:27:39 2008
@@ -172,7 +172,6 @@
      * @return true if there was more data
      * @throws IOException
      */
-    @SuppressWarnings("unchecked")
     public boolean next(IntWritable key, DenseVector value)
         throws IOException {
       RowResult result = this.scanner.next();
@@ -193,8 +192,7 @@
    *      JobConf, Reporter)
    */
   public RecordReader<IntWritable, DenseVector> getRecordReader(
-      InputSplit split, @SuppressWarnings("unused") JobConf job,
-      @SuppressWarnings("unused") Reporter reporter) throws IOException {
+      InputSplit split, JobConf job, Reporter reporter) throws IOException {
     TableSplit tSplit = (TableSplit) split;
     TableRecordReader trr = this.tableRecordReader;
     // if no table record reader was provided use default

Modified: incubator/hama/trunk/src/java/org/apache/hama/mapred/MatrixOutputFormat.java
URL: http://svn.apache.org/viewvc/incubator/hama/trunk/src/java/org/apache/hama/mapred/MatrixOutputFormat.java?rev=693072&r1=693071&r2=693072&view=diff
==============================================================================
--- incubator/hama/trunk/src/java/org/apache/hama/mapred/MatrixOutputFormat.java (original)
+++ incubator/hama/trunk/src/java/org/apache/hama/mapred/MatrixOutputFormat.java Mon Sep 
8 05:27:39 2008
@@ -62,14 +62,12 @@
     }
 
     /** {@inheritDoc} */
-    public void close(@SuppressWarnings("unused")
-    Reporter reporter) {
+    public void close(Reporter reporter) {
       // Nothing to do.
     }
 
     /** {@inheritDoc} */
-    public void write(@SuppressWarnings("unused")
-    IntWritable key, BatchUpdate value) throws IOException {
+    public void write(IntWritable key, BatchUpdate value) throws IOException {
       m_table.commit(value);
     }
   }
@@ -77,10 +75,8 @@
   /** {@inheritDoc} */
   @Override
   @SuppressWarnings("unchecked")
-  public RecordWriter getRecordWriter(@SuppressWarnings("unused")
-  FileSystem ignored, JobConf job, @SuppressWarnings("unused")
-  String name, @SuppressWarnings("unused")
-  Progressable progress) throws IOException {
+  public RecordWriter getRecordWriter(FileSystem ignored, JobConf job,
+      String name, Progressable progress) throws IOException {
 
     // expecting exactly one path
 
@@ -97,7 +93,6 @@
 
   /** {@inheritDoc} */
   @Override
-  @SuppressWarnings("unused")
   public void checkOutputSpecs(FileSystem ignored, JobConf job)
       throws FileAlreadyExistsException, InvalidJobConfException, IOException {
 



Mime
View raw message