From graffito-dev-return-1070-apmail-incubator-graffito-dev-archive=www.apache.org@incubator.apache.org Mon May 22 20:31:32 2006 Return-Path: Delivered-To: apmail-incubator-graffito-dev-archive@www.apache.org Received: (qmail 57358 invoked from network); 22 May 2006 20:31:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 May 2006 20:31:32 -0000 Received: (qmail 6938 invoked by uid 500); 22 May 2006 20:31:32 -0000 Mailing-List: contact graffito-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: graffito-dev@incubator.apache.org Delivered-To: mailing list graffito-dev@incubator.apache.org Received: (qmail 6926 invoked by uid 99); 22 May 2006 20:31:31 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 May 2006 13:31:31 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of the.mindstorm.mailinglist@gmail.com designates 66.249.92.171 as permitted sender) Received: from [66.249.92.171] (HELO ug-out-1314.google.com) (66.249.92.171) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 May 2006 13:31:31 -0700 Received: by ug-out-1314.google.com with SMTP id q2so1371953uge for ; Mon, 22 May 2006 13:31:09 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=FUP6s6LxJVDqQLWLuHXmvieCwK/uDK8Vg9atu73qBd9kzHM/tlpw3SNoyJY29KcX5F7UdtVIFBV6tGhjJhFf5rlDdLsNnosKjJTSHPeHtRo4Aqp5c40lZ4w7Lg6u3hfWXOcbEm8+FEgxz6dy6mxiAtcsGLvH79vY0HB0Nvcsuu4= Received: by 10.66.216.20 with SMTP id o20mr3656744ugg; Mon, 22 May 2006 13:31:09 -0700 (PDT) Received: by 10.66.239.15 with HTTP; Mon, 22 May 2006 13:31:09 -0700 (PDT) Message-ID: Date: Mon, 22 May 2006 23:31:09 +0300 From: "Alexandru Popescu" To: graffito-dev@incubator.apache.org Subject: Re: svn commit: r406117 - /incubator/graffito/trunk/jcr/jcr-mapping/src/test/org/apache/portals/graffito/jcr/testmodel/interfaces/ In-Reply-To: <20060513150724.66760.qmail@minotaur.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20060513150724.66760.qmail@minotaur.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi Chris! I just noticed this comment and I am not 100% I like the solution for the discriminator mixin which seems obtrusive. It is like requiring a class to implement a special interface just to make it work with graffito and this is not good. The user must have the freedom to define his nodetypes and create no dependencies upon graffito and for this small thing it is really easy to configure hust a field name to make it work. br, ./alex -- .w( the_mindstorm )p. On 5/13/06, clombart@apache.org wrote: > Author: clombart > Date: Sat May 13 08:07:23 2006 > New Revision: 406117 > > URL: http://svn.apache.org/viewcvs?rev=3D406117&view=3Drev > Log: > Add several modifications : > > * jcrNodeType is not mandatory.If not present the default value is "nt:un= structured". > * discriminator field descriptor was removed. Only the flag discriminator= is defined on the class descriptor. > If this flag is true, a mixin node type "graffito:discriminator" = is added to the node. > This type contains one property to store the java classname (graf= fito:classname). > With this implementation, the discriminator field is not necessary. S= o, the persistence mechanism is still transparent for the jaba beans. > > * Interface support : like the inheritance support, there are 2 different= s strategies : node type per concrete class or per complete hierarchy. The = hierarchy strategy requires a discriminator node type. > > Added: > incubator/graffito/trunk/jcr/jcr-mapping/src/test/org/apache/portals/= graffito/jcr/testmodel/interfaces/ > >