From graffito-dev-return-1054-apmail-incubator-graffito-dev-archive=www.apache.org@incubator.apache.org Sat Apr 01 22:37:48 2006 Return-Path: Delivered-To: apmail-incubator-graffito-dev-archive@www.apache.org Received: (qmail 62014 invoked from network); 1 Apr 2006 22:37:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 1 Apr 2006 22:37:48 -0000 Received: (qmail 16079 invoked by uid 500); 1 Apr 2006 22:37:47 -0000 Mailing-List: contact graffito-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: graffito-dev@incubator.apache.org Delivered-To: mailing list graffito-dev@incubator.apache.org Received: (qmail 16062 invoked by uid 99); 1 Apr 2006 22:37:47 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Apr 2006 14:37:47 -0800 X-ASF-Spam-Status: No, hits=1.4 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: 193.19.192.5 is neither permitted nor denied by domain of the.mindstorm.mailinglist@gmail.com) Received: from [193.19.192.5] (HELO mail.evolva.ro) (193.19.192.5) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Apr 2006 14:37:46 -0800 Received: from localhost (localhost [127.0.0.1]) by mail.evolva.ro (Postfix) with ESMTP id 2C4A524510D for ; Sat, 1 Apr 2006 23:39:17 +0300 (EEST) Received: from mail.evolva.ro ([127.0.0.1]) by localhost (mail.evolva.ro [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 61007-04 for ; Sat, 1 Apr 2006 23:39:16 +0300 (EEST) Received: from [192.168.62.51] (unknown [86.55.40.139]) by mail.evolva.ro (Postfix) with ESMTP id 5F7E524510C for ; Sat, 1 Apr 2006 23:39:16 +0300 (EEST) Message-ID: <442EE510.3060908@gmail.com> Date: Sat, 01 Apr 2006 23:39:44 +0300 From: Alexandru Popescu User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051201 Thunderbird/1.5 Mnenhy/0.7.3.0 MIME-Version: 1.0 To: graffito-dev@incubator.apache.org Subject: Re: JCR Mapping tools - inheritance support References: <3b728ee90603311407r78bd31ecuabb8f62027326acf@mail.gmail.com> <3b728ee90603312350q5d8add49of955617d57122915@mail.gmail.com> <3b728ee90604011119s75891204pf0f97c1a222c6715@mail.gmail.com> In-Reply-To: <3b728ee90604011119s75891204pf0f97c1a222c6715@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at evolva.ro X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N #: Christophe Lombart changed the world a bit at a time by saying (astral date: 4/1/2006 10:19 PM) :# > On 4/1/06, Alexandru Popescu wrote: >> >> Hey... they weren't so many or big changes (most of them were API >> additions to simplify the algo). I have finished looking through the >> code and I have only 2 questions: >> >> 1/ PersistenceManagerImpl(Session session,String[] xmlMappingFiles ) >> doesn't look like fitting into that place and moreover it is never >> used. I would definitely like to remove it. > > > Correct it is not used in the unit tests but this is simplest way to > instantiante a PersistenceManager. > please don't remove it. > Chris, unfortunately I have to disagree with you. Even if sometimes constructing an object is a little more difficult, IMO it is much more important to have clear separation of concerns. And this constructor is breaking it: a PersistenceManager should not have to deal or know how to parse some files. This is the responsibility of something else. Please do correct me if I am wrong. > > 2/ ParentBeanConverter: what is the usage of this class. I haven't >> found any references to it. > > > under construction :-) but maybe I will remove it. > I'm wondering if it is interesting to have a converter to retrieve the > parent folder bean (I mean the parent node in term of JCR API) > I see. np. ./alex -- .w( the_mindstorm )p.