From graffito-dev-return-1053-apmail-incubator-graffito-dev-archive=www.apache.org@incubator.apache.org Sat Apr 01 19:19:31 2006 Return-Path: Delivered-To: apmail-incubator-graffito-dev-archive@www.apache.org Received: (qmail 99331 invoked from network); 1 Apr 2006 19:19:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 1 Apr 2006 19:19:31 -0000 Received: (qmail 7846 invoked by uid 500); 1 Apr 2006 19:19:30 -0000 Mailing-List: contact graffito-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: graffito-dev@incubator.apache.org Delivered-To: mailing list graffito-dev@incubator.apache.org Received: (qmail 7835 invoked by uid 99); 1 Apr 2006 19:19:30 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Apr 2006 11:19:30 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of christophe.lombart@gmail.com designates 64.233.182.187 as permitted sender) Received: from [64.233.182.187] (HELO nproxy.gmail.com) (64.233.182.187) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Apr 2006 11:19:29 -0800 Received: by nproxy.gmail.com with SMTP id p48so757085nfa for ; Sat, 01 Apr 2006 11:19:08 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=RIhGk1FKrHocSPXimSqnVDFAmD7Hdu9mcydZTF4W6LG6+la1+/MSdIUE3bJelpW/8K8Vhvu0HLaIYHm6XbjPfwApVtE2EvHaIcddxjupNd+tEIBTArVYkx4S8U4ACnOLC9dBcC75xTvZ1dUKNreGyTF3BdLXBHe1PGhDNBwiSx8= Received: by 10.48.212.5 with SMTP id k5mr164891nfg; Sat, 01 Apr 2006 11:19:08 -0800 (PST) Received: by 10.48.42.14 with HTTP; Sat, 1 Apr 2006 11:19:08 -0800 (PST) Message-ID: <3b728ee90604011119s75891204pf0f97c1a222c6715@mail.gmail.com> Date: Sat, 1 Apr 2006 21:19:08 +0200 From: "Christophe Lombart" To: graffito-dev@incubator.apache.org Subject: Re: JCR Mapping tools - inheritance support In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_2132_22779423.1143919148698" References: <3b728ee90603311407r78bd31ecuabb8f62027326acf@mail.gmail.com> <3b728ee90603312350q5d8add49of955617d57122915@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N ------=_Part_2132_22779423.1143919148698 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On 4/1/06, Alexandru Popescu wrote: > > Hey... they weren't so many or big changes (most of them were API > additions to simplify the algo). I have finished looking through the > code and I have only 2 questions: > > 1/ PersistenceManagerImpl(Session session,String[] xmlMappingFiles ) > doesn't look like fitting into that place and moreover it is never > used. I would definitely like to remove it. Correct it is not used in the unit tests but this is simplest way to instantiante a PersistenceManager. please don't remove it. 2/ ParentBeanConverter: what is the usage of this class. I haven't > found any references to it. under construction :-) but maybe I will remove it. I'm wondering if it is interesting to have a converter to retrieve the parent folder bean (I mean the parent node in term of JCR API) ------=_Part_2132_22779423.1143919148698--