incubator-graffito-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christophe Lombart" <christophe.lomb...@sword-technologies.com>
Subject Re: possible small problems in ObjectConverterImpl
Date Mon, 02 Jan 2006 10:56:57 GMT
Alexandru Popescu wrote:

> Hi!
>
> I would like to find out your opinion about the 
> ObjectConverterImpl.storeSimpleFields method.
>
> 1/ autocreated properties
>
> When writting a property it ignores the autoCreated properties. But 
> according to JSR-170 the autoCreated properties are writtable, so IMO 
> these should not be ignored. The only requirement related to 
> autoCreated properties is that they should have a default value, but 
> this is required to be provided by the node definition.

Correct  -  It is a bug - Can you add it in Jira ? Thanks !

>
> 2/ protected properties
>
> Instead there is no check against the protected properties. According 
> to JSR-170 these can be read, but cannot be write, so an attempt to 
> write such a property should result in an exception. The current 
> implementation relies on the repository to throw this exception, but 
> IMO a better behavior would be not to attempt to write it.
>
>
Agree - it should be better - Please add it in Jira - Thanks !

> I wait with interest your opinions.
>
> tia,
>
> ./alex
> -- 
> .w( the_mindstorm )p.
>
>


Mime
View raw message