incubator-gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lewis John Mcgibbney <lewis.mcgibb...@gmail.com>
Subject Re: svn commit: r1222596 - /incubator/gora/trunk/gora-hbase/src/test/java/org/apache/gora/hbase/store/TestHBaseStore.java
Date Sun, 25 Dec 2011 15:42:59 GMT
Hi Ioannis,

The reason I did not wish to commit Keith's patch on GORA-66 [1] was
exactly because of the issues you've highlighted here.

This needs further investigation. The utopian ouitcome would be that
this would be implemented in an abstract fashion however it looks as
if it is going to be datastore specific... I suppose we will see when
we have time to look into it.

Thanks

Lewis

[1] https://issues.apache.org/jira/browse/GORA-66

On Fri, Dec 23, 2011 at 7:40 AM,  <iocanel@apache.org> wrote:
> Author: iocanel
> Date: Fri Dec 23 07:40:08 2011
> New Revision: 1222596
>
> URL: http://svn.apache.org/viewvc?rev=1222596&view=rev
> Log:
> [GORA-55] Excluded ranged queries from the tests, since the tests assume end key to be
inclussive while Hbase considers it exclusive.
>
> Modified:
>    incubator/gora/trunk/gora-hbase/src/test/java/org/apache/gora/hbase/store/TestHBaseStore.java
>
> Modified: incubator/gora/trunk/gora-hbase/src/test/java/org/apache/gora/hbase/store/TestHBaseStore.java
> URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-hbase/src/test/java/org/apache/gora/hbase/store/TestHBaseStore.java?rev=1222596&r1=1222595&r2=1222596&view=diff
> ==============================================================================
> --- incubator/gora/trunk/gora-hbase/src/test/java/org/apache/gora/hbase/store/TestHBaseStore.java
(original)
> +++ incubator/gora/trunk/gora-hbase/src/test/java/org/apache/gora/hbase/store/TestHBaseStore.java
Fri Dec 23 07:40:08 2011
> @@ -118,8 +118,27 @@ public class TestHBaseStore extends Data
>     Assert.assertEquals("anchor2", anchor2);
>     table.close();
>   }
> -
> -  public static void main(String[] args) throws Exception {
> +
> +
> +    @Override
> +    public void testQueryEndKey() throws IOException {
> +        //We need to skip this test since gora considers endRow inclusive, while
its exclusinve for HBase.
> +        //TODO: We should raise an issue for HBase to allow us to specify if the
endRow will be inclussive or exclusive.
> +    }
> +
> +    @Override
> +    public void testQueryKeyRange() throws IOException {
> +        //We need to skip this test since gora considers endRow inclusive, while
its exclusinve for HBase.
> +        //TODO: We should raise an issue for HBase to allow us to specify if the
endRow will be inclussive or exclusive.
> +    }
> +
> +    @Override
> +    public void testDeleteByQuery() throws IOException {
> +        //We need to skip this test since gora considers endRow inclusive, while
its exclusinve for HBase.
> +        //TODO: We should raise an issue for HBase to allow us to specify if the
endRow will be inclussive or exclusive.
> +    }
> +
> +    public static void main(String[] args) throws Exception {
>     TestHBaseStore test = new TestHBaseStore();
>     test.setUpClass();
>     test.setUp();
>
>



-- 
Lewis

Mime
View raw message