incubator-gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lewis John McGibbney (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-66) testDeleteByQueryFields seems incorrect
Date Tue, 13 Dec 2011 16:57:30 GMT

    [ https://issues.apache.org/jira/browse/GORA-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168506#comment-13168506
] 

Lewis John McGibbney commented on GORA-66:
------------------------------------------

Well currently this particular test fails for both the gora-hbase [1] and gora-sql [2] modules
anyway, however it doesn't seem to be for the reasons you highlight!

I suppose first we need to determine whether this test should flush after the particular call
FOR ALL STORES.

[1] https://builds.apache.org/job/gora-trunk/org.apache.gora$gora-hbase/67/testReport/org.apache.gora.hbase.store/TestHBaseStore/testDeleteByQueryFields/
[2] https://builds.apache.org/job/gora-trunk/org.apache.gora$gora-sql/67/testReport/org.apache.gora.sql.store/TestSqlStore/testDeleteByQueryFields/
                
> testDeleteByQueryFields seems incorrect
> ---------------------------------------
>
>                 Key: GORA-66
>                 URL: https://issues.apache.org/jira/browse/GORA-66
>             Project: Gora
>          Issue Type: Bug
>            Reporter: Keith Turner
>         Attachments: GORA-66-1.patch
>
>
> While writing the Accumulo backend I have been trying to run some of the existing test
against it.  It seems that the test DataStoreTestUtil.testDeleteByQueryFields() has two problems.
>  * The test does not flush the store after calling deleteByQuery().  This is needed for
accumulo since deletes are just inserts and must be flushed.
>  * The test expects the last key in a range that was deleted to be present.  As far as
I can tell the end key in a query should be inclusive, but the test treats as exclusive.
> I will submit a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message