Mailing-List: contact gora-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: gora-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: local policy)
From: "Mattmann, Chris A (388J)" <chris.a.mattmann@jpl.nasa.gov>
To: "gora-dev@incubator.apache.org" <gora-dev@incubator.apache.org>
CC: Julien Nioche <lists.digitalpebble@gmail.com>,
        Tom White
	<tom@cloudera.com>
Date: Fri, 4 Mar 2011 08:56:41 -0800
Subject: Re: [VOTE] Apache Gora 0.1-incubating release (rc2)
Thread-Topic: [VOTE] Apache Gora 0.1-incubating release (rc2)
Thread-Index: AcvajSNaPij+kGjSSEC7uG0kCvKlAQ==
Message-ID: <F44DFF00-1F19-4135-A756-F5BE07975BF4@jpl.nasa.gov>
References: <AANLkTikaAJx==Sw3Or+S8ecLPjuAim=1+QgFJHQBwHqj@mail.gmail.com>
 <AANLkTik-N-_CNGtUjXBg7bmxFw4HkAwfMiC0pg5JvZ0G@mail.gmail.com>
 <AANLkTi=-J2H_kk8VBDHv4Z+_cBhXE_PUCEoR5RHjW3A6@mail.gmail.com>
 <AANLkTinYdJYtwuuiXzJg=e+9Xhh-QbTmOAxFgkftNw0d@mail.gmail.com>
In-Reply-To: <AANLkTinYdJYtwuuiXzJg=e+9Xhh-QbTmOAxFgkftNw0d@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hey Henry,

No need for it in CHANGES.txt.

Cheers,
Chris

On Mar 4, 2011, at 9:38 AM, Henry Saputra wrote:

> I will add Apache header in the currently checked in files in
> gora-core/src/examples/java/org/apache/gora/examples/generated/ and
> gora-tutorial/src/main/java/org/apache/gora/tutorial/log/generated
> directories.
>=20
> Do we need Apache header in the CHANGES.txt and core-site.xml?
>=20
> - Henry
>=20
> On Fri, Mar 4, 2011 at 3:14 AM, Julien Nioche
> <lists.digitalpebble@gmail.com> wrote:
>> Hi Tom
>>=20
>> On 3 March 2011 23:59, Tom White <tom@cloudera.com> wrote:
>>=20
>>> Checksums and signatures verified OK. I ran RAT and discovered that
>>> there are missing license headers in examples and the tutorial:
>>>=20
>>> Unapproved licenses:
>>>=20
>>>  ./CHANGES.txt
>>>  ./gora-core/src/examples/avro/employee.json
>>>  ./gora-core/src/examples/avro/tokendatum.json
>>>  ./gora-core/src/examples/avro/webpage.json
>>>=20
>>>  ./gora-core/src/examples/java/org/apache/gora/examples/generated/Emplo=
yee.java
>>>=20
>>>  ./gora-core/src/examples/java/org/apache/gora/examples/generated/Metad=
ata.java
>>>=20
>>>  ./gora-core/src/examples/java/org/apache/gora/examples/generated/Token=
Datum.java
>>>=20
>>>  ./gora-core/src/examples/java/org/apache/gora/examples/generated/WebPa=
ge.java
>>>  ./gora-core/src/test/conf/core-site.xml
>>>  ./gora-tutorial/src/main/avro/metricdatum.json
>>>  ./gora-tutorial/src/main/avro/pageview.json
>>>=20
>>>  ./gora-tutorial/src/main/java/org/apache/gora/tutorial/log/generated/M=
etricDatum.java
>>>=20
>>>  ./gora-tutorial/src/main/java/org/apache/gora/tutorial/log/generated/P=
ageview.java
>>>=20
>>> You probably want to ignore the json files since there is no simple
>>> way of adding comments to them. The other files should have the
>>> license headers added though.
>>>=20
>>=20
>> The Java pages you mentioned are all dynamically generated from the json
>> schemas. I will patch GoraCompiler so that it adds the headers to the ja=
va
>> files.
>>=20
>>=20
>>>=20
>>> I also had problems getting the build to work, but perhaps I'm doing
>>> something wrong here?
>>>=20
>>> $ ant publish-all
>>>=20
>>> ...
>>>=20
>>> BUILD FAILED
>>> /private/tmp/apache-gora-0.1-incubating-src/build.xml:284: The
>>> following error occurred while executing this line:
>>> /private/tmp/apache-gora-0.1-incubating-src/build-common.xml:424:
>>> impossible to publish artifacts for
>>> org.apache.gora#gora-core;working@Clouderas-MacBook-Pro-2.local:
>>> java.io.IOException: missing artifact
>>> org.apache.gora#gora-core;0.1-incubating!gora-core.jar
>>>=20
>>=20
>>=20
>> I can reproduce the issue. Not clear what 'publish-all' was meant to do =
in
>> the first place. Publish to the 'shared' repository?
>>=20
>> The default task 'ant compile' works fine, as well as 'ant jar' which bu=
ilds
>> on it but 'ant package'  breaks as it expects the docs to have been buil=
t.
>> The problem is that the task 'docs' tries to build the docs for the webs=
ite
>> as well as the javadoc and requires forrest to be installed etc... I sug=
gest
>> that we build the javadoc only as part of 'package' and handle the websi=
te
>> content separately, possibly via svnpubsub and a separate SVN branch.
>>=20
>> I added javadoc as a dependency of 'package' and it now runs fine and so
>> does 'ant tar'
>>=20
>> Thanks
>>=20
>> Julien
>> --
>> *
>> *Open Source Solutions for Text Engineering
>>=20
>> http://digitalpebble.blogspot.com/
>> http://www.digitalpebble.com
>>=20
>=20
>=20
>=20
> --=20
> Thanks,
> Henry


++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattmann@nasa.gov
WWW:   http://sunset.usc.edu/~mattmann/
Twitter: @chrismattmann
Facebook: http://facebook.com/chris.mattmann
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++