incubator-gora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsapu...@apache.org
Subject svn commit: r1133275 - in /incubator/gora/trunk: gora-cassandra/src/main/java/org/apache/gora/cassandra/client/ gora-core/src/main/java/org/apache/gora/persistency/ gora-core/src/main/java/org/apache/gora/query/ gora-core/src/main/java/org/apache/gora/...
Date Wed, 08 Jun 2011 08:01:14 GMT
Author: hsaputra
Date: Wed Jun  8 08:01:13 2011
New Revision: 1133275

URL: http://svn.apache.org/viewvc?rev=1133275&view=rev
Log:
Remove public and abstract modifiers from methods in Interface because they are implicitly
puclic and abstract

Modified:
    incubator/gora/trunk/gora-cassandra/src/main/java/org/apache/gora/cassandra/client/CassandraClient.java
    incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/BeanFactory.java
    incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/Persistent.java
    incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/StateManager.java
    incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/StatefulMap.java
    incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/PartitionQuery.java
    incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/Query.java
    incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/Result.java
    incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/store/DataStore.java
    incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/store/FileBackedDataStore.java
    incubator/gora/trunk/gora-tutorial/src/main/java/org/apache/gora/tutorial/log/LogAnalytics.java

Modified: incubator/gora/trunk/gora-cassandra/src/main/java/org/apache/gora/cassandra/client/CassandraClient.java
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-cassandra/src/main/java/org/apache/gora/cassandra/client/CassandraClient.java?rev=1133275&r1=1133274&r2=1133275&view=diff
==============================================================================
--- incubator/gora/trunk/gora-cassandra/src/main/java/org/apache/gora/cassandra/client/CassandraClient.java
(original)
+++ incubator/gora/trunk/gora-cassandra/src/main/java/org/apache/gora/cassandra/client/CassandraClient.java
Wed Jun  8 08:01:13 2011
@@ -26,29 +26,26 @@ import org.apache.cassandra.thrift.Token
 
 public interface CassandraClient {
 
-  public void setKeySpace(String keySpace);
+  void setKeySpace(String keySpace);
 
-  public void setConsistencyLevel(ConsistencyLevel level);
+  void setConsistencyLevel(ConsistencyLevel level);
 
-  public Row get(String key, Select select) throws IOException;
+  Row get(String key, Select select) throws IOException;
 
-  public RowIterable getRange(String startKey, String endKey, int rowCount,
-      Select select)
-  throws IOException;
+  RowIterable getRange(String startKey, String endKey, int rowCount, Select select) 
+    throws IOException;
 
-  public RowIterable getTokenRange(String startToken, String endToken,
-      int rowCount, Select select)
-  throws IOException;
+  RowIterable getTokenRange(String startToken, String endToken,
+      int rowCount, Select select) throws IOException;
 
-  public void mutate(String key, Mutate mutation) throws IOException;
+  void mutate(String key, Mutate mutation) throws IOException;
 
-  public Map<String, Map<String, String>> describeKeySpace()
-  throws IOException;
+  Map<String, Map<String, String>> describeKeySpace() throws IOException;
 
-  public List<TokenRange> describeRing() throws IOException;
+  List<TokenRange> describeRing() throws IOException;
 
-  public List<String> describeSplits(String startToken, String endToken, int size)
-  throws IOException;
+  List<String> describeSplits(String startToken, String endToken, int size)
+    throws IOException;
 
-  public void close();
+  void close();
 }

Modified: incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/BeanFactory.java
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/BeanFactory.java?rev=1133275&r1=1133274&r2=1133275&view=diff
==============================================================================
--- incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/BeanFactory.java
(original)
+++ incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/BeanFactory.java
Wed Jun  8 08:01:13 2011
@@ -27,13 +27,13 @@ public interface BeanFactory<K, T extend
    * Constructs a new instance of the key class
    * @return a new instance of the key class
    */
-  public abstract K newKey() throws Exception;
+  K newKey() throws Exception;
 
   /**
    * Constructs a new instance of the Persistent class
-   * @return a new instance of the Peristent class
+   * @return a new instance of the Persistent class
    */
-  public abstract T newPersistent();
+  T newPersistent();
 
   /**
    * Returns an instance of the key object to be 
@@ -42,7 +42,7 @@ public interface BeanFactory<K, T extend
    * of the object should be assumed to be readable. 
    * @return a cached instance of the key object
    */
-  public abstract K getCachedKey();
+  K getCachedKey();
   
   /**
    * Returns an instance of the {@link Persistent} object to be 
@@ -51,18 +51,18 @@ public interface BeanFactory<K, T extend
    * of the object should be assumed to be readable. 
    * @return a cached instance of the Persistent object
    */
-  public abstract T getCachedPersistent();
+  T getCachedPersistent();
 
   /**
    * Returns the key class
    * @return the key class
    */
-  public abstract Class<K> getKeyClass();
+  Class<K> getKeyClass();
 
   /**
    * Returns the persistent class
    * @return the persistent class
    */
-  public abstract Class<T> getPersistentClass();
+  Class<T> getPersistentClass();
 
 }
\ No newline at end of file

Modified: incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/Persistent.java
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/Persistent.java?rev=1133275&r1=1133274&r2=1133275&view=diff
==============================================================================
--- incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/Persistent.java
(original)
+++ incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/Persistent.java
Wed Jun  8 08:01:13 2011
@@ -29,7 +29,7 @@ public interface Persistent extends Spec
    * state of the object.
    * @return the StateManager of the object
    */
-  public StateManager getStateManager();
+  StateManager getStateManager();
 
   /**
    * Constructs a new instance of the object with the given StateManager.
@@ -38,149 +38,149 @@ public interface Persistent extends Spec
    * of the object
    * @return a new instance of the object
    */
-  public Persistent newInstance(StateManager stateManager);
+  Persistent newInstance(StateManager stateManager);
 
   /**
    * Returns sorted field names of the object
    * @return the field names of the object as a String[]
    */
-  public String[] getFields();
+  String[] getFields();
   
   /**
    * Returns the field name with the given index
    * @param index the index of the field  
    * @return the name of the field
    */
-  public String getField(int index);
+  String getField(int index);
   
   /**
    * Returns the index of the field with the given name
    * @param field the name of the field
    * @return the index of the field
    */
-  public int getFieldIndex(String field);
+  int getFieldIndex(String field);
   
   /**
    * Clears the inner state of the object without any modification
    * to the actual data on the data store. This method should be called 
    * before re-using the object to hold the data for another result.  
    */
-  public void clear();
+  void clear();
   
   /**
    * Returns whether the object is newly constructed.
    * @return true if the object is newly constructed, false if
    * retrieved from a datastore. 
    */
-  public boolean isNew();
+  boolean isNew();
   
   /**
    * Sets the state of the object as new for persistency
    */
-  public void setNew();
+  void setNew();
   
   /**
    * Clears the new state 
    */
-  public void clearNew();
+  void clearNew();
   
   /**
    * Returns whether any of the fields of the object has been modified 
    * after construction or loading. 
    * @return whether any of the fields of the object has changed
    */
-  public boolean isDirty();
+  boolean isDirty();
   
   /**
    * Returns whether the field has been modified.
    * @param fieldIndex the offset of the field in the object
    * @return whether the field has been modified.
    */
-  public boolean isDirty(int fieldIndex);
+  boolean isDirty(int fieldIndex);
 
   /**
    * Returns whether the field has been modified.
    * @param field the name of the field
    * @return whether the field has been modified.
    */
-  public boolean isDirty(String field);
+  boolean isDirty(String field);
   
   /**
    * Sets all the fields of the object as dirty.
    */
-  public void setDirty();
+  void setDirty();
   
   /**
    * Sets the field as dirty.
    * @param fieldIndex the offset of the field in the object
    */
-  public void setDirty(int fieldIndex);
+  void setDirty(int fieldIndex);
  
   /**
    * Sets the field as dirty.
    * @param field the name of the field
    */
-  public void setDirty(String field);
+  void setDirty(String field);
   
   /**
    * Clears the field as dirty.
    * @param fieldIndex the offset of the field in the object
    */
-  public void clearDirty(int fieldIndex);
+  void clearDirty(int fieldIndex);
   
   /**
    * Clears the field as dirty.
    * @param field the name of the field
    */
-  public void clearDirty(String field);
+  void clearDirty(String field);
   
   /**
    * Clears the dirty state.
    */
-  public void clearDirty();
+  void clearDirty();
   
   /**
    * Returns whether the field has been loaded from the datastore. 
    * @param fieldIndex the offset of the field in the object
    * @return whether the field has been loaded 
    */
-  public boolean isReadable(int fieldIndex);
+  boolean isReadable(int fieldIndex);
 
   /**
    * Returns whether the field has been loaded from the datastore. 
    * @param field the name of the field
    * @return whether the field has been loaded 
    */
-  public boolean isReadable(String field);
+  boolean isReadable(String field);
   
   /**
    * Sets the field as readable.
    * @param fieldIndex the offset of the field in the object
    */
-  public void setReadable(int fieldIndex);
+  void setReadable(int fieldIndex);
 
   /**
    * Sets the field as readable.
    * @param field the name of the field
    */
-  public void setReadable(String field);
+  void setReadable(String field);
 
   /**
    * Clears the field as readable.
    * @param fieldIndex the offset of the field in the object
    */
-  public void clearReadable(int fieldIndex);
+  void clearReadable(int fieldIndex);
   
   /**
    * Sets the field as readable.
    * @param field the name of the field
    */
-  public void clearReadable(String field);
+  void clearReadable(String field);
   
   /**
    * Clears the readable state.
    */
-  public void clearReadable();
+  void clearReadable();
   
-  public Persistent clone();
+  Persistent clone();
 }

Modified: incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/StateManager.java
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/StateManager.java?rev=1133275&r1=1133274&r2=1133275&view=diff
==============================================================================
--- incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/StateManager.java
(original)
+++ incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/StateManager.java
Wed Jun  8 08:01:13 2011
@@ -28,83 +28,83 @@ public interface StateManager {
    * call this method to set the managed persistent. 
    * @param persistent the persistent to manage
    */
-  public void setManagedPersistent(Persistent persistent);
+  void setManagedPersistent(Persistent persistent);
 
   /**
    * Returns whether the object is newly constructed.
    * @return true if the object is newly constructed, false if
    * retrieved from a datastore. 
    */
-  public boolean isNew(Persistent persistent);
+  boolean isNew(Persistent persistent);
   
   /**
    * Sets the state of the object as new for persistency
    */
-  public void setNew(Persistent persistent);
+  void setNew(Persistent persistent);
   
   /**
    * Clears the new state 
    */
-  public void clearNew(Persistent persistent);
+  void clearNew(Persistent persistent);
 
   /**
    * Returns whether any of the fields of the object has been modified 
    * after construction or loading. 
    * @return whether any of the fields of the object has changed
    */
-  public boolean isDirty(Persistent persistent);
+  boolean isDirty(Persistent persistent);
   
   /**
    * Returns whether the field has been modified.
    * @param fieldIndex the offset of the field in the object
    * @return whether the field has been modified.
    */
-  public boolean isDirty(Persistent persistent, int fieldIndex);
+  boolean isDirty(Persistent persistent, int fieldIndex);
   
   /**
    * Sets all the fields of the object as dirty.
    */
-  public void setDirty(Persistent persistent);
+  void setDirty(Persistent persistent);
   
   /**
    * Sets the field as dirty.
    * @param fieldIndex the offset of the field in the object
    */
-  public void setDirty(Persistent persistent, int fieldIndex);
+  void setDirty(Persistent persistent, int fieldIndex);
 
   /**
    * Clears the field as dirty.
    * @param fieldIndex the offset of the field in the object
    */
-  public void clearDirty(Persistent persistent, int fieldIndex);
+  void clearDirty(Persistent persistent, int fieldIndex);
   
   /**
    * Clears the dirty state.
    */
-  public void clearDirty(Persistent persistent);
+  void clearDirty(Persistent persistent);
   
   /**
    * Returns whether the field has been loaded from the datastore. 
    * @param fieldIndex the offset of the field in the object
    * @return whether the field has been loaded 
    */
-  public boolean isReadable(Persistent persistent, int fieldIndex);
+  boolean isReadable(Persistent persistent, int fieldIndex);
   
   /**
    * Sets the field as readable.
    * @param fieldIndex the offset of the field in the object
    */
-  public void setReadable(Persistent persistent, int fieldIndex);
+  void setReadable(Persistent persistent, int fieldIndex);
 
   /**
    * Clears the field as readable.
    * @param fieldIndex the offset of the field in the object
    */
-  public void clearReadable(Persistent persistent, int fieldIndex);
+  void clearReadable(Persistent persistent, int fieldIndex);
   
   /**
    * Clears the readable state.
    */
-  public void clearReadable(Persistent persistent);
+  void clearReadable(Persistent persistent);
   
 }

Modified: incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/StatefulMap.java
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/StatefulMap.java?rev=1133275&r1=1133274&r2=1133275&view=diff
==============================================================================
--- incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/StatefulMap.java
(original)
+++ incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/persistency/StatefulMap.java
Wed Jun  8 08:01:13 2011
@@ -26,12 +26,12 @@ import java.util.Map;
  */
 public interface StatefulMap<K, V> extends Map<K, V> {
 
-  public abstract State getState(K key);
+  State getState(K key);
   
-  public abstract void putState(K key, State state);
+  void putState(K key, State state);
 
-  public abstract Map<K, State> states();
+  Map<K, State> states();
 
-  public abstract void clearStates();
+  void clearStates();
   
 }
\ No newline at end of file

Modified: incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/PartitionQuery.java
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/PartitionQuery.java?rev=1133275&r1=1133274&r2=1133275&view=diff
==============================================================================
--- incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/PartitionQuery.java
(original)
+++ incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/PartitionQuery.java
Wed Jun  8 08:01:13 2011
@@ -33,6 +33,6 @@ public interface PartitionQuery<K, T ext
    * Returns the locations on which this partial query will run locally.
    * @return the addresses of machines
    */
-  public String[] getLocations();
+  String[] getLocations();
   
 }

Modified: incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/Query.java
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/Query.java?rev=1133275&r1=1133274&r2=1133275&view=diff
==============================================================================
--- incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/Query.java (original)
+++ incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/Query.java Wed Jun
 8 08:01:13 2011
@@ -37,117 +37,81 @@ public interface Query<K, T extends Pers
    * method only if you know what you are doing.
    * @param dataStore the dataStore of the query
    */
-  public abstract void setDataStore(DataStore<K,T> dataStore);
+  void setDataStore(DataStore<K,T> dataStore);
   
   /**
    * Returns the DataStore, that this Query is associated with.
    * @return the DataStore of the Query
    */
-  public abstract DataStore<K,T> getDataStore();
+  DataStore<K,T> getDataStore();
   
   /**
    * Executes the Query on the DataStore and returns the results.
    * @return the {@link Result} for the query.
    */
-  public abstract Result<K,T> execute() throws IOException;
+  Result<K,T> execute() throws IOException;
   
 //  /**
 //   * Compiles the query for performance and error checking. This 
 //   * method is an optional optimization for DataStore implementations.
 //   */
-//  public abstract void compile();
+//  void compile();
 //  
 //  /**
 //   * Sets the query string
 //   * @param queryString the query in String
 //   */
-//  public abstract void setQueryString(String queryString);
+//  void setQueryString(String queryString);
 //  
 //  /**
 //   * Returns the query string
 //   * @return the query as String
 //   */
-//  public abstract String getQueryString();
+//  String getQueryString();
 
   /* Dimension : fields */
-  public abstract void setFields(String... fieldNames);
+  void setFields(String... fieldNames);
 
-  public abstract String[] getFields();
+  String[] getFields();
 
   /* Dimension : key */ 
-  public abstract void setKey(K key);
+  void setKey(K key);
 
-  public abstract void setStartKey(K startKey);
+  void setStartKey(K startKey);
 
-  public abstract void setEndKey(K endKey);
+  void setEndKey(K endKey);
 
-  public abstract void setKeyRange(K startKey, K endKey);
+  void setKeyRange(K startKey, K endKey);
 
-  public abstract K getKey();
+  K getKey();
 
-  public abstract K getStartKey();
+  K getStartKey();
 
-  public abstract K getEndKey();
+  K getEndKey();
   
   /* Dimension : time */
-  public abstract void setTimestamp(long timestamp);
+  void setTimestamp(long timestamp);
 
-  public abstract void setStartTime(long startTime);
+  void setStartTime(long startTime);
 
-  public abstract void setEndTime(long endTime);
+  void setEndTime(long endTime);
 
-  public abstract void setTimeRange(long startTime, long endTime);
+  void setTimeRange(long startTime, long endTime);
 
-  public abstract long getTimestamp();
+  long getTimestamp();
 
-  public abstract long getStartTime();
+  long getStartTime();
 
-  public abstract long getEndTime();
-
-//  public abstract void setFilter(String filter);
-//  
-//  public abstract String getFilter();
+  long getEndTime();
   
   /**
    * Sets the maximum number of results to return.
    */
-  public abstract void setLimit(long limit);
+  void setLimit(long limit);
 
   /**
    * Returns the maximum number of results
    * @return the limit if it is set, otherwise a negative number
    */
-  public abstract long getLimit();
-
-  /* parameters */
-  /*
-  public abstract void setParam(int paramIndex, int value);
-  
-  public abstract void setParam(String paramName, int value);
-  
-  public abstract void setParam(int paramIndex, long value);
-  
-  public abstract void setParam(String paramName, long value);
-  
-  public abstract void setParam(int paramIndex, String value);
-  
-  public abstract void setParam(String paramName, String value);
-  
-  public abstract void setParam(int paramIndex, boolean value);
-  
-  public abstract void setParam(String paramName, boolean value);
-  
-  public abstract void setParam(int paramIndex, double value);
-  
-  public abstract void setParam(String paramName, double value);
-  
-  public abstract void setParam(int paramIndex, char value);
-  
-  public abstract void setParam(String paramName, char value);
-  
-  public abstract void setParam(int paramIndex, Date value);
-  
-  public abstract void setParam(String paramName, Date value);
-  */
-    
+  long getLimit();
 }

Modified: incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/Result.java
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/Result.java?rev=1133275&r1=1133274&r2=1133275&view=diff
==============================================================================
--- incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/Result.java (original)
+++ incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/query/Result.java Wed Jun
 8 08:01:13 2011
@@ -35,56 +35,56 @@ public interface Result<K,T extends Pers
    * Returns the DataStore, that this Result is associated with.
    * @return the DataStore of the Result
    */
-  public abstract DataStore<K,T> getDataStore();
+  DataStore<K,T> getDataStore();
   
   /**
    * Returns the Query object for this Result.
    * @return the Query object for this Result.
    */
-  public abstract Query<K, T> getQuery();
+  Query<K, T> getQuery();
   
   /**
    * Advances to the next element and returns false if at end.
    * @return true if end is not reached yet
    */
-  public abstract boolean next() throws IOException;
+  boolean next() throws IOException;
   
   /**
    * Returns the current key.
    * @return current key
    */
-  public abstract K getKey();
+  K getKey();
   
   /**
    * Returns the current object.
    * @return current object
    */
-  public abstract T get();
+  T get();
   
   /**
    * Returns the class of the keys
    * @return class of the keys
    */
-  public abstract Class<K> getKeyClass();
+  Class<K> getKeyClass();
     
   /**
    * Returns the class of the persistent objects
    * @return class of the persistent objects
    */
-  public abstract Class<T> getPersistentClass();
+  Class<T> getPersistentClass();
   
   /**
    * Returns the number of times next() is called with return value true.
    * @return the number of results so far
    */
-  public long getOffset();
+  long getOffset();
   
   /**
    * Returns how far along the result has iterated, a value between 0 and 1.
    */
-  public float getProgress() throws IOException;
+  float getProgress() throws IOException;
   
   @Override
-  public abstract void close() throws IOException;
+  void close() throws IOException;
   
 }

Modified: incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/store/DataStore.java
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/store/DataStore.java?rev=1133275&r1=1133274&r2=1133275&view=diff
==============================================================================
--- incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/store/DataStore.java (original)
+++ incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/store/DataStore.java Wed
Jun  8 08:01:13 2011
@@ -52,38 +52,38 @@ public interface DataStore<K, T extends 
    * @param properties extra metadata
    * @throws IOException
    */
-  public abstract void initialize(Class<K> keyClass, Class<T> persistentClass,
+  void initialize(Class<K> keyClass, Class<T> persistentClass,
       Properties properties) throws IOException;
 
   /**
    * Sets the class of the keys
    * @param keyClass the class of keys
    */
-  public abstract void setKeyClass(Class<K> keyClass);
+  void setKeyClass(Class<K> keyClass);
 
   /**
    * Returns the class of the keys
    * @return class of the keys
    */
-  public abstract Class<K> getKeyClass();
+  Class<K> getKeyClass();
 
   /**
    * Sets the class of the persistent objects
    * @param persistentClass class of persistent objects
    */
-  public abstract void setPersistentClass(Class<T> persistentClass);
+  void setPersistentClass(Class<T> persistentClass);
 
   /**
    * Returns the class of the persistent objects
    * @return class of the persistent objects
    */
-  public abstract Class<T> getPersistentClass();
+  Class<T> getPersistentClass();
 
   /**
    * Returns the schema name given to this DataStore
    * @return schema name
    */
-  public abstract String getSchemaName();
+  String getSchemaName();
 
   /**
    * Creates the optional schema or table (or similar) in the datastore
@@ -91,26 +91,26 @@ public interface DataStore<K, T extends 
    * or the underlying data model does not support
    * or need this operation, the operation is ignored.
    */
-  public abstract void createSchema() throws IOException;
+  void createSchema() throws IOException;
 
   /**
    * Deletes the underlying schema or table (or similar) in the datastore
    * that holds the objects. This also deletes all the data associated with
    * the schema.
    */
-  public abstract void deleteSchema() throws IOException;
+  void deleteSchema() throws IOException;
 
   /**
    * Deletes all the data associated with the schema, but keeps the
    * schema (table or similar) intact.
    */
-  public abstract void truncateSchema() throws IOException;
+  void truncateSchema() throws IOException;
 
   /**
    * Returns whether the schema that holds the data exists in the datastore.
    * @return whether schema exists
    */
-  public abstract boolean schemaExists() throws IOException;
+  boolean schemaExists() throws IOException;
 
   /**
    * Returns a new instance of the key object. If the object cannot be instantiated 
@@ -119,20 +119,20 @@ public interface DataStore<K, T extends 
    * make sure that the key class has a no-arg constructor.   
    * @return a new instance of the key object.
    */
-  public abstract K newKey() throws IOException;
+  K newKey() throws IOException;
 
   /**
    * Returns a new instance of the managed persistent object.
    * @return a new instance of the managed persistent object.
    */
-  public abstract T newPersistent() throws IOException;
+  T newPersistent() throws IOException;
 
   /**
    * Returns the object corresponding to the given key fetching all the fields.
    * @param key the key of the object
    * @return the Object corresponding to the key or null if it cannot be found
    */
-  public abstract T get(K key) throws IOException;
+  T get(K key) throws IOException;
 
   /**
    * Returns the object corresponding to the given key.
@@ -140,39 +140,39 @@ public interface DataStore<K, T extends 
    * @param fields the fields required in the object. Pass null, to retrieve all fields
    * @return the Object corresponding to the key or null if it cannot be found
    */
-  public abstract T get(K key, String[] fields) throws IOException;
+  T get(K key, String[] fields) throws IOException;
 
   /**
    * Inserts the persistent object with the given key.
    */
-  public abstract void put(K key, T obj) throws IOException;
+  void put(K key, T obj) throws IOException;
 
   /**
    * Deletes the object with the given key
    * @param key the key of the object
    * @return whether deleted the object successfuly
    */
-  public abstract boolean delete(K key) throws IOException;
+  boolean delete(K key) throws IOException;
 
   /**
    * Deletes all the objects matching the query.
    * @param query matching records to this query will be deleted
    * @return number of deleted records
    */
-  public abstract long deleteByQuery(Query<K, T> query) throws IOException;
+  long deleteByQuery(Query<K, T> query) throws IOException;
 
   /**
    * Executes the given query and returns the results.
    * @param query the query to execute.
    * @return the results as a {@link Result} object.
    */
-  public abstract Result<K,T> execute(Query<K, T> query) throws IOException;
+  Result<K,T> execute(Query<K, T> query) throws IOException;
 
   /**
    * Constructs and returns a new Query.
    * @return a new Query.
    */
-  public abstract Query<K, T> newQuery();
+  Query<K, T> newQuery();
 
   /**
    * Partitions the given query and returns a list of {@link PartitionQuery}s,
@@ -182,39 +182,34 @@ public interface DataStore<K, T extends 
    * (returning every object)
    * @return a List of PartitionQuery's
    */
-  public abstract List<PartitionQuery<K,T>> getPartitions(Query<K,T> query)
+  List<PartitionQuery<K,T>> getPartitions(Query<K,T> query)
     throws IOException;
 
   /**
    * Forces the write caches to be flushed.
    */
-  public abstract void flush() throws IOException;
+  void flush() throws IOException;
 
   /**
    * Sets the {@link BeanFactory} to use by the DataStore.
    * @param beanFactory the BeanFactory to use
    */
-  public abstract void setBeanFactory(BeanFactory<K,T> beanFactory);
+  void setBeanFactory(BeanFactory<K,T> beanFactory);
 
   /**
    * Returns the BeanFactory used by the DataStore
    * @return the BeanFactory used by the DataStore
    */
-  public abstract BeanFactory<K,T> getBeanFactory();
+  BeanFactory<K,T> getBeanFactory();
 
-  @Override
-  public abstract void close() throws IOException;
+  void close() throws IOException;
 
-  @Override
-  public Configuration getConf();
+  Configuration getConf();
 
-  @Override
-  public void setConf(Configuration conf);
+  void setConf(Configuration conf);
 
-  @Override
-  public void readFields(DataInput in) throws IOException;
+  void readFields(DataInput in) throws IOException;
 
-  @Override
-  public void write(DataOutput out) throws IOException;
+  void write(DataOutput out) throws IOException;
 
 }

Modified: incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/store/FileBackedDataStore.java
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/store/FileBackedDataStore.java?rev=1133275&r1=1133274&r2=1133275&view=diff
==============================================================================
--- incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/store/FileBackedDataStore.java
(original)
+++ incubator/gora/trunk/gora-core/src/main/java/org/apache/gora/store/FileBackedDataStore.java
Wed Jun  8 08:01:13 2011
@@ -28,20 +28,20 @@ import org.apache.gora.persistency.Persi
  */
 public interface FileBackedDataStore<K, T extends Persistent> extends DataStore<K,
T> {
 
-  public void setInputPath(String inputPath);
+  void setInputPath(String inputPath);
   
-  public void setOutputPath(String outputPath);
+  void setOutputPath(String outputPath);
   
-  public String getInputPath();
+  String getInputPath();
   
-  public String getOutputPath();
+  String getOutputPath();
   
-  public void setInputStream(InputStream inputStream);
+  void setInputStream(InputStream inputStream);
   
-  public void setOutputStream(OutputStream outputStream);
+  void setOutputStream(OutputStream outputStream);
 
-  public InputStream getInputStream();
+  InputStream getInputStream();
   
-  public OutputStream getOutputStream();
+  OutputStream getOutputStream();
   
 }

Modified: incubator/gora/trunk/gora-tutorial/src/main/java/org/apache/gora/tutorial/log/LogAnalytics.java
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-tutorial/src/main/java/org/apache/gora/tutorial/log/LogAnalytics.java?rev=1133275&r1=1133274&r2=1133275&view=diff
==============================================================================
--- incubator/gora/trunk/gora-tutorial/src/main/java/org/apache/gora/tutorial/log/LogAnalytics.java
(original)
+++ incubator/gora/trunk/gora-tutorial/src/main/java/org/apache/gora/tutorial/log/LogAnalytics.java
Wed Jun  8 08:01:13 2011
@@ -163,8 +163,7 @@ public class LogAnalytics extends Config
     
     if(args.length > 0) {
       String dataStoreClass = args[0];
-      inStore = DataStoreFactory.getDataStore(dataStoreClass, 
-          Long.class, Pageview.class);
+      inStore = DataStoreFactory.getDataStore(dataStoreClass, Long.class, Pageview.class);
       if(args.length > 1) {
         dataStoreClass = args[1];
       }



Mime
View raw message