Return-Path: X-Original-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D65DB9857 for ; Tue, 24 Apr 2012 10:28:40 +0000 (UTC) Received: (qmail 46606 invoked by uid 500); 24 Apr 2012 10:28:40 -0000 Delivered-To: apmail-incubator-giraph-dev-archive@incubator.apache.org Received: (qmail 46479 invoked by uid 500); 24 Apr 2012 10:28:35 -0000 Mailing-List: contact giraph-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: giraph-dev@incubator.apache.org Delivered-To: mailing list giraph-dev@incubator.apache.org Received: (qmail 46429 invoked by uid 99); 24 Apr 2012 10:28:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Apr 2012 10:28:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4EEF21C02DF; Tue, 24 Apr 2012 10:28:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0871647411413827614==" MIME-Version: 1.0 Subject: Re: Review Request: Improve concurrency of putMsg / putMsgList From: "Claudio Martella" To: "Bo Wang" , "Claudio Martella" , "giraph" Date: Tue, 24 Apr 2012 10:28:33 -0000 Message-ID: <20120424102833.2085.34082@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/4852/ In-Reply-To: <20120424061138.21656.62710@reviews.apache.org> References: <20120424061138.21656.62710@reviews.apache.org> --===============0871647411413827614== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4852/#review7169 ----------------------------------------------------------- Looks good to me, wound't hurt to see some stress test to check performance= , although I wouldn't expect this to be slower than the synchronized block.= Also, I'd agree that moving the messages directly from the inMessages to t= he Vertex could be a memory win. - Claudio On 2012-04-24 06:11:38, Bo Wang wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4852/ > ----------------------------------------------------------- > = > (Updated 2012-04-24 06:11:38) > = > = > Review request for giraph. > = > = > Summary > ------- > = > Use ConcurrentHashMap and ConcurrentLinkedQueue to allow concurrent asses= s to message map. The concurrencyLevel of ConcurrentHashMap uses the defaul= t value. There may be some performance gain by tuning this value. > = > = > This addresses bug GIRAPH-185. > https://issues.apache.org/jira/browse/GIRAPH-185 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/or= g/apache/giraph/comm/BasicRPCCommunications.java 1328747 = > = > Diff: https://reviews.apache.org/r/4852/diff > = > = > Testing > ------- > = > = > Thanks, > = > Bo > = > --===============0871647411413827614==--