incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-179) BspServiceMaster's PathFilter can be simplified
Date Wed, 11 Apr 2012 21:33:18 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251940#comment-13251940
] 

Hudson commented on GIRAPH-179:
-------------------------------

Integrated in Giraph-trunk-Commit #101 (See [https://builds.apache.org/job/Giraph-trunk-Commit/101/])
    GIRAPH-179: BspServiceMaster's PathFilter can be simplified. Contributed by Devaraj K.
(Revision 1324991)

     Result = SUCCESS
jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324991
Files : 
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java

                
> BspServiceMaster's PathFilter can be simplified
> -----------------------------------------------
>
>                 Key: GIRAPH-179
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-179
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Devaraj K
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-179.patch
>
>
> {code}  /**
>    * Only get the finalized checkpoint files
>    */
>   public static class FinalizedCheckpointPathFilter implements PathFilter {
>     @Override
>     public boolean accept(Path path) {
>       if (path.getName().endsWith(
>           BspService.CHECKPOINT_FINALIZED_POSTFIX)) {
>         return true;
>       }
>       return false;
>     }
>   }{code}
> we can simplify this, eliminating the if statement and just returning the result of {{endsWith()}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message