incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Re: Review Request: Improve concurrency of putMsg / putMsgList
Date Tue, 24 Apr 2012 20:53:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4852/#review7185
-----------------------------------------------------------



http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
<https://reviews.apache.org/r/4852/#comment15860>

    Bo, I'm a little leery about converting the List and ArrayList to LinkedList and ConcurrentLinkedList.
 I believe that linked list's will use more memory than the array list due to the double links
(forward and backward).  Also, is ConcurrentLinkedList supposted to outperform a synchronized
ArrayList?  I haven't seen much on that.
    
    The concurrenthashmap changes look good.


- Avery


On 2012-04-24 06:11:38, Bo Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4852/
> -----------------------------------------------------------
> 
> (Updated 2012-04-24 06:11:38)
> 
> 
> Review request for giraph.
> 
> 
> Summary
> -------
> 
> Use ConcurrentHashMap and ConcurrentLinkedQueue to allow concurrent assess to message
map. The concurrencyLevel of ConcurrentHashMap uses the default value. There may be some performance
gain by tuning this value.
> 
> 
> This addresses bug GIRAPH-185.
>     https://issues.apache.org/jira/browse/GIRAPH-185
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
1328747 
> 
> Diff: https://reviews.apache.org/r/4852/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message