incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claudio Martella" <claudio.marte...@gmail.com>
Subject Re: Review Request: Improve concurrency of putMsg / putMsgList
Date Tue, 24 Apr 2012 10:28:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4852/#review7169
-----------------------------------------------------------


Looks good to me, wound't hurt to see some stress test to check performance, although I wouldn't
expect this to be slower than the synchronized block. Also, I'd agree that moving the messages
directly from the inMessages to the Vertex could be a memory win.

- Claudio


On 2012-04-24 06:11:38, Bo Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4852/
> -----------------------------------------------------------
> 
> (Updated 2012-04-24 06:11:38)
> 
> 
> Review request for giraph.
> 
> 
> Summary
> -------
> 
> Use ConcurrentHashMap and ConcurrentLinkedQueue to allow concurrent assess to message
map. The concurrencyLevel of ConcurrentHashMap uses the default value. There may be some performance
gain by tuning this value.
> 
> 
> This addresses bug GIRAPH-185.
>     https://issues.apache.org/jira/browse/GIRAPH-185
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
1328747 
> 
> Diff: https://reviews.apache.org/r/4852/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message