incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (GIRAPH-175) Replace manual array copy to utility method call
Date Sat, 07 Apr 2012 20:26:17 GMT
Replace manual array copy to utility method call
------------------------------------------------

                 Key: GIRAPH-175
                 URL: https://issues.apache.org/jira/browse/GIRAPH-175
             Project: Giraph
          Issue Type: Improvement
            Reporter: Jakob Homan
            Priority: Trivial


{code}      String[] zkJavaOptsArray = zkJavaOptsString.split(" ");
      if (zkJavaOptsArray != null) {
        for (String javaOpt : zkJavaOptsArray) {
          commandList.add(javaOpt);
        }
      }{code}
Rather than doing the loop ourselves, Collections.addAll would be simpler (and faster, though
that doesn't matter with such a small array).  Still cleaner, though.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message