incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj K (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GIRAPH-175) Replace manual array copy to utility method call
Date Fri, 13 Apr 2012 15:54:18 GMT

     [ https://issues.apache.org/jira/browse/GIRAPH-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Devaraj K updated GIRAPH-175:
-----------------------------

    Attachment: GIRAPH-175.patch
    
> Replace manual array copy to utility method call
> ------------------------------------------------
>
>                 Key: GIRAPH-175
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-175
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Priority: Trivial
>         Attachments: GIRAPH-175.patch
>
>
> {code}      String[] zkJavaOptsArray = zkJavaOptsString.split(" ");
>       if (zkJavaOptsArray != null) {
>         for (String javaOpt : zkJavaOptsArray) {
>           commandList.add(javaOpt);
>         }
>       }{code}
> Rather than doing the loop ourselves, Collections.addAll would be simpler (and faster,
though that doesn't matter with such a small array).  Still cleaner, though.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message