incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Koontz (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-184) Upgrade to junit4
Date Mon, 16 Apr 2012 17:46:21 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254834#comment-13254834
] 

Eugene Koontz commented on GIRAPH-184:
--------------------------------------

Hi Devaraj,
I noticed in your patch, for {{src/test/java/org/apache/giraph/TestBspBasic.java}}, you added:


{code}
import org.junit.Assert;
import org.junit.Test;
{code}

within the scope of a munge ifdef - it should be outside of the ifdef, shouldn't it?

Even with this fix, I get 7 test failures:

{code}
Results :

Tests in error: 
  initializationError0(org.apache.giraph.TestManualCheckpoint)
  initializationError0(org.apache.giraph.TestAutoCheckpoint)
  initializationError0(org.apache.giraph.TestBspBasic)
  initializationError0(org.apache.giraph.TestGraphPartitioner)
  initializationError0(org.apache.giraph.TestNotEnoughMapTasks)
  initializationError0(org.apache.giraph.TestMutateGraphVertex)
  initializationError0(org.apache.giraph.TestJsonBase64Format)

Tests run: 50, Failures: 0, Errors: 7, Skipped: 0

{code}

                
> Upgrade to junit4
> -----------------
>
>                 Key: GIRAPH-184
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-184
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Devaraj K
>         Attachments: GIRAPH-184.patch
>
>
> Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message